ylqjgm
/
ffi-icu
mirror of https://github.com/erickguan/ffi-icu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Flip locales for consistency with other Locale API methods

This commit is contained in:
Damian Nelson 2023-12-27 14:09:14 -08:00
parent 7a7ad193fe
commit 6e6b9e5a05
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/ffi-icu/locale.rb
View File

@ -104,9 +104,9 @@ module ICU
def display_name_with_context(locale, contexts = []) def display_name_with_context(locale, contexts = [])
contexts = DISPLAY_CONTEXT.select { |context| contexts.include?(context) }.values contexts = DISPLAY_CONTEXT.select { |context| contexts.include?(context) }.values
with_locale_display_name(@id, contexts) do |locale_display_names| with_locale_display_name(locale, contexts) do |locale_display_names|
Lib::Util.read_uchar_buffer(256) do |buffer, status| Lib::Util.read_uchar_buffer(256) do |buffer, status|
Lib.uldn_localeDisplayName(locale_display_names, locale, buffer, buffer.size, status) Lib.uldn_localeDisplayName(locale_display_names, @id, buffer, buffer.size, status)
end end
end end
end end

6
spec/locale_spec.rb
View File

@ -124,8 +124,8 @@ module ICU
end end
it 'returns the name using display context' do it 'returns the name using display context' do
expect(Locale.new('en_US').display_name_with_context('en_HK', [:length_full])).to eq('English (Hong Kong SAR China)') expect(Locale.new('en_HK').display_name_with_context('en_US', [:length_full])).to eq('English (Hong Kong SAR China)')
expect(Locale.new('en_US').display_name_with_context('en_HK', [:length_short])).to eq('English (Hong Kong)') expect(Locale.new('en_HK').display_name_with_context('en_US', [:length_short])).to eq('English (Hong Kong)')
end end
it 'returns the script' do it 'returns the script' do
@ -145,7 +145,7 @@ module ICU
expect(Locale.new('en_VI').display_country('ccp')).to_not be_nil expect(Locale.new('en_VI').display_country('ccp')).to_not be_nil
expect(Locale.new('yue_Hant').display_language('ccp')).to_not be_nil expect(Locale.new('yue_Hant').display_language('ccp')).to_not be_nil
expect(Locale.new('en_VI').display_name('ccp')).to_not be_nil expect(Locale.new('en_VI').display_name('ccp')).to_not be_nil
expect(Locale.new('ccp').display_name_with_context('en_VI')).to_not be_nil expect(Locale.new('en_VI').display_name_with_context('ccp')).to_not be_nil
expect(Locale.new('yue_Hant').display_script('ccp')).to_not be_nil expect(Locale.new('yue_Hant').display_script('ccp')).to_not be_nil
expect(Locale.new('en_US_POSIX').display_variant('sl')).to_not be_nil expect(Locale.new('en_US_POSIX').display_variant('sl')).to_not be_nil
end end