ff2fa04ed4
This is a squashed commit of g/54335 and g/54489 Because Internet Explorer is crazy and has SVGs as focusable by default, we add the focusable="false" attribute to all the SVGs so that they don't recieve focus in IE. refs CNVS-18489 Test Plan: - Turn on new styles (Settings > Feature Options > Use New Styles) - Navigation should now appear as left panel * Please note that sometimes because of caching it may take a bit for you to see new styles, restarting the server makes this much quicker :) - Verify inbox unread count should show if there are unread items. - Verify links work, the inbox and calendar should take you where you want to go. - Verify the avatar image is shown on the Profile item. - Verify Courses tray * Clicking, or pressing Space/Enter on Courses should open tray * Clicking away, or pressing Esc should close tray * Focus should be returned to Courses when tray is closed * The same behaviors should also work with any of the - If you have admin (account) access, you should have an "accounts" option. Clicking it should cause a list of accounts to fly out. - If you have groups, you should have a "groups" option. Clicking it should show the flyout list with groups in it. - The Profile nav item should cause a profile flyout to open. Change-Id: Id73bca9470d2fd422e56f6de317db5518b393923 (+1 squashed commit) Squashed commits: [3f96364] refs CNVS-18489 test plan: 1. 2. 3. 4. 6. Verify Courses tray - Clicking, or pressing Space/Enter on Courses should open tray - Clicking away, or pressing Esc should close tray - Focus should be returned to Courses when tray is closed Change-Id: I904a344cfc5ae75e1e4757aab30796f98779e4f6 Reviewed-on: https://gerrit.instructure.com/54335 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Clare Strong <clare@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> |
||
---|---|---|
.. | ||
helpers | ||
README.md | ||
SVGWrapper.jsx | ||
modal-buttons.jsx | ||
modal-content.jsx | ||
modal.jsx |
README.md
This folder is for genuinely shared stuff only.
If your code is the only code using a module that you want to put in here:
- Don't put it in here
- List it below as "potentially shared"
Potentially shared
These modules are potentially shared but only used in one feature. If you can use one of them in your feature, please move it into this directory and update the require paths in the other feature.
- path/to/file.js