ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/app/views/submission_comments
History
Gary Mei 6250c99e36 fix utf8 comments crashing prawn 
fixes TALLY-158
flag=none

Generating PDF files using the built-in Helvetiva font would cause
prawn to raise an error if a UTF-8 character was present that
Windows-1252 did not support.

This change is a partial revert of
25bd35cf79, but the fonts are only used
in the context of prawn at the moment.

Test Plan
- Create an assignment.
- Leave a comment on one of the assignment's submission using a
  UTF-8 character that Windows-1252 does not support, such as "ă".
- Verify that downloading submission comments generates a PDF, and
  that the "ă" character is present.

Change-Id: Idc7bd1400fb337d384b38a76ebf83639bdc770cf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/222482
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
QA-Review: Gary Mei <gmei@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
 		2020-01-09 21:26:52 +00:00
..
index.pdf.prawn fix utf8 comments crashing prawn 2020-01-09 21:26:52 +00:00