f7e168c77b
Do not attempt to submit comments in SpeedGrader if a submission request
is already in progress. Although we already disable the "Submit" button
while waiting for a response, navigating between students would still
attempt to record the current comment text as a draft (even if the user
had already explicitly saved it) without checking whether a request was
in progress.
flag=none
fixes TALLY-620
Test plan:
- Have a course with an assignment and some students
- Open SpeedGrader for the assignment
- Ensure the server will take a while to process comment requests
- To do this, you can make a change on the server to force a reload
(e.g., add a line to update_submission in gradebooks_controller),
or get yourself a terrible internet connection if you're not testing
locally.
- Ensure non-draft comments aren't wrongly saved as drafts:
- Type some text in the comment box for a student
- Click "Submit"
- Immediately start hitting the "j" and/or "k" keys with great vigor
- This should *not* cause a zillion draft comments to be saved
- Eventually the actual submission request should finish, and should
add a non-draft comment for the intended student (and only that
student)
- Ensure draft comments only get one copy saved:
- Slow down your server again, as above
- Type some comment text, but do not submit it
- Using the arrow buttons at the top, furiously move between students
- This should *not* cause zillions of draft comments to be saved
- Eventually, the actual draft comment should be saved for the
intended student (and only that student)
- Ensure the more civilized behavior below works as expected:
- Submitting a comment and calmly waiting for the submission to go
through
- Typing some comment text, switching students, and waiting for the
draft comment to be saved without making a ruckus
- Typing some comment text, closing the page, and then re-opening the
page with no hullabaloo (the text should have been saved as a draft)
Change-Id: I57e0781333c763ba22842749f0130fe6c21eb319
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/237373
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Jeremy Neander <jneander@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
|
||
|---|---|---|
| .github | ||
| Gemfile.d | ||
| app | ||
| bin | ||
| build | ||
| client_apps | ||
| config | ||
| db/migrate | ||
| doc | ||
| docker-compose | ||
| frontend_build | ||
| gems | ||
| hooks | ||
| jest | ||
| lib | ||
| packages | ||
| pact | ||
| public | ||
| script | ||
| spec | ||
| .bowerrc | ||
| .codeclimate.yml | ||
| .dive-ci | ||
| .dockerignore | ||
| .editorconfig | ||
| .eslintignore | ||
| .eslintrc.js | ||
| .gitignore | ||
| .gitmessage | ||
| .i18nignore | ||
| .i18nrc | ||
| .lintstagedrc.js | ||
| .npmrc | ||
| .nvmrc | ||
| .prettierrc | ||
| .rubocop.yml | ||
| .stylelintrc | ||
| .travis.yml | ||
| CONTRIBUTING.md | ||
| COPYRIGHT | ||
| Dockerfile | ||
| Dockerfile-production | ||
| Dockerfile.githook | ||
| Dockerfile.package-translations | ||
| Gemfile | ||
| Jenkinsfile | ||
| Jenkinsfile.contract-tests | ||
| Jenkinsfile.dive | ||
| Jenkinsfile.js | ||
| Jenkinsfile.main-for-coverage | ||
| Jenkinsfile.master-bouncer-check-all | ||
| Jenkinsfile.package-translations | ||
| Jenkinsfile.selenium.flakey_spec_catcher | ||
| Jenkinsfile.selenium.performance.chrome | ||
| Jenkinsfile.test-subbuild | ||
| Jenkinsfile.vendored-gems | ||
| Jenkinsfile.xbrowser | ||
| LICENSE | ||
| README.md | ||
| Rakefile | ||
| babel.config.js | ||
| bower.json | ||
| code_of_conduct.md | ||
| config.ru | ||
| docker-compose.jenkins.yml | ||
| docker-compose.new-jenkins-flakey-spec-catcher.yml | ||
| docker-compose.new-jenkins-karma.yml | ||
| docker-compose.new-jenkins-package-translations.yml | ||
| docker-compose.new-jenkins-selenium.yml | ||
| docker-compose.new-jenkins.canvas.yml | ||
| docker-compose.new-jenkins.consumer.yml | ||
| docker-compose.new-jenkins.multiple-processes.yml | ||
| docker-compose.new-jenkins.vendored-gems.yml | ||
| docker-compose.new-jenkins.yml | ||
| docker-compose.spring.yml | ||
| docker-compose.yml | ||
| gulpfile.js | ||
| issue_template.md | ||
| jest.config.js | ||
| karma.conf.js | ||
| package.json | ||
| parallel_runtime_rspec.log | ||
| stats-prod.json | ||
| webpack.config.js | ||
| webpack.test.config.js | ||
| yarn.lock | ||
README.md
Canvas LMS
Canvas is a modern, open-source LMS developed and maintained by Instructure Inc. It is released under the AGPLv3 license for use by anyone interested in learning more about or using learning management systems.
Please see our main wiki page for more information
Installation
Detailed instructions for installation and configuration of Canvas are provided on our wiki.