c9c41c89b9
Fixes: CNVS-26160 Note for reviewer: In addition to fixing the bug, I also fixed some small issues with the print styles and the new UI: - Hamburger button and header no longer print - Margins for the primary nav and the context nav have been removed, so the printing can cover the whole width of the page. Test plan: - Create a very long page in a course. Print it to PDF/Preview in Chrome or another unaffected browser to confirm it prints over more than one page. - Open the same page in Firefox. Go to Print > PDF > Open PDF in Preview (see bug report in JIRA for a video) - Confirm that the page prints to PDF/Preview successfully. There should be no more cutoff, as reported in the bug. Change-Id: Ibed9f83af1fddaea20524fa552539ce337b5f204 Reviewed-on: https://gerrit.instructure.com/71378 Tested-by: Jenkins Reviewed-by: Jennifer Stern <jstern@instructure.com> Product-Review: Jennifer Stern <jstern@instructure.com> QA-Review: Myller de Araujo <myller@instructure.com> |
||
---|---|---|
.. | ||
account_course_user_search | ||
assignments | ||
authentication_providers | ||
context_modules | ||
course_link_validator | ||
course_wizard | ||
dashboard_card | ||
discussion_topics | ||
due_dates | ||
epub_exports | ||
external_apps | ||
files | ||
gradebook | ||
grading | ||
groups | ||
navigation_header | ||
outcomes | ||
shared | ||
styleguide | ||
theme_editor | ||
README.md |
README.md
This directory is temporary until we rework the front-end build This is where we are headed.
Stuff you can do in Canvas JSX files
BUT WAIT!
Your file needs to:
- Have a file name with the
.jsx
extension.
JSX
function foo(paths) {
return <svg>{paths}</svg>;
}
Arrow Functions
var arr = ['hydrogen', 'helium', 'lithium'];
// es5
var a = arr.map(function(s){ return s.length });
// es6
var b = arr.map( s => s.length );
// with curlies requires normal return
var b = arr.map( (s) => {
return s.length
});
// lexical `this`
var obj = {
multiplier: 3,
multiplyStuff (stuff) {
return stuff.map((x) =>
// no bind!
return this.multiplier * x;
)
}
};
Classes
class EventEmitter {
constructor() {
// called when created
}
emit() {
// ...
}
on() {
// ...
}
once() {
// ...
}
removeListener() {
// ...
}
removeAllListeners() {
// ...
}
}
Extending and calling super
.
class Domain extends EventEmitter {
constructor() {
super();
this.members = [];
}
}
Creating instances
var domain = new Domain();
Destructuring
// es5
var map = _.map;
var each = _.each;
// es6
var {map, each} = _;
Concise Object Methods
// es5
var obj = {
foo: function() {}
bar: function() {}
};
// es6
var obj = {
foo() {}
bar() {}
};
Object Short Notation
// es5
function() {
// ...
return {foo: foo, bar: bar, x: 10};
}
// es6
function() {
// ...
return {foo, bar, x: 10};
}
Rest Parameters
// es5
function multiply(multiplier) {
var numbers = Array.prototype.slice.call(arguments, 0);
return number.map(function(n) { return multiplier * n; });
}
// es6
function multiply(multiplier, ...numbers) {
return numbers.map( n => multiplier * n);
}
String Templates
Multiline strings:
// es5
console.log("string text line 1" +
"string text line 2");
// es6
console.log(`string text line 1
string text line 2`);
Interpolated strings
var a = 5;
var b = 10;
// es5
console.log("Fifteen is " + (a + b) + " and not " + (2 * a + b) + ".");
// es6
console.log(`Fifteen is ${a + b} and not ${2 * a + b}.`);