canvas-lms/gems/dr_diff
Rex Fleischer 9454b7cd97 remove skipping linters if whitelisted engineer
fixes: CCI-362
flag = none

Test-Plan:
build passes

Change-Id: Ied7b5c1923bb1c5e0314b13b7cab8d9e9a93028a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/236433
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
Product-Review: Gentry Beckmann <gbeckmann@instructure.com>
QA-Review: Rex Fleischer <rfleischer@instructure.com>
2020-05-08 15:17:49 +00:00
..
config incremental linting via dr diff, fixes SD-1521 2016-09-22 20:06:57 +00:00
lib remove skipping linters if whitelisted engineer 2020-05-08 15:17:49 +00:00
spec spec: get the vendored gems build working in new jenkins 2019-08-21 18:18:20 +00:00
Gemfile incremental linting via dr diff, fixes SD-1521 2016-09-22 20:06:57 +00:00
README.md incremental linting via dr diff, fixes SD-1521 2016-09-22 20:06:57 +00:00
Rakefile incremental linting via dr diff, fixes SD-1521 2016-09-22 20:06:57 +00:00
dr_diff.gemspec bump gergich 2017-05-30 14:58:04 +00:00
test.sh incremental linting via dr diff, fixes SD-1521 2016-09-22 20:06:57 +00:00

README.md

Dr Diff

Dr Diff is a linter's best friend forever.

Say you want to add rubocop or eslint to your project, but you'd have to fix a million linter errors throughout your monolithic app for the linter to pass your commit. Don't worry, Dr Diff is here! He can make your linter run only on the diff of your commit! That is, only on the files/lines your commit changed. Huzzah! Now you can polish your app one small piece at a time, saving your QA friends from:

add rubocop, fixes CNVS-1234

test plan:
* regression test the entire app

Usage

require "dr_diff"

# Create a manager.
# -- (optional) git_dir (uses cwd by default)
# -- (optional) sha (runs on outstanding changes by default)
dr_diff = DrDiff::Manager.new(git_dir: git_dir, sha: env_sha)

# Collect the files for this change.
# -- (optional) regex to filter results
ruby_files = dr_diff.files(/\.rb$/)

# Collect relevant linter comments.
# -- (required) format
# -- (required) command
# Under the hood, Dr Diff uses Gergich (github.com/instructure/gergich)
# to collect linter comments.
# See github.com/instructure/gergich#gergich-capture-format-command
# for details on format and command parameters.
comments = dr_diff.comments(format: "rubocop",
                            command: "rubocop #{ruby_files.join(' ')}")

# These comments will be objects of the form:
# {
#   path: "/path/to/file.rb",
#   message: "[rubocop] Avoid using sleep.\n\n       sleep 1\n       ^^^^^^^\n",
#   position: 5, # line number
#   severity: "error" # one of %w(error warn info)
# }

# If you are using gergich, you may want him to post these comments via:
if comments.length > 0
  require 'shellwords'
  `gergich comment #{Shellwords.escape(comments.to_json)}`
end

# Take a peek at /script/rlint to see how Canvas uses Dr Diff.