ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/lib
History
Colleen Palmer e84bd4dd80 Revert and bring InstIcons into Canvas 
closes: CNVS-32953

This commit re-introduces Instructure Icons into Canvas.
Due to the range in aesthetic impact of including both line
and solid icons, the change is expansive and will be refined
in subsequent commits. The purpose of this commit is to:

- Make InstIcons available in Canvas allowing the use of the
  react components

- Replace the current icon font with the new InstIcons font

- Allow for use of both 'Line' and 'Solid' icon variants

- Update the styleguide to reference the InstIcons github
  documentation for examples

- Remove font custom from Canvas

Icons changed to line versions in Canvas:
- icon-compose (view on Dashboard card)
- icon-info (view on global notification)

- Updated icons to be larger for better visibility
  (our old font was using a small font size)

- Updated font-size is now relative vs fixed, so better a11y

Test Plan:

- On compiling, icons in Canvas should now be changed to the
  corresponding Instructure Icons as can be seen here
  http://instructure.github.io/instructure-icons/

- The icon default displaying in Canvas should be solid icons.
  If the variant "icon-Line" is added to an icon's css class,
  it should display as line. For example, in the case of
  <i class="icon-edit"></i>, adding
  <i class="icon-edit icon-Line"></i> would result in a line
  version of the edit icon displaying

- As a developer, you should be able to use InstUI react icons

- The rake task `bundle exec rake icons:compile` should no
  longer exist

- The styleguide should no longer display example icons, but
  should now include a link to the Instructure Icons github
  documentation

Change-Id: I9780332de9fdf937b35caabadc2b2ee615892a43
Reviewed-on: https://gerrit.instructure.com/94175
Reviewed-by: Pam Hiett <phiett@instructure.com>
QA-Review: Dan Sasaki
Tested-by: Jenkins
Product-Review: Kyle Follett <kfollett@instructure.com>
 		2016-11-29 20:52:54 +00:00
..
address_book implementation using address book service 2016-09-06 18:05:21 +00:00
api Add announcements to home page with setting 2016-11-23 17:29:51 +00:00
app_center Send access token when installing app 2016-10-07 16:51:06 +00:00
basic_lti ensure sumbission_type on grade passback 2016-11-03 20:37:42 +00:00
canvas Revert and bring InstIcons into Canvas 2016-11-29 20:52:54 +00:00
cc master courses: just use updated_at for detecting changes 2016-11-28 15:17:02 +00:00
data_fixup remove rails 4.0 support 2016-10-25 17:17:22 +00:00
external_auth_observation fix and test parent registration saml logout 2016-08-18 20:46:54 +00:00
features feature flag for submissions folder 2016-04-28 22:20:27 +00:00
latex add `X-Request-Context-Id` & `-Signature` headers to MathMan requests 2016-09-21 22:21:40 +00:00
lti make lti error constants loadable 2016-11-28 21:20:06 +00:00
messageable_user AddressBook facade 2016-08-15 15:03:56 +00:00
outcomes fix outcome calcs for mix of assignments & quizzes 2016-11-02 17:36:19 +00:00
reporting bump rails 4.2 for security fixes 2016-08-11 23:12:43 +00:00
scribd add a comparator for Scribd::Document 2016-04-01 16:13:39 +00:00
services convert notification service to AWS SDK v2 2016-10-31 17:44:57 +00:00
sis update the updated_at on update_alls in sis importers 2016-11-23 22:18:37 +00:00
stubs remove rails 2 support 2014-08-06 18:16:19 +00:00
support_helpers add crocodoc support week helper endpoint for support 2016-11-22 17:34:02 +00:00
tasks Revert and bring InstIcons into Canvas 2016-11-29 20:52:54 +00:00
turnitin Update submitted_at to what turnitin says it was 2016-10-27 16:20:26 +00:00
user_content fix user content translation of user attachment links 2016-09-02 00:22:50 +00:00
utils fix enrollment term date format to include time 2016-11-17 21:09:17 +00:00
account_services.rb ruby 2.3: fix marshalling problem 2016-10-11 21:28:37 +00:00
action_controller_test_process.rb remove rails 2 support 2014-08-06 18:16:19 +00:00
address_book.rb implementation using address book service 2016-09-06 18:05:21 +00:00
api.rb always rewrite absolute urls in incoming html 2016-11-03 17:38:18 +00:00
api_route_set.rb update grading period permissions 2016-05-20 19:38:18 +00:00
api_routes.rb LTI Reregistration 2015-12-17 23:26:05 +00:00
asset_signature.rb fix Lint/StringConversionInInterpolation issue 2015-04-27 20:53:25 +00:00
assignment_override_applicator.rb don't make a :read_as_admin permission check unless user is admin 2016-11-11 15:04:23 +00:00
authentication_methods.rb a few minor Rails 5 fixes 2016-11-21 17:23:15 +00:00
basic_lti.rb implement lti outbound adapter 2014-03-26 16:49:22 +00:00
brand_config_helpers.rb performance improvements for frequent methods 2016-08-09 19:29:23 +00:00
brand_config_regenerator.rb theme editor for siteadmin 2016-07-12 22:02:04 +00:00
brandable_css.rb remove rails 4.0 support 2016-10-25 17:17:22 +00:00
browser.rb don't autorequire a bunch of gems that are rarely used 2015-04-09 18:47:50 +00:00
canvadocs.rb Include pdfjs in preferred_plugins array 2016-08-03 03:07:50 +00:00
canvas.rb add timeout::error logging to canvas.timeout_protection 2016-11-10 21:00:45 +00:00
canvas_logger.rb spec: include rails logs with spec failure pages 2016-02-20 00:16:30 +00:00
canvas_yaml.rb use strong params, part A 2016-10-14 16:17:26 +00:00
cc.rb rubyzip 1.0.0 upgrade 2013-11-22 19:23:34 +00:00
config_file.rb cleanup refactor of Rubocop's Lint/DeprecatedClassMethods 2015-04-28 18:38:24 +00:00
content_licenses.rb rearrange course license options in drop-downs 2016-10-19 15:09:02 +00:00
content_notices.rb content migration import-in-progress notice 2014-08-20 16:25:15 +00:00
content_zipper.rb make Download Submissions respect anonymous grading 2016-07-27 00:11:42 +00:00
copy_authorized_links.rb no more dynamic finders (lib) 2014-09-23 16:53:56 +00:00
course_link_validator.rb conditional release content migration service 2016-08-02 15:11:13 +00:00
custom_validations.rb allow non-http developer key redirect URIs 2016-08-23 15:27:29 +00:00
cuty_capt.rb cleanup refactor of Rubocop's Lint/DeprecatedClassMethods 2015-04-28 18:38:24 +00:00
dates_overridable.rb improve performance of module assignment tag info loading 2016-10-26 12:46:47 +00:00
delayed_message_scrubber.rb remove messages older than 360 days 2013-11-07 17:19:59 +00:00
delicious.rb don't autorequire a bunch of gems that are rarely used 2015-04-09 18:47:50 +00:00
differentiable_assignment.rb remove differentiated assignments feature checks 2016-03-07 18:44:46 +00:00
due_date_cacher.rb Add "Mastery Paths" AssignmentOverride 2016-10-17 17:07:33 +00:00
email_address_validator.rb SIS Import validates email address 2015-10-13 14:51:50 +00:00
ember_bundle.rb cleanup refactor of Rubocop's Lint/DeprecatedClassMethods 2015-04-28 18:38:24 +00:00
enrollments_from_user_list.rb allow sending user_ids to enroll_users 2016-10-31 19:17:59 +00:00
eportfolio_page.rb don't try to render url for eportfolio category with blank slug 2015-12-08 19:50:19 +00:00
external_feed_aggregator.rb don't process external feeds for deleted contexts 2016-09-16 12:01:34 +00:00
external_statuses.rb deprecate Setting.get_cached 2013-10-10 00:42:52 +00:00
feature.rb Add 'lock to sub-accounts' option under SIS syncing 2016-11-28 20:38:43 +00:00
feature_flags.rb don't bother caching a constant for feature flags 2016-08-02 20:25:43 +00:00
file_in_context.rb handle failed attachments better in UnzipAttachment 2015-10-21 14:54:58 +00:00
file_splitter.rb Initial commit. 2011-01-31 18:57:29 -07:00
grade_calculator.rb Fix grade display with cross shard grading periods 2016-09-30 18:37:00 +00:00
gradebook_exporter.rb fix grading periods api to allow proper delete functionality 2016-08-06 00:29:16 +00:00
gradebook_importer.rb remove confusing method User#admin_of_root_account? 2016-10-26 20:52:02 +00:00
gradebook_settings_helpers.rb allow speedgrader to view concluded courses 2016-09-13 15:27:29 +00:00
gradebook_transformer.rb gradebook csv: show correct totals for mgp 2015-11-16 21:48:56 +00:00
grading_period_helper.rb prevent assignment group movement in closed periods 2016-09-30 19:44:52 +00:00
has_content_tags.rb limit module progression recomputation for adhoc overrides 2016-10-10 15:11:17 +00:00
host_url.rb fix Style/EmptyLineBetweenDefs issue 2015-04-29 16:28:39 +00:00
i18n_time_zone.rb remove rails 4.0 support 2016-10-25 17:17:22 +00:00
imported_html_converter.rb force migration ids to be strings in link converter 2016-06-27 15:17:27 +00:00
kaltura.rb set a .csv file extension when using kaltura bulk api 2013-02-16 08:40:21 -07:00
latex.rb don't try to convert nil or blank values to MathML 2016-10-17 19:21:07 +00:00
learning_outcome_context.rb rails 4 style associations 2015-12-01 20:01:34 +00:00
locale_selection.rb allow tagging custom locales 2016-04-04 15:04:34 +00:00
logging_filter.rb filter params recursively in error reports 2014-02-04 03:33:45 +00:00
login_hooks.rb build login hooks functionality 2015-01-16 14:04:22 +00:00
math_man.rb don't use PluginSetting.cached_plugin_setting outside plugin setting 2016-08-26 20:33:26 +00:00
message_dispatcher.rb don't dispatch cancelled messages, fixes #7397 2012-02-24 12:21:21 -07:00
message_scrubber.rb scrub old unsent messages 2015-12-11 22:36:30 +00:00
messageable_user.rb rails4: various api spec fixes 2015-07-21 15:44:32 +00:00
model_cache.rb remove rails 4.0 support 2016-10-25 17:17:22 +00:00
multi_cache.rb allow fetching all existing values for a MultiCache 2016-09-13 21:41:28 +00:00
mutable.rb fix stream item hiding with submission comments from students 2016-08-04 20:17:25 +00:00
net_ldap_extensions.rb don't autorequire a bunch of gems that are rarely used 2015-04-09 18:47:50 +00:00
notification_message_creator.rb remove daily digests from sms, twitter 2016-08-12 16:30:44 +00:00
open_object.rb Fetch grading periods for all related accounts 2015-03-24 17:41:46 +00:00
permissions.rb allow registering new permissions in plugins 2012-03-02 09:38:06 -07:00
progress_runner.rb add a batch_update method to conversations api 2013-02-14 09:36:36 -07:00
request_cache.rb performance improvements for enrollments and state_based_on_date 2015-07-02 15:51:16 +00:00
request_error.rb outcome gradebook: add export link 2014-03-28 20:37:03 +00:00
rubric_context.rb rails 4 style associations 2015-12-01 20:01:34 +00:00
scope_filter.rb decouple assignments scope permission logic from api index 2015-07-17 17:01:36 +00:00
search_term_helper.rb add search_term to files, modules, and module item apis 2013-08-02 20:12:04 +00:00
send_to_stream.rb get sentry into canvas 2015-04-13 22:26:15 +00:00
sentry_proxy.rb setup a generalized way to leave out errors from sentry reporting 2015-06-23 22:41:26 +00:00
simple_stats.rb quiz item analysis generation, closes CNVS-3421 2013-04-23 15:50:36 +00:00
simple_tags.rb no more dynamic finders (lib) 2014-09-23 16:53:56 +00:00
sis.rb remove unnecessary lib/sis requires 2013-04-02 15:58:29 +00:00
sorts_assignments.rb adds unsubmitted and ungraded filters to assignments api 2016-08-04 16:55:51 +00:00
ssl_common.rb extract multipart gem 2014-02-28 23:00:09 +00:00
stats.rb fix confusing whitespace in lib/stats 2015-08-17 21:52:30 +00:00
sticky_sis_fields.rb use prepend instead of alias_method_chain in SisStickiness 2015-06-16 19:54:30 +00:00
submission_list.rb fix n+1 in submission_list submission version loading 2016-11-18 21:12:50 +00:00
submittable.rb remove rails 4.0 support 2016-10-25 17:17:22 +00:00
submittables_grading_period_protection.rb protect due dates in closed grading periods 2016-11-18 23:50:24 +00:00
summary_message_consolidator.rb rails 4.2: misc spec fixes 2016-01-18 21:45:39 +00:00
syslog_wrapper.rb fix Style/EmptyLineBetweenDefs issue 2015-04-29 16:28:39 +00:00
temp_cache.rb performance improvements for enrollments and state_based_on_date 2015-07-02 15:51:16 +00:00
text_helper.rb remove float rounding monkey-patch 2016-04-22 18:17:18 +00:00
time_zone_helper.rb use modules and super instead of method renaming for time zone attributes 2016-02-09 17:38:07 +00:00
timed_cache.rb clear shard and special account caches based on age 2014-08-26 20:29:55 +00:00
turnitin.rb turnitin assignments are created using the current utc date 2015-11-09 22:07:27 +00:00
turnitin_id.rb make Turnitin::Client#id shard aware 2015-10-07 20:57:02 +00:00
unzip_attachment.rb avoid raw sql updates in several places 2015-06-16 16:14:48 +00:00
user_content.rb enable use of MathMan for latex => mathml conversion 2016-08-05 15:31:23 +00:00
user_list.rb user lists v2 2016-11-15 13:56:03 +00:00
user_list_v2.rb user lists v2 2016-11-15 13:56:03 +00:00
user_merge.rb handle user_services accross shards on user merge 2016-11-01 22:08:05 +00:00
user_search.rb include unconfirmed email addresses in user search 2016-11-28 21:08:06 +00:00
vericite.rb fix double key in vericite sendrequest calls 2016-10-27 20:18:37 +00:00
visibility_plucking_helper.rb Fix grade display with cross shard grading periods 2016-09-30 18:37:00 +00:00
zip_extractor.rb ignore zip entries containing '..' elements or symlinks 2014-07-24 15:41:21 +00:00