ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/lib
History
Nicolas Thomaz Bueno 1019953fd1 change live event not to trigger message without conversation 
fixes EVAL-2815
flag=none

Test plan:
- Create a ConversationMessage without a conversation
- "conversation_message_created" event is not
   created

Change-Id: I6b80df8cb905e327a1338a6e44330ee79580a1b4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/315094
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
 		2023-04-20 19:57:48 +00:00
..
address_book rubocop: Style/MapToHash, Style/MapToSet 2023-04-11 14:41:55 +00:00
api Override hide_points on RubricAssociation when RQD 2023-04-18 21:46:24 +00:00
app_center Remove unnecessary require statements 2023-01-04 21:38:21 +00:00
authentication_methods move inst_access to gem 2021-11-05 19:47:46 +00:00
base rubocop: Style/TernaryParentheses, Style/RedundantParentheses 2023-04-12 14:56:48 +00:00
basic_lti rubocop: prep for updating rubocop-rails 2023-04-14 14:07:22 +00:00
canvadocs Add send_usage_metrics to docviewer launch url 2022-12-16 20:52:53 +00:00
canvas change live event not to trigger message without conversation 2023-04-20 19:57:48 +00:00
cc rubocop: prep for updating rubocop-rails 2023-04-14 14:07:22 +00:00
cdc_migration_testing RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
data_fixup rubocop: prep for updating rubocop-rails 2023-04-14 14:07:22 +00:00
external_auth_observation external auth observation zeitwerk compatibility 2021-10-07 22:35:20 +00:00
feature_flags rubocop: prep for updating rubocop-rails 2023-04-14 14:07:22 +00:00
global_lookups make globalLookups a module to extend, not a stub 2021-10-26 14:58:27 +00:00
gradebook Apply score to ungraded with old and new gb filters 2022-03-11 20:05:29 +00:00
i18n/backend rubocop: fix miscelleneuos violations in prep of bumping rubocop 2023-04-12 19:26:13 +00:00
latex RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
lti bump rubocop-performance 2023-04-12 19:29:39 +00:00
messageable_user bump rubocop-performance 2023-04-12 19:29:39 +00:00
microsoft_sync msft sync: also search for pseudonyms on user shard 2023-04-18 21:03:50 +00:00
migration_helpers RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
outcomes rubocop: prep for updating rubocop-rails 2023-04-14 14:07:22 +00:00
rake RuboCop: Style/SignalException 2021-11-19 22:24:25 +00:00
reporting Remove unnecessary require statements 2023-01-04 21:38:21 +00:00
schemas Add Lti Registration model 2023-03-22 13:41:35 +00:00
sentry_extensions Add "db." prefix for ActiveRecord Sentry traces 2022-03-25 12:44:49 +00:00
services rubocop: prep for updating rubocop-rails 2023-04-14 14:07:22 +00:00
sis rubocop: Layout 2023-04-12 14:57:56 +00:00
support_helpers RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
tasks allow sentry-cli to be installed globally 2023-04-18 13:50:16 +00:00
turnitin rubocop: Style/FileRead, Style/FileWrite 2023-04-10 20:57:32 +00:00
user_content replacement attachments fetched in assignments index api 2022-12-13 19:24:32 +00:00
utils rubocop: Style/TernaryParentheses, Style/RedundantParentheses 2023-04-12 14:56:48 +00:00
account_services.rb Remove Delicious from Canvas 2023-03-22 15:01:28 +00:00
address_book.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
anonymity.rb RuboCop: Style/RedundantSelf 2021-11-20 16:41:21 +00:00
api.rb rubocop: fix miscelleneuos violations in prep of bumping rubocop 2023-04-12 19:26:13 +00:00
api_route_set.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
asset_signature.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
assignment_override_applicator.rb rubocop: Style/SafeNavigation 2023-04-10 20:57:10 +00:00
assignment_util.rb remove unnecessary line continuations 2023-04-12 14:57:18 +00:00
authentication_methods.rb rubocop: Style/TernaryParentheses, Style/RedundantParentheses 2023-04-12 14:56:48 +00:00
basic_lti.rb Kill require_dependency 2023-01-09 19:51:01 +00:00
brand_account_chain_resolver.rb favor active sub-account for branding 2021-12-08 18:15:55 +00:00
brand_config_helpers.rb Don't include parents in chain for regular accounts 2022-04-14 16:56:51 +00:00
brand_config_regenerator.rb rubocop: Style/TernaryParentheses, Style/RedundantParentheses 2023-04-12 14:56:48 +00:00
brandable_css.rb Remove unnecessary require statements 2023-01-04 21:38:21 +00:00
browser_support.rb Allow Chrome OS LTS 2023-02-22 16:57:41 +00:00
canvadocs.rb Kill require_dependency 2023-01-09 19:51:01 +00:00
canvas_logger.rb Remove unnecessary require statements 2023-01-04 21:38:21 +00:00
cc.rb Kill require_dependency 2023-01-09 19:51:01 +00:00
content_licenses.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
content_notices.rb RuboCop: Style/SymbolArray, Style/WordArray 2021-11-23 14:30:08 +00:00
content_zipper.rb rubocop: prep for updating rubocop-rails 2023-04-14 14:07:22 +00:00
conversation_batch_scrubber.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
conversation_helper.rb Data fix up for Conversation/ConversationParticipant 2023-02-17 19:17:24 +00:00
copy_authorized_links.rb RuboCop: Style/IfInsideElse, Style/SoleNestedConditional 2021-11-23 14:28:35 +00:00
course_link_validator.rb rubocop: prep for updating rubocop-rails 2023-04-14 14:07:22 +00:00
course_pace_due_dates_calculator.rb Use calendar event blackout dates in due date calculations 2022-08-10 18:58:39 +00:00
course_pace_hard_end_date_compressor.rb rubocop: Style/TernaryParentheses, Style/RedundantParentheses 2023-04-12 14:56:48 +00:00
course_paces_date_helpers.rb Use calendar event blackout dates in due date calculations 2022-08-10 18:58:39 +00:00
custom_validations.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
cuty_capt.rb rubocop: Lint/NonAtomicFileOperation 2023-04-11 14:48:13 +00:00
dates_overridable.rb Remove points display for ungraded surveys 2022-02-16 16:47:44 +00:00
delayed_message_scrubber.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
differentiable_assignment.rb add granular permissions for managing course content 2022-04-11 20:53:27 +00:00
due_date_cacher.rb rubocop: prep for updating rubocop-rails 2023-04-14 14:07:22 +00:00
dump_helper.rb Remove unnecessary require statements 2023-01-04 21:38:21 +00:00
duplicating_objects.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
effective_due_dates.rb deprioritize section overrides for nonactive enrollments 2022-12-22 18:20:06 +00:00
email_address_validator.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
enrollments_from_user_list.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
eportfolio_page.rb improve recent submission filtering in eportfolios 2023-01-10 22:55:55 +00:00
external_feed_aggregator.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
external_statuses.rb RuboCop: Style/MutableConstant 2021-11-16 16:19:54 +00:00
feature.rb Add "shadow" property to feature flags 2023-02-09 22:03:35 +00:00
feature_flags.rb Add "shadow" property to feature flags 2023-02-09 22:03:35 +00:00
file_authenticator.rb Use SHA256 for cache keys 2023-04-05 17:57:09 +00:00
file_in_context.rb Stop duplicating files on repeat cartridge imports 2022-02-03 15:07:56 +00:00
file_splitter.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
global_lookups.rb make globalLookups a module to extend, not a stub 2021-10-26 14:58:27 +00:00
google_docs_preview.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
grade_calculator.rb updated .coffee-related comments 2023-04-20 17:39:28 +00:00
gradebook_exporter.rb fix gradebook exports for global ids 2022-12-16 21:12:07 +00:00
gradebook_grading_period_assignments.rb fix viewing grades for deactivated students 2022-02-16 17:56:03 +00:00
gradebook_importer.rb bump rubocop-performance 2023-04-12 19:29:39 +00:00
gradebook_settings_helpers.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
gradebook_user_ids.rb rubocop: Style/TernaryParentheses, Style/RedundantParentheses 2023-04-12 14:56:48 +00:00
grading_period_helper.rb RuboCop: Style/RedundantSort 2021-11-19 22:25:07 +00:00
has_content_tags.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
health_checks.rb add jobs cluster tag 2023-01-27 15:09:00 +00:00
host_url.rb Rails 6.1 basic spec functionality 2022-02-16 17:31:11 +00:00
i18n_time_zone.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
imported_html_converter.rb Convert audio and video RCE iframes to HTML tags for import/export 2022-04-18 16:17:53 +00:00
inst_fs.rb Don't use removed aws sdk calls 2023-01-19 16:20:27 +00:00
late_policy_applicator.rb add n_strand to late policy applicator jobs 2023-02-17 21:45:15 +00:00
latex.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
learning_outcome_context.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
locale_selection.rb rubocop: Style/TernaryParentheses, Style/RedundantParentheses 2023-04-12 14:56:48 +00:00
locked_for.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
logging_filter.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
login_hooks.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
math_man.rb Use SHA256 for cache keys 2023-04-05 17:57:09 +00:00
message_dispatcher.rb Improve error logging for message batch dispatching 2022-06-23 15:10:18 +00:00
message_scrubber.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
messageable_user.rb switch to native pg12 collation for ICU sorting 2023-04-12 17:18:46 +00:00
missing_policy_applicator.rb fix apply_missing_deductions syntax for ruby 3.x 2022-12-13 20:52:23 +00:00
model_cache.rb rubocop: Style/TernaryParentheses, Style/RedundantParentheses 2023-04-12 14:56:48 +00:00
moderation.rb add # frozen_string_literal: true for lib 2020-10-27 20:49:50 +00:00
must_view_module_progressor.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
mutable.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
net_ldap_extensions.rb wrap net_ldap_extensions in a zeitwerk compatible module 2021-10-07 18:50:58 +00:00
notification_message_creator.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
package_root.rb Remove unnecessary require statements 2023-01-04 21:38:21 +00:00
permissions.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
permissions_helper.rb Some rails 7 tests passing 2022-06-06 14:23:03 +00:00
plannable.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
planner_api_helper.rb rubocop: Style/TernaryParentheses, Style/RedundantParentheses 2023-04-12 14:56:48 +00:00
planner_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
progress_runner.rb rubocop: Style/TernaryParentheses, Style/RedundantParentheses 2023-04-12 14:56:48 +00:00
pronouns.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
quiz_math_data_fixup.rb stop using deprecated URI.* methods 2022-12-14 15:18:20 +00:00
request_error.rb rubocop: Style/RedundantConstantBase 2023-04-10 20:56:27 +00:00
rubric_context.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
scope_filter.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
score_statistics_generator.rb bump rubocop-performance 2023-04-12 19:29:39 +00:00
scrypt_provider.rb rubocop: Style/RedundantConstantBase 2023-04-10 20:56:27 +00:00
search_term_helper.rb Support basic unicode normalization in search helper 2022-02-16 22:19:10 +00:00
send_to_stream.rb Revert to state before "Add strand for create_stream_items" 2022-06-27 09:09:19 +00:00
sentry_proxy.rb Misc changes to kickstart ruby 3.0 testing 2022-12-13 14:27:41 +00:00
session_token.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
simple_stats.rb rubocop: Style/TernaryParentheses, Style/RedundantParentheses 2023-04-12 14:56:48 +00:00
simple_tags.rb rubocop: Style/TernaryParentheses, Style/RedundantParentheses 2023-04-12 14:56:48 +00:00
sis.rb do away with non-conventional "common" module 2021-10-07 21:55:24 +00:00
sorts_assignments.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
ssl_common.rb Remove unnecessary require statements 2023-01-04 21:38:21 +00:00
stats.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
sticky_sis_fields.rb rubocop: Style/MapToHash, Style/MapToSet 2023-04-11 14:41:55 +00:00
submission_list.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
submission_search.rb rubocop: Style/TernaryParentheses, Style/RedundantParentheses 2023-04-12 14:56:48 +00:00
submittable.rb Consider only relevant discussions when evaluating CMPs 2022-07-14 13:51:37 +00:00
submittables_grading_period_protection.rb RuboCop: Style/MultilineIfModifier 2021-11-23 14:30:24 +00:00
summary_message_consolidator.rb rubocop: prep for updating rubocop-rails 2023-04-14 14:07:22 +00:00
syslog_wrapper.rb Restore `syslog` require 2023-01-04 22:23:35 +00:00
text_helper.rb rubocop: Style/RedundantStringEscape 2023-04-11 14:52:02 +00:00
time_zone_helper.rb RuboCop: Style/HashConversion 2021-11-17 15:17:51 +00:00
timed_cache.rb RuboCop: Style/MethodCallWithoutArgsParentheses 2021-11-18 23:07:30 +00:00
token_scopes.rb hide internal permissions from LTI Advantage Services section 2022-08-29 19:36:02 +00:00
token_scopes_helper.rb Fail a test on route changes used by dev keys 2022-07-12 20:24:05 +00:00
turnitin.rb Kill require_dependency 2023-01-09 19:51:01 +00:00
turnitin_id.rb add # frozen_string_literal: true for lib 2020-10-27 20:49:50 +00:00
unzip_attachment.rb Error when trying to create files/folders in deleted folder 2022-12-02 19:55:13 +00:00
user_content.rb Remove unnecessary require statements 2023-01-04 21:38:21 +00:00
user_list.rb rubocop: Style/TernaryParentheses, Style/RedundantParentheses 2023-04-12 14:56:48 +00:00
user_list_v2.rb fix as_json method signature for ruby 3.x 2022-12-12 20:58:00 +00:00
user_merge.rb rubocop: fix miscelleneuos violations in prep of bumping rubocop 2023-04-12 19:26:13 +00:00
user_search.rb rubocop: Style/TernaryParentheses, Style/RedundantParentheses 2023-04-12 14:56:48 +00:00
uuid_helper.rb RuboCop: Style/MutableConstant 2021-11-16 16:19:54 +00:00
vericite.rb Remove unnecessary require statements 2023-01-04 21:38:21 +00:00
visibility_plucking_helper.rb RuboCop: Style/RedundantSelf 2021-11-20 16:41:21 +00:00
zip_extractor.rb Remove unnecessary require statements 2023-01-04 21:38:21 +00:00