ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/app/views/jst
History
Jon Jensen 6d8bac05b4 i18nliner-handlebars (part I) 
extraction and runtime for vanilla handlebars. ember will be part II
because its strings currently don't even get extracted on master
¯\_(ツ)_/¯

differences in generated yml:
1. `%h{...}` placeholders from hbs are just `%{...}`, since html-safety is
   inferred at runtime without needing a placeholder hint (6 occcurrences)
2. inline `{{t ...}}` calls are now extracted (6 occurrences)
3. some trivial whitespace difference around some wrappers (2 occurrences)
4. html-entities are correctly converted into unicode equivalents, e.g.
   `Move To…` -> `Move To…` (1 occurrence)

test plan:
1. verify string extraction:
   1. `rake js:generate i18n:generate` before and after this commit
   2. confirm `config/locales/generated/en.yml` is identical, except the
      differences listed above
2. verify js translation file generation:
   1. `rake i18n:generate_js` before and after this commit
   2. confirm the files in public/javascripts/translations are identical
3. verify hbs translation keys/scope behavior at runtime:
   1. run canvas w/ RAILS_LOAD_ALL_LOCALES=true and optimized js
   2. use canvas in spanish
   3. confirm that todo está bien
4. confirm you can now use i18nliner-y features:
   1. block helper with no key `{{#t}}hello world{{/t}}`
   2. inline helper with no key `{{t "hello world"}}`

Change-Id: Ic2a2c5cf102ca482919cbb91ac1c154467029685
Reviewed-on: https://gerrit.instructure.com/42942
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
 		2014-10-30 06:25:47 +00:00
..
DiscussionTopics prevent closing upcoming assignment discussions 2014-10-15 20:46:56 +00:00
ExternalFeeds Accessibility: Labeled remove external feed link 2014-07-29 16:37:05 +00:00
ExternalTools fix headers and add scope to the external apps table 2014-08-12 19:29:28 +00:00
accounts Makes quota labels read by screenreaders 2014-09-04 20:10:23 +00:00
announcements Accessibility: Fix and add to heading structure across Canvas 2014-08-14 19:57:43 +00:00
assignments lti2 launches from module items and assignments 2014-10-24 16:30:59 +00:00
calendar calendar: mark completed assignments 2014-10-15 19:27:47 +00:00
collaborations restore border and header styles on the collaborator picker 2013-03-20 19:20:23 +00:00
conferences a11y: Fixed screen reader issues with Kyle menus. 2014-09-18 21:33:17 +00:00
content_migrations don't reuse question banks on import unless specified 2014-09-26 14:08:50 +00:00
contexts refs #8395 expanded page views 2012-11-30 08:34:18 -07:00
conversations submission comments in the inbox 2014-10-24 00:51:36 +00:00
courseList favorite courses customization accessibility 2013-11-22 00:34:28 +00:00
courses fix missing translation error in due dates 2014-10-22 13:11:30 +00:00
dashboard improve accessibility on dashboard Recent Activity 2013-09-04 15:02:00 +00:00
discussions a11y: Fixed screen reader issues with Kyle menus. 2014-09-18 21:33:17 +00:00
feature_flags updating h1 tags for accessibility 2014-09-17 20:59:38 +00:00
grade_summary Make student mastery outcome groups accessible 2014-07-17 18:08:07 +00:00
gradebook2 a11y: Fixed screen reader issues with Kyle menus. 2014-09-18 21:33:17 +00:00
groups/manage allow group leadership edits on group categories 2014-10-10 20:42:06 +00:00
jquery Proposing a fix for big tooltips in modules page footer for previous/next buttons 2014-05-22 11:41:14 +02:00
messages replace all .button(s) with .btn 2012-11-14 13:29:30 -07:00
modules fix Module Progress link 2014-10-10 20:10:14 +00:00
outcomes change outcomes index headings to be sequential from h1 2014-07-28 22:54:22 +00:00
profiles make notification preference buttons always screenreader accessible 2014-10-23 21:43:40 +00:00
quickStartBar fix checkbox and radio button labels 2014-04-18 20:45:02 +00:00
quiz disable ability to regrade a question if they change the question type 2014-04-08 19:28:19 +00:00
quiz_reports Quiz Reports API - Index 2014-04-15 19:22:02 +00:00
quizzes a11y: Fixed screen reader issues with Kyle menus. 2014-09-18 21:33:17 +00:00
registration i18nliner-handlebars (part I) 2014-10-30 06:25:47 +00:00
roles updating h1 tags for accessibility 2014-09-17 20:59:38 +00:00
speed_grader fixed speech to text and true/false check for Chrome 2014-09-29 18:14:03 +00:00
tinymce TinyMCE: Made the Insert Image plugin treeview accessible 2014-01-16 18:59:00 +00:00
tours updating h1 tags for accessibility 2014-09-17 20:59:38 +00:00
util/select add option for completed courses on course import. fixes #2184 2012-03-12 12:06:53 -06:00
widget point subtitle form to amara.org not universalsubtitles.org 2014-08-18 18:49:26 +00:00
wiki a11y: Fixed screen reader issues with Kyle menus. 2014-09-18 21:33:17 +00:00
AssignmentDetailsDialog.handlebars submission count label for assignment details dialog 2014-03-10 20:57:40 +00:00
AssignmentGroupWeightsDialog.handlebars fix header reading for group weights dialog 2014-02-21 17:22:47 +00:00
ComboBox.handlebars ComboBox widget 2012-04-20 12:17:09 -06:00
CommentsView.handlebars replace all .button(s) with .btn 2012-11-14 13:29:30 -07:00
CurveGradesDialog.handlebars clean up $.serializeForm and make it Just Work™, fixes CNVS-7407 2013-08-15 19:48:18 +00:00
DialogFormWrapper.handlebars added DialogFormView 2013-01-17 18:50:37 -07:00
EmptyDialogFormWrapper.handlebars rename generic empty dialog form wrapper 2013-06-27 21:00:12 +00:00
FileBrowserView.handlebars a bunch of newfiles a11y things acannon suggested in audit 2014-09-22 21:55:06 +00:00
FindFlickrImageResult.handlebars a new [image] button in tinyMCE's toolbar 2013-05-06 19:20:14 +00:00
FindFlickrImageView.handlebars a new [image] button in tinyMCE's toolbar 2013-05-06 19:20:14 +00:00
FolderTreeCollection.handlebars paginate folder tree contents in embed-image dialog 2013-07-09 14:58:37 +00:00
FolderTreeItem.handlebars A bunch of style/polish for newfiles 2014-09-17 15:55:35 +00:00
GradeDisplayWarningDialog.handlebars warn teachers when changing grade display 2014-04-23 02:07:44 +00:00
KeyboardNavDialog.handlebars keyboard shortcuts for assignment index page 2013-12-17 21:35:46 +00:00
MoveDialog.handlebars accessible drag and drop 2013-09-25 19:23:51 +00:00
MoveDialogSelect.handlebars accessible drag and drop 2013-09-25 19:23:51 +00:00
PaginatedView.handlebars new discussion topics/announcement index, edit and create 2012-08-17 09:26:04 -06:00
SetDefaultGradeDialog.handlebars gpa scale grading standard 2014-04-10 16:00:28 +00:00
SubmissionDetailsDialog.handlebars gb2 - grade in comments box 2014-05-20 19:21:05 +00:00
UserObservee.handlebars add observees page to user profile 2014-07-09 16:30:20 +00:00
UserObservees.handlebars add observees page to user profile 2014-07-09 16:30:20 +00:00
_avatar.handlebars round avatars everywhere (almost) 2014-02-13 18:00:45 +00:00
_grading_box.handlebars gb2 - grade in comments box 2014-05-20 19:21:05 +00:00
_messageStudentsWhoRecipientList.handlebars refactor + fix message students who dialog for quiz show 2013-04-02 06:15:25 +00:00
_submission_detail.handlebars added tests for submission details partial 2014-08-07 16:37:16 +00:00
_turnitinInfo.handlebars replace all .button(s) with .btn 2012-11-14 13:29:30 -07:00
_turnitinScore.handlebars allow teachers to resubmit to turnitin; closes #7981 2012-04-24 16:49:42 -06:00
_vddTooltip.handlebars quiz index page redesign for draft state 2013-07-18 22:33:20 +00:00
changePointsPossibleToMatchRubricDialog.handlebars fix wording on "Change pts to match rubric?" dialog 2012-02-27 12:41:00 -07:00
collectionView.handlebars clean up conferences js 2014-01-10 20:00:54 +00:00
developer_key.handlebars Misc remaining icon replacement 2012-12-05 15:43:19 -07:00
developer_key_form.handlebars replace all .button(s) with .btn 2012-11-14 13:29:30 -07:00
googleDocsTreeView.handlebars only filter google docs list by extension if extensions are given 2013-03-05 12:00:19 -07:00
gradebook_uploads_form.handlebars DA - gb csv modal 2014-09-18 15:49:19 +00:00
helpDialog.handlebars Accessibility: Fixed small issue with managing focus in the help dialog 2014-01-23 01:10:31 +00:00
messageStudentsDialog.handlebars fixes message students link not sending message to self sign-up groups 2013-05-31 16:50:39 +00:00
mute_dialog.handlebars set focus for assignment muter dialogs 2014-02-07 03:57:00 +00:00
paginatedCollection.handlebars Add new content migration UI 2013-05-18 04:58:35 +00:00
re_upload_submissions_form.handlebars replace all .button(s) with .btn 2012-11-14 13:29:30 -07:00
recentStudent.handlebars link to course users page on course statistics students tab 2013-02-11 16:39:44 -07:00
searchView.handlebars fixes bug in PaginatedCollectionView 2013-03-12 11:08:14 -06:00