* avoid purposely raising and rescuing ActiveRecord::RecordNotFound for simple
control flow that you expect it to not be found often
* don't name a class Interface when it's not an interface (it's just an
abstract base class)
* don't use a Factory class when it's really just a class method on said
base class
Change-Id: I56e25c977f5dbe68ab527536bad4d75cd84291d7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/333956
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
3d580338da