canvas-lms/app/controllers
James Williams a1182ffe9b fix nickname ordering in global nav and "all courses" lists
- make the global nav list sort by nicknames (since that's
all we're showing)
- make the "All courses" list sort by normal name (since
 that's what we're showing on the left-side column)

test plan:
* enroll a user in two courses
* create a nickname for one of the courses that switches
 their current alphabetical ordering
* the global nav courses list should make sense
* the "All Courses" page (/courses) ordering should make sense too

closes #LS-1435

Change-Id: I6dcbbfa4503c53534c96ed580ac7893ce72bcb5a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/248076
QA-Review: Robin Kuss <rkuss@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
2020-09-23 22:11:05 +00:00
..
bookmarks rails 6: s/update_attributes/update/g 2020-01-09 20:56:35 +00:00
conditional_release retrieve conditional release rule information natively 2020-06-25 22:28:35 +00:00
filters stop logging quiz submission api 404 to sentry 2018-03-12 21:04:07 +00:00
live_assessments Use default ratings and points 2018-07-05 21:04:54 +00:00
login More recaptcha cleanup 2020-09-17 20:28:04 +00:00
lti remove uses of whitelist and blacklist 2020-09-18 15:58:40 +00:00
master_courses improve blueprint associations performance for many teachers 2020-03-30 21:47:21 +00:00
polling rails 6: s/update_attributes/update/g 2020-01-09 20:56:35 +00:00
quizzes prevent updating quiz scores for unassigned students 2020-09-18 16:24:38 +00:00
quizzes_next cache link header for all_quizzes end point 2020-04-21 21:05:40 +00:00
submissions remove uses of whitelist and blacklist 2020-09-18 15:58:40 +00:00
support_helpers add sis_source_id to Assignments 2019-08-08 23:02:51 +00:00
account_notifications_controller.rb Add paging to past global announcements 2020-06-04 16:15:01 +00:00
account_reports_controller.rb Fix Account Report API pagination 2019-08-15 21:39:00 +00:00
accounts_controller.rb Add self_registration_type to terms of service api 2020-09-10 15:59:23 +00:00
admins_controller.rb split built-in role rows by root account 2020-09-01 19:21:27 +00:00
alerts_controller.rb rails 6: s/update_attributes/update/g 2020-01-09 20:56:35 +00:00
announcements_api_controller.rb fix links in modules api documentation 2019-04-05 18:38:28 +00:00
announcements_controller.rb Remove all content_for :auto_discovery’s 2019-07-25 20:20:12 +00:00
anonymous_provisional_grades_controller.rb Remove beta label from feature options 2019-03-14 01:35:25 +00:00
anonymous_submissions_controller.rb Use anonymous URLs for anonymous peer reviews 2019-03-18 16:26:11 +00:00
app_center_controller.rb use calling context app center token if set 2018-07-23 16:33:04 +00:00
application_controller.rb More recaptcha cleanup 2020-09-17 20:28:04 +00:00
appointment_groups_controller.rb create appointment groups in context shard 2020-09-02 19:33:21 +00:00
assessment_questions_controller.rb rails 6: s/update_attributes/update/g 2020-01-09 20:56:35 +00:00
assignment_extensions_controller.rb add sis_source_id to Assignments 2019-08-08 23:02:51 +00:00
assignment_groups_api_controller.rb Add score statistics to the assignments API as an 'include' option 2020-08-19 15:10:03 +00:00
assignment_groups_controller.rb Add score statistics to the assignments API as an 'include' option 2020-08-19 15:10:03 +00:00
assignment_overrides_controller.rb Fix return type documentation bug for AssignmentOverride.all_day. 2019-12-03 00:08:28 +00:00
assignments_api_controller.rb Add can_submit value to assignments_api 2020-09-01 16:28:01 +00:00
assignments_controller.rb assignment page: upload submissions without timing out 2020-08-28 21:03:21 +00:00
auditor_api_controller.rb Check auditor config by backend 2020-07-06 18:16:25 +00:00
authentication_audit_api_controller.rb api: document storage time of authentication logs 2017-10-02 20:59:35 +00:00
authentication_providers_controller.rb Support recaptcha by default for new user registration 2020-06-11 15:01:01 +00:00
brand_configs_api_controller.rb Fix link & brand-primary color HC & ie11 2017-11-02 17:36:22 +00:00
brand_configs_controller.rb Remove theme editor refactor feature flag 2018-03-20 20:07:26 +00:00
calendar_events_api_controller.rb remove better_scheduler feature flag 2020-07-02 15:54:59 +00:00
calendar_events_controller.rb timetable section specific cal event now editable 2020-07-23 22:29:51 +00:00
calendars_controller.rb add ui for adding conference from calendar entry 2020-04-30 18:06:01 +00:00
canvadoc_sessions_controller.rb show peer review annotations even when unposted 2020-07-28 19:37:04 +00:00
collaborations_controller.rb Hide '+ Collaboration' button when user doesn't have permission 2020-06-18 14:42:16 +00:00
comm_messages_api_controller.rb Comm messages api docs show time limitations 2020-05-08 20:53:26 +00:00
communication_channels_controller.rb pass through delegated auth redirect _after_ login, not before 2020-09-15 21:50:45 +00:00
conferences_controller.rb Revert "Restore BBB free conference banner but change copy" fixes VICE-818 2020-09-23 17:16:44 +00:00
content_exports_api_controller.rb align quiz migration behaviors with quiz duplication 2019-10-22 22:18:35 +00:00
content_exports_controller.rb rails 5.1: all the rest of the specs 2017-07-31 19:48:51 +00:00
content_imports_controller.rb split content migration job stranding by type 2019-08-09 17:16:18 +00:00
content_migrations_controller.rb fix cross-shard content shares 2020-08-20 17:07:08 +00:00
content_shares_controller.rb fix cross-shard content shares 2020-08-20 17:07:08 +00:00
context_controller.rb Get the media player iframe rendering in canvas iframes 2020-07-31 14:33:37 +00:00
context_module_items_api_controller.rb rip out conditional_release service 2020-07-28 18:04:55 +00:00
context_modules_api_controller.rb rails 6: s/update_attributes/update/g 2020-01-09 20:56:35 +00:00
context_modules_controller.rb Add expand/collapse all button to modules index 2020-07-30 15:36:22 +00:00
conversations_controller.rb show _all_ starred conversations 2020-05-15 18:48:15 +00:00
course_audit_api_controller.rb New API endpoint for Course Audit Log Account 2020-03-25 20:40:57 +00:00
course_nicknames_controller.rb move unbounded user preference data to separate table 2020-03-02 20:10:32 +00:00
courses_controller.rb fix nickname ordering in global nav and "all courses" lists 2020-09-23 22:11:05 +00:00
crocodoc_sessions_controller.rb remove uses of whitelist and blacklist 2020-09-18 15:58:40 +00:00
csp_settings_controller.rb update UI references of CSP whitelist 2020-06-16 16:28:51 +00:00
custom_data_controller.rb fix race conditions in custom data setting 2019-08-09 15:28:36 +00:00
custom_gradebook_column_data_api_controller.rb Add API for bulk uploading custom columns 2018-08-09 22:04:07 +00:00
custom_gradebook_columns_api_controller.rb add read_only to custom_gradebook_columns 2018-02-26 19:59:46 +00:00
developer_key_account_bindings_controller.rb Fix some JSON in API docs. 2019-11-19 16:04:58 +00:00
developer_keys_controller.rb extend client_credentials oauth2 grants for CD2 2020-08-13 18:52:47 +00:00
disable_post_to_sis_api_controller.rb allow batch-disable post-to-SIS when new-sis-integrations disabled 2018-03-15 18:58:51 +00:00
discussion_entries_controller.rb rails 6: s/update_attributes/update/g 2020-01-09 20:56:35 +00:00
discussion_topics_api_controller.rb log asset accesses for API calls 2019-09-06 19:39:25 +00:00
discussion_topics_controller.rb handle empty users for discussion topics 2020-09-18 19:50:37 +00:00
docviewer_audit_events_controller.rb save context and annotation id on docviewer events 2018-09-24 19:26:33 +00:00
enrollments_api_controller.rb split built-in role rows by root account 2020-09-01 19:21:27 +00:00
eportfolio_categories_controller.rb rails 6: s/update_attributes/update/g 2020-01-09 20:56:35 +00:00
eportfolio_entries_controller.rb rails 6: s/update_attributes/update/g 2020-01-09 20:56:35 +00:00
eportfolios_controller.rb remove eportfolio moderation release flag 2020-07-16 16:28:48 +00:00
epub_exports_controller.rb api: epub / web exports are not really beta 2018-02-22 22:35:22 +00:00
equation_images_controller.rb better uri handling on equation image redirection 2017-08-24 22:47:55 +00:00
errors_controller.rb fix n+1 query in error reports 2018-09-14 23:37:04 +00:00
external_content_controller.rb Require signed token for oembed embedding 2020-08-05 20:44:54 +00:00
external_feeds_controller.rb Add the word 'paginated' to relevant API documentation. 2017-09-27 17:27:41 +00:00
external_tools_controller.rb Fix com.instructure.Assignment.lti.id bug 2020-08-27 17:07:53 +00:00
favorites_controller.rb fix nickname ordering in global nav and "all courses" lists 2020-09-23 22:11:05 +00:00
feature_flags_controller.rb Hide inherited enabled FFs 2020-08-07 21:10:13 +00:00
file_previews_controller.rb Fix streaming bug on media_preview page 2019-11-12 19:20:53 +00:00
files_controller.rb allow lock image replacement for both download & preview img links 2020-08-03 21:02:04 +00:00
folders_controller.rb rails 6: s/update_attributes/update/g 2020-01-09 20:56:35 +00:00
grade_change_audit_api_controller.rb Add API endpoints for override grades 2020-09-14 19:09:10 +00:00
gradebook_csvs_controller.rb add slash to chars to sanitize in gradebook export filename 2018-04-17 22:28:22 +00:00
gradebook_history_api_controller.rb add sis_source_id to Assignments 2019-08-08 23:02:51 +00:00
gradebook_settings_controller.rb move unbounded user preference data to separate table 2020-03-02 20:10:32 +00:00
gradebook_uploads_controller.rb Add custom columns to gradebook imports 2018-08-24 21:15:03 +00:00
gradebooks_controller.rb Add override grade filter to GB history 2020-09-22 14:42:26 +00:00
grading_period_sets_controller.rb strand grading period set update term computation 2018-10-23 11:25:25 +00:00
grading_periods_controller.rb rails 6: s/update_attributes/update/g 2020-01-09 20:56:35 +00:00
grading_standards_api_controller.rb Add the word 'paginated' to relevant API documentation. 2017-09-27 17:27:41 +00:00
grading_standards_controller.rb rails 6: s/update_attributes/update/g 2020-01-09 20:56:35 +00:00
graphql_controller.rb Only allow authenticated users to GraphQL 2020-09-10 16:03:50 +00:00
group_categories_controller.rb fix n+1 in group_category api 2020-01-16 17:43:36 +00:00
group_memberships_controller.rb rails 6: s/update_attributes/update/g 2020-01-09 20:56:35 +00:00
groups_controller.rb fix group assignment external tool files submission 2020-01-14 13:31:31 +00:00
history_controller.rb Add SR label to recent history icons 2020-08-27 18:16:37 +00:00
immersive_reader_controller.rb Add authentication for immersive reader 2019-09-19 16:04:03 +00:00
info_controller.rb return correct default icon path in web-app-manifest 2020-07-29 19:36:40 +00:00
internet_image_controller.rb Set Unsplash content_filter param to high 2020-09-14 16:47:11 +00:00
jobs_controller.rb add set_active_tab method in preparation for streaming 2019-07-30 12:22:15 +00:00
jwts_controller.rb Fix some JSON in API docs. 2019-11-19 16:04:58 +00:00
late_policy_controller.rb allow users with view_all_grades to save gradebook preferences 2019-07-11 18:59:32 +00:00
legal_information_controller.rb da licença part 5 2017-04-27 21:30:43 +00:00
login_controller.rb rename AccountAuthorizationConfig* to AuthenticationProvider* 2018-04-26 16:03:47 +00:00
lti_api_controller.rb chore(LTI): Error for LTI Grades with Non-Parseable Score 2019-10-24 15:09:36 +00:00
media_objects_controller.rb Add group files to the rce 2020-09-22 15:29:42 +00:00
media_tracks_controller.rb Wire CC UI to the API 2020-05-07 18:16:21 +00:00
messages_controller.rb add messages show 2020-05-04 20:09:10 +00:00
migration_issues_controller.rb da licença part 5 2017-04-27 21:30:43 +00:00
moderation_set_controller.rb add sis_source_id to Assignments 2019-08-08 23:02:51 +00:00
notification_preferences_controller.rb documentation typo 2020-02-10 17:25:30 +00:00
oauth2_provider_controller.rb extend client_credentials oauth2 grants for CD2 2020-08-13 18:52:47 +00:00
oauth_proxy_controller.rb da licença part 5 2017-04-27 21:30:43 +00:00
observer_alert_thresholds_api_controller.rb Add missing observer alert json fields 2018-06-25 20:59:15 +00:00
observer_alerts_api_controller.rb fix a couple of n+1 in observer alert api 2020-07-02 21:00:59 +00:00
observer_pairing_codes_api_controller.rb document creating pairing code 2020-04-16 18:24:48 +00:00
one_time_passwords_controller.rb add streaming templates: part 1 2019-07-31 19:23:44 +00:00
outcome_groups_api_controller.rb Improve message when deleting a group containing alignments 2020-08-14 18:52:18 +00:00
outcome_groups_controller.rb da licença part 5 2017-04-27 21:30:43 +00:00
outcome_imports_api_controller.rb Avoid Yard warning messages 2018-11-19 21:27:50 +00:00
outcome_proficiency_api_controller.rb GraphQL for outcome proficiencies 2020-08-14 23:22:01 +00:00
outcome_results_controller.rb apply current proficiency calculation 2020-08-19 14:07:54 +00:00
outcomes_academic_benchmark_import_api_controller.rb rename outcomes import controller to disambiguate 2020-07-24 15:18:43 +00:00
outcomes_api_controller.rb rails 6: s/update_attributes/update/g 2020-01-09 20:56:35 +00:00
outcomes_controller.rb Display roles that can edit proficencies 2020-09-17 23:11:37 +00:00
page_comments_controller.rb only find active eportfolios 2018-07-23 20:40:55 +00:00
page_views_controller.rb filter page views by accessible accounts 2017-11-08 18:22:38 +00:00
peer_reviews_api_controller.rb add sis_source_id to Assignments 2019-08-08 23:02:51 +00:00
planner_controller.rb Remove student planner feature flag 2020-07-23 18:59:09 +00:00
planner_notes_controller.rb Remove student planner feature flag 2020-07-23 18:59:09 +00:00
planner_overrides_controller.rb Remove student planner feature flag 2020-07-23 18:59:09 +00:00
plugins_controller.rb add set_active_tab method in preparation for streaming 2019-07-30 12:22:15 +00:00
profile_controller.rb update breadcrumb for notification_update_account_ui 2020-08-06 18:49:19 +00:00
progress_controller.rb include progress results in progress_json 2018-03-09 23:12:53 +00:00
provisional_grades_base_controller.rb anonymize status endpoint 2018-08-27 17:46:21 +00:00
provisional_grades_controller.rb use cache_register to clear todo list cache for admins 2019-05-20 16:41:57 +00:00
pseudonym_sessions_controller.rb da licença part 5 2017-04-27 21:30:43 +00:00
pseudonyms_controller.rb search trusted accounts for forgotten passwords as well 2020-08-11 19:22:02 +00:00
question_banks_controller.rb remove criteria from outcomes view/edit when mastery scales enabled 2020-08-19 17:50:27 +00:00
role_overrides_controller.rb Add outcome proficiency permissions 2020-09-15 21:54:11 +00:00
rubric_assessments_controller.rb Expose Rubric Assessment API endpoints CUD 2019-03-05 17:34:42 +00:00
rubric_associations_controller.rb Add additional descriptions for rubric params 2019-09-17 14:32:40 +00:00
rubrics_api_controller.rb Add additional descriptions for rubric params 2019-09-17 14:32:40 +00:00
rubrics_controller.rb remove criteria from outcomes view/edit when mastery scales enabled 2020-08-19 17:50:27 +00:00
scopes_api_controller.rb Remove DeveloperKey Management and Scoping FF 2018-10-26 15:16:36 +00:00
search_controller.rb Revert "fix conversations permissions bug" 2020-02-11 19:57:26 +00:00
sections_controller.rb rails 6: s/update_attributes/update/g 2020-01-09 20:56:35 +00:00
self_enrollments_controller.rb More recaptcha cleanup 2020-09-17 20:28:04 +00:00
services_api_controller.rb update kaltura session to return config 2019-05-20 15:33:54 +00:00
shared_brand_configs_controller.rb api: brand configs is not really beta 2018-02-22 22:35:31 +00:00
sis_api_controller.rb api: sis assignments is not really beta 2018-02-22 22:36:35 +00:00
sis_import_errors_api_controller.rb allow filtering sis import errors to just failures 2018-11-07 15:41:53 +00:00
sis_imports_api_controller.rb add sis batch setting to disable diffing on high diff row count 2019-04-16 12:31:50 +00:00
sub_accounts_controller.rb rails 6: s/update_attributes/update/g 2020-01-09 20:56:35 +00:00
submission_comments_api_controller.rb Add api endpoints for submission comment edit and delete 2020-09-14 17:09:23 +00:00
submission_comments_controller.rb allow comments download in soft concluded courses 2019-02-25 14:50:02 +00:00
submissions_api_controller.rb remove allow_postable_submission_comments flag 2020-08-31 16:39:08 +00:00
submissions_base_controller.rb withhold submission score data from student while muted 2020-01-17 21:02:35 +00:00
submissions_controller.rb remove uses of whitelist and blacklist 2020-09-18 15:58:40 +00:00
tabs_controller.rb remove broken include[]=external argument for list tabs 2019-09-11 19:56:26 +00:00
terms_api_controller.rb update docs to be correct 2019-10-02 13:29:32 +00:00
terms_controller.rb rails 6: s/update_attributes/update/g 2020-01-09 20:56:35 +00:00
tokens_controller.rb rails 6: s/update_attributes/update/g 2020-01-09 20:56:35 +00:00
usage_rights_controller.rb Add the word 'paginated' to relevant API documentation. 2017-09-27 17:27:41 +00:00
user_lists_controller.rb da licença part 7 2017-04-27 21:31:05 +00:00
user_notes_controller.rb Populate root_account_id on user_note paths 2020-06-18 20:35:04 +00:00
user_observees_controller.rb use method to find pairing code 2020-08-26 16:31:55 +00:00
user_trophies_controller.rb add alternative trophy view 2020-06-26 22:44:27 +00:00
users_controller.rb Exempt parent registration from recaptcha 2020-09-22 18:25:50 +00:00
web_zip_exports_controller.rb Fix some JSON in API docs. 2019-11-19 16:04:58 +00:00
wiki_pages_api_controller.rb use primary to search for wiki pages on api update 2020-09-03 13:45:58 +00:00
wiki_pages_controller.rb Remove Granular Permissions Wiki Pages FF 2020-09-10 04:43:12 +00:00