ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/public/javascripts
History
Jeremy Neander 7337718d04 render comments with attachments in SpeedGrader 
There is a bug in SpeedGrader where comments with attachments do
not render, due to an error being thrown during the render. This
fixes the issue.

fixes CNVS-34486

test plan:
 1. Visit SpeedGrader
 2. Create a comment with an attachment
 3. Verify the comment renders properly
 4. Verify no errors appear in the console
 5. Refresh the page
 6. Verify the comment renders properly
 7. Verify no errors appear in the console

Change-Id: Ibddc432f4b5edd4910879c6ce0303380abb826db
Reviewed-on: https://gerrit.instructure.com/100282
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Jenkins
QA-Review: Gentry Beckmann <gbeckmann@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
 		2017-01-28 17:13:36 +00:00
..
bower use node_modules wherever possible 2016-11-01 15:14:52 +00:00
custom_moment_locales add Haitian 2017-01-27 23:53:17 +00:00
eportfolios Keep eportfolio content on rce save 2016-05-05 15:58:32 +00:00
mediaelement Add source chooser to media player 2014-08-14 21:04:55 +00:00
quizzes don’t try to load quiz web worker from a different origin 2017-01-24 00:51:32 +00:00
str Remove unreachable code after return in stripTags 2016-03-19 01:22:22 +00:00
tinymce_plugins Fix LTI launch modals don't contain focus. 2017-01-09 17:47:21 +00:00
translations fix locale fallbacks in JS land, fixes CNVS-29506, refs SD-71 2016-05-20 20:56:19 +00:00
vendor add Haitian 2017-01-27 23:53:17 +00:00
.eslintrc.js [eslint] add eslint-plugin-promise 2017-01-04 18:21:04 +00:00
.i18nignore use node_modules wherever possible 2016-11-01 15:14:52 +00:00
.xssignore Add enzyme testing to Canvas 2017-01-04 20:21:36 +00:00
Backbone.js use node_modules wherever possible 2016-11-01 15:14:52 +00:00
INST.js remove old ie 6-9 detection (since we don't support them anymore) 2016-03-01 23:07:35 +00:00
LtiThumbnailLauncher.js add the allowfullscreen to contentitem 2015-12-11 18:47:02 +00:00
account_add_course.js Bug fix for pressing enter key on add course form 2014-09-29 16:11:33 +00:00
account_add_user.js add error message for duplicate SIS ID 2015-06-25 15:49:30 +00:00
account_authorization_configs.js Replace react-select-box with InstUI Select 2017-01-25 17:20:54 +00:00
account_settings.js focus on admin type for new admin form 2017-01-16 21:42:14 +00:00
account_statistics.js don't call jquery UI methods an elements with no widget initialized 2012-08-13 10:16:54 -06:00
ajax_errors.js don't swallow JS errors in production. 2016-04-01 22:39:44 +00:00
alerts.js fix alerts XSS vulnerability, fixes CNVS-17661 2014-12-29 17:26:24 +00:00
attendance.js remove dead code 2015-06-17 17:52:41 +00:00
authentication_providers.js fix auth selector for AACs 2015-06-16 15:49:24 +00:00
axios.js Make axios request stringified ids 2016-11-23 16:08:38 +00:00
calcCmd.js fix d2l formula question importing 2016-10-13 19:01:25 +00:00
calendar_move.js make syllabus minical accessible 2016-07-25 20:57:45 +00:00
collaborations.js fix old collaboration lti edit 2016-07-08 15:50:01 +00:00
communication_channels.js Fix entry of international phone numbers 2016-01-11 19:00:37 +00:00
content_exports.js XSS linting, fixes CNVS-17663 2014-12-29 17:45:43 +00:00
content_imports.js XSS linting, fixes CNVS-17663 2014-12-29 17:45:43 +00:00
content_locks.js use standard lock message/prerequisite lookup for wiki pages 2015-04-30 18:35:03 +00:00
content_tags_index.js upgrade jquery to 1.7.2 2012-04-24 10:57:38 -06:00
context_modules.js master courses: add icons for restricted items on modules page 2017-01-23 17:27:16 +00:00
context_modules_helper.js make modules external link click consistent 2016-11-09 22:37:15 +00:00
convert_case.js allows user to add and update grading periods 2015-03-24 17:30:48 +00:00
course.js Fix Files breadcrumbs in New Styles 2015-06-05 20:45:36 +00:00
course_settings.js Add announcements to home page with setting 2016-11-23 17:29:51 +00:00
course_settings_helper.js fix lti2 navigation tab editing 2016-09-09 20:47:21 +00:00
datagrid.js remove the js server error reporting 2015-03-25 22:44:11 +00:00
datejs_to_iso_string_patch.js AMD Conversion 2012-02-06 16:41:40 -07:00
decode_string.js decode sidebar mce links 2015-08-26 21:23:17 +00:00
dummyI18nResource.js use web pack 2015-11-02 16:27:14 +00:00
edit_rubric.js add screenreader notification to confirm rating creation 2016-06-28 19:41:38 +00:00
ember.js Webpack: better handling of chunks and cdn stuff 2017-01-03 22:50:31 +00:00
enzyme_requireJS.js Add enzyme testing to Canvas 2017-01-04 20:21:36 +00:00
eportfolio.js eportfolios a11y for reorder pages/sections 2016-12-08 21:40:38 +00:00
file_inline.js require -> define in public/javascripts 2012-03-05 14:19:50 -07:00
find_outcome.js Rubrics - Change "Find Outcome Criterion" to "Find Outcome" 2014-11-11 03:20:54 +00:00
global_announcements.js remove EditorConfig hack for account announcements 2017-01-14 21:03:10 +00:00
grade_summary.js add i18n number support to gradebook assignment table 2017-01-23 21:54:46 +00:00
gradebook-history.js grading history needs to display/accept i18n #s & dates/times 2017-01-24 23:16:32 +00:00
gradebook_uploads.js gradebook upload respects close date 2016-09-20 16:10:04 +00:00
grading_standards.js fix grading standard creation 2015-12-18 23:01:06 +00:00
i18n.js only require translations/_core in optimized js 2014-12-23 17:49:37 +00:00
i18nObj.js add I18n.n method for formating numbers locale 2016-12-15 19:57:31 +00:00
instructure-icons Revert and bring InstIcons into Canvas 2016-11-29 20:52:54 +00:00
instructure.js Webpack: better handling of chunks and cdn stuff 2017-01-03 22:50:31 +00:00
instructure_helper.js Close ExternalToolModalLauncher when iframe posts a message 2017-01-05 18:19:57 +00:00
jquery.ajaxJSON.js send interaction_seconds updates in response headers 2015-11-18 03:20:51 +00:00
jquery.disableWhileLoading.js use node_modules wherever possible 2016-11-01 15:14:52 +00:00
jquery.doc_previews.js Google Drive speed grader previews 2015-03-31 21:51:32 +00:00
jquery.dropdownList.js Fix a11y with the ignore feature of the To Do list 2015-03-23 20:43:31 +00:00
jquery.fancyplaceholder.js AMD Conversion 2012-02-06 16:41:40 -07:00
jquery.google-analytics.js fix google analytics for multiple events 2013-01-24 15:41:47 -07:00
jquery.inst_tree.js XSS linting, fixes CNVS-17663 2014-12-29 17:45:43 +00:00
jquery.instructure_date_and_time.js fix enrollment term date format to include time 2016-11-17 21:09:17 +00:00
jquery.instructure_forms.js fix modules page form control labels 2016-09-22 21:44:11 +00:00
jquery.instructure_jquery_patches.js QuizLogAuditing - JS core 2014-11-11 22:25:02 +00:00
jquery.instructure_misc_helpers.js remove scrollSidebar since it only affected oldUI 2016-09-07 18:06:16 +00:00
jquery.instructure_misc_plugins.js Remove #wrapper-container from Canvas 2016-10-27 13:37:08 +00:00
jquery.js upgrade jquery to 1.7.2 2012-04-24 10:57:38 -06:00
jquery.keycodes.js AMD Conversion 2012-02-06 16:41:40 -07:00
jquery.loadingImg.js insert show rubric link into ember quiz show menu 2014-06-09 22:18:25 +00:00
jquery.scrollToVisible.js don't double-scroll in scrollToVisible 2015-05-12 21:18:14 +00:00
jquery.templateData.js XSS linting, fixes CNVS-17663 2014-12-29 17:45:43 +00:00
jquery.toJSON.js fix issues with common cartridge module importing 2016-03-28 19:46:10 +00:00
jquery.ui.menu.inputmenu.js XSS linting, fixes CNVS-17663 2014-12-29 17:45:43 +00:00
ldap_settings_test.js use double-cookie csrf protection 2014-09-23 15:29:03 +00:00
link_enrollment.js don't call jquery UI methods an elements with no widget initialized 2012-08-13 10:16:54 -06:00
login.js manage focus switching between login and forgot password 2016-05-18 05:42:01 +00:00
manage_avatars.js require -> define in public/javascripts 2012-03-05 14:19:50 -07:00
mathquill.js a `/` is just a `/` 2016-11-29 16:16:41 +00:00
media_comments.js Revert "delay loading swfobject until it’s actually needed" 2016-11-22 16:23:29 +00:00
message_students.js add i18n number support to srgb assignment information 2017-01-24 22:11:39 +00:00
moderate_quiz.js focus on the close button when dialog opens 2016-06-28 23:18:14 +00:00
moment_formats.js localize values in datetime picker fields 2015-08-14 20:25:02 +00:00
moment_requireJS.js add Haitian 2017-01-27 23:53:17 +00:00
oauth2_confirm.js double submit protection for oauth access 2015-06-11 17:25:11 +00:00
old_unsupported_dont_use_react-router-webpack.js build quiz log auditing w/ web pack 2016-01-14 00:33:38 +00:00
page_views.js send interaction_seconds updates in response headers 2015-11-18 03:20:51 +00:00
parse-decimal-number_requireJS.js add js helper to parse number string for locale 2016-12-13 22:42:18 +00:00
plugins.js require -> define in public/javascripts 2012-03-05 14:19:50 -07:00
prerequisites_lookup.js replace straggler background image icons with updated icons 2016-12-27 21:30:05 +00:00
profile.js remove loading spinner from profile page 2016-09-22 21:55:25 +00:00
question_bank.js replace background image icon for bookmarked banks button 2017-01-04 16:51:13 +00:00
question_banks.js set correct focus for tab and return on question bank add 2016-02-04 16:44:31 +00:00
quiz_arrows.js clean up RCE abstraction layer and service sidebar 2016-03-30 18:03:24 +00:00
quiz_formula_solution.js fix quiz formula solutions to accept 0s for solutions 2014-11-24 18:20:32 +00:00
quiz_history.js keep current question number in scroll view 2016-06-23 16:33:38 +00:00
quiz_inputs.js XSS linting, fixes CNVS-17663 2014-12-29 17:45:43 +00:00
quiz_labels.js spec: fix jslint complaint 2016-07-01 19:49:50 +00:00
quiz_rubric.js fix a rogue require statement to work with web pack 2015-12-21 23:25:13 +00:00
quiz_show.js add mastery paths info to discussions and quizzes show 2016-10-06 18:51:22 +00:00
quiz_statistics_cqs.js use web pack 2015-11-02 16:27:14 +00:00
quiz_timing.js i18nliner-js (part I) 2014-10-30 06:25:36 +00:00
quizzes.js correct mastery paths tab availability 2016-10-30 04:46:58 +00:00
react-addons-css-transition-group_requireJS.js use node_modules wherever possible 2016-11-01 15:14:52 +00:00
react-addons-pure-render-mixin_requireJS.js use node_modules wherever possible 2016-11-01 15:14:52 +00:00
react-addons-test-utils_requireJS.js use node_modules wherever possible 2016-11-01 15:14:52 +00:00
react-addons-update_requireJS.js use node_modules wherever possible 2016-11-01 15:14:52 +00:00
react-dnd-test-backend.js Make dashcards reorder on drag and drop 2016-11-18 01:07:15 +00:00
react-modal.js use node_modules wherever possible 2016-11-01 15:14:52 +00:00
reminders.js include patch when you require 'jqueryui/draggable' 2012-04-24 16:11:51 -06:00
rubricEditBinding.js fix a rogue require statement to work with web pack 2015-12-21 23:25:13 +00:00
rubric_assessment.js make speedgrader accept and display i18n numbers 2017-01-24 22:09:51 +00:00
saml_testing.js XSS linting, fixes CNVS-17663 2014-12-29 17:45:43 +00:00
section.js student context card on course sections page 2016-12-09 20:49:33 +00:00
select_content_dialog.js Fix LTI launch modals don't contain focus. 2017-01-09 17:47:21 +00:00
setWebpackCdnHost.js Webpack: better handling of chunks and cdn stuff 2017-01-03 22:50:31 +00:00
setupAndFocusTinyMCEConfig.js rename bad variable name 2016-05-11 17:22:27 +00:00
sis_import.js XSS linting, fixes CNVS-17663 2014-12-29 17:45:43 +00:00
slickgrid.long_text_editor.js XSS linting, fixes CNVS-17663 2014-12-29 17:45:43 +00:00
speed_grader.js render comments with attachments in SpeedGrader 2017-01-28 17:13:36 +00:00
speed_grader_helpers.js Add OriginalityReport URL to Speed Grader 2017-01-04 19:38:39 +00:00
speed_grader_select_menu.js redesign speedgrader top toolbar 2016-07-14 14:36:36 +00:00
sub_accounts.js fix focus handling on sub-accounts page 2016-02-09 18:22:16 +00:00
submission_download.js XSS linting, fixes CNVS-17663 2014-12-29 17:45:43 +00:00
submissions.js Decouple grades and comments in gradebook api 2016-06-15 22:17:17 +00:00
submit_assignment.js Fix LTI launch modals don't contain focus. 2017-01-09 17:47:21 +00:00
submit_assignment_helper.js Use content item in 'more' tab HW submission 2016-09-15 21:50:18 +00:00
supercalc.js formula question responsiveness improvement 2016-06-20 18:19:24 +00:00
symlink_to_node_modules use node_modules wherever possible 2016-11-01 15:14:52 +00:00
take_quiz.js don’t try to load quiz web worker from a different origin 2017-01-24 00:51:32 +00:00
timezone.js Webpack: better handling of chunks and cdn stuff 2017-01-03 22:50:31 +00:00
timezone_core.js Webpack: better handling of chunks and cdn stuff 2017-01-03 22:50:31 +00:00
timezone_plugin.js Webpack: better handling of chunks and cdn stuff 2017-01-03 22:50:31 +00:00
tinymce.commands.js fix issue with inserting links inside tables 2015-08-03 21:24:53 +00:00
tinymce.config.js enable tinymce lists plugin 2016-09-01 21:34:27 +00:00
tinymce.editor_box.js alt text field in link plugin for youtube preview 2016-07-13 21:56:26 +00:00
tinymce.editor_box_list.js Upgrade TinyMCE to 4.1.7! 2015-03-12 17:52:31 +00:00
tinymce.editor_box_utils.js don't make good urls with "@" in them mailto links 2015-03-16 23:00:32 +00:00
tool_inline.js remove all occurrences of use_new_styles? from ruby code 2016-09-12 15:31:07 +00:00
tricktiny.js upgraded requirejs to 2.1.10 2014-03-10 22:27:53 +00:00
underscore.flattenObjects.js discussions: handle keyboard shortcuts 2014-01-08 00:39:17 +00:00
underscore.js lodash 2014-01-14 23:37:26 +00:00
user.js require -> define in public/javascripts 2012-03-05 14:19:50 -07:00
user_grades.js fix loading of grades on grades page 2015-11-13 16:17:28 +00:00
user_logins.js expose integration id on user details page 2016-07-13 20:49:41 +00:00
user_name.js XSS linting, fixes CNVS-17663 2014-12-29 17:45:43 +00:00
user_notes.js fix js_block that would break if using webpack 2016-11-22 00:25:35 +00:00
user_sortable_name.js require -> define in public/javascripts 2012-03-05 14:19:50 -07:00
user_utils.js make jslint settings more sane 2012-08-17 11:04:40 -06:00
wikiSidebar.js fix add button for all tabs within wiki sidebar 2017-01-17 18:53:06 +00:00