cdf3f96439
if the reqeuest is not complete. also increase the debounce time to reduce the chance of making more expensive search requests than needed if someone is typing slow. without this fix the search was making multiple requests to the server and would always show the last results to come back regardless of order. this would lead to cases where the right results show temporarily then the wrong results show immediately after. closes CORE-1347 test plan: - test with course and user search. it will help to have a ton of records to make the search slow. when i tested I just added `sleep (rand 3) + 1` to each of the api controller actions to simulate slow search and make it more likely requests will come back in the wrong order. - have the network tab open - if you type in the search bar slowly enough to trigger multiple request the unfinished requests should be aborted - results should always match the search term Change-Id: I8953d73ea81784e4080cd64412effa0e95520761 Reviewed-on: https://gerrit.instructure.com/150218 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Reviewed-by: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Matt Miller <mmiller@instructure.com> |
||
|---|---|---|
| .. | ||
| ModuleSequenceFooterSpec.js | ||
| ajaxJSONSpec.js | ||
| fixDialogButtonsSpec.js | ||
| mediaCommentSpec.js | ||
| mediaCommentThumbnailSpec.js | ||
| outerclickSpec.js | ||
| redirectClickToSpec.js | ||
| serializeFormSpec.js | ||