8d3eac6c3a
fix issue where when additional granular permissions for adding individual course roles are not enabled, a 403 error will appear when resending invites in the roster page fixes VICE-3902 flag=none Test Plan: - pick a role for testing. Example TA role. - have the Users - manage students in courses permission turned on - have all the individual granular add permissions turned off except the Users - Students option. - note that permissions take a while to take into effect. A trick is to change timezones for the account with the role that you want to test. I tested using a TA role and changing the timezone to Tokyo and then changing back to central time in the TA account helped speed up the permissions change. - have a student and teacher in the course - log in to the account with the testing role and go to the roster page - go the student and click on the three dots - confirm that resend invitation option is shown - go to the teacher and click on the three dots - confirm that resend invitation option is not shown - add a teacher role using the same student email - view that the resend option is still in the dropdown for the student - click resend and confirm that the invitation is sent and no 403 error appears - confirm that only one api call is made in the network tab for the student role Change-Id: I979274bc74078036bc2cbf69171c288bc876c331 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341881 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Caleb Guanzon <cguanzon@instructure.com> QA-Review: Jason Gillett <jason.gillett@instructure.com> Product-Review: Samuel Lee <samuel.lee@instructure.com> |
||
|---|---|---|
| .. | ||
| pages | ||
| people_settings_spec.rb | ||
| people_spec.rb | ||
| user_content_student_spec.rb | ||
| users_spec.rb | ||