ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/app/models
History
Keith Garner 77cb4ad288 rewrite assignment grade and submission after_saves 
Rewrite of Assignment#update_student_submissions and
Assignment#update_grades_if_details_changed to be front-ended by
Assignment#update_submissions_and_grades_if_details_changed to avoid a
race condition and to only calculate grades once in the case of
update_student_submissions.

fixes CNVS-37090

test plan:
 - Create a course with an assignment and student students.
 - Grade the students for the assignment.
 - Alter an assignment detail like points possible and save the
 assignment
 - Note that the final grade is updated and correct

Change-Id: I7ccc1404f12fcc2363ac6d2e29788db69c9a5a43
Reviewed-on: https://gerrit.instructure.com/112811
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
 		2017-05-24 23:34:23 +00:00
..
account da licença part 8 2017-04-27 21:33:20 +00:00
account_authorization_config use standard service and url params for CAS logout 2017-05-22 18:30:29 +00:00
alerts da licença part 8 2017-04-27 21:33:20 +00:00
assignment bulk load originality reports in submission history friendly way 2017-05-06 16:21:44 +00:00
assignments da licença part 8 2017-04-27 21:33:20 +00:00
attachments upgrade to aws v4 s3 signatures 2017-05-03 20:49:57 +00:00
auditors da licença part 8 2017-04-27 21:33:20 +00:00
bookmarks da licença part 9 2017-04-27 21:33:39 +00:00
broadcast_policies da licença part 9 2017-04-27 21:33:39 +00:00
communication_channel da licença part 10 2017-04-28 17:30:08 +00:00
conditional_release da licença part 10 2017-04-28 17:30:08 +00:00
context_module_progressions da licença part 10 2017-04-28 17:30:08 +00:00
courses da licença part 10 2017-04-28 17:30:08 +00:00
discussion_topic da licença part 10 2017-04-28 17:30:08 +00:00
enrollment da licença part 11 2017-04-27 21:36:17 +00:00
epub_exports da licença part 11 2017-04-27 21:36:17 +00:00
exporters da licença part 11 2017-04-27 21:36:17 +00:00
group_categories da licença part 12 2017-04-27 21:36:29 +00:00
importers propagate removal of due/available dates in blueprint sync 2017-05-23 15:34:53 +00:00
incoming_mail da licença part 12 2017-04-27 21:36:29 +00:00
live_assessments da licença part 13 2017-04-27 21:51:17 +00:00
lti lti2 launch by link_id 2017-05-23 14:41:49 +00:00
master_courses notify when a blueprint sync completes 2017-05-19 22:08:46 +00:00
messages da licença part 13 2017-04-27 21:51:17 +00:00
moderated_grading da licença part 13 2017-04-27 21:51:17 +00:00
page_view da licença part 14 2017-04-28 17:30:12 +00:00
polling da licença part 14 2017-04-28 17:30:12 +00:00
quizzes respect late_policy_status attribute 2017-05-23 13:48:17 +00:00
users da licença part 16 2017-04-27 21:51:21 +00:00
version da licença part 16 2017-04-27 21:51:21 +00:00
wiki_pages da licença part 16 2017-04-27 21:51:21 +00:00
abstract_course.rb da licença part 8 2017-04-27 21:33:20 +00:00
access_token.rb Merge branch 'grahamb-developer_key_notes_field' 2017-05-10 08:21:39 -06:00
account.rb make the root account cache relative to the default shard, not the birth 2017-05-24 22:17:09 +00:00
account_authorization_config.rb da licença part 8 2017-04-27 21:33:20 +00:00
account_notification.rb da licença part 8 2017-04-27 21:33:20 +00:00
account_notification_role.rb da licença part 8 2017-04-27 21:33:20 +00:00
account_report.rb allow aborting account reports 2017-05-03 18:34:02 +00:00
account_user.rb da licença part 8 2017-04-27 21:33:20 +00:00
alert.rb da licença part 8 2017-04-27 21:33:20 +00:00
alert_criterion.rb da licença part 8 2017-04-27 21:33:20 +00:00
announcement.rb Planner API 2017-05-15 19:18:47 +00:00
appointment_group.rb da licença part 8 2017-04-27 21:33:20 +00:00
appointment_group_context.rb da licença part 8 2017-04-27 21:33:20 +00:00
appointment_group_sub_context.rb da licença part 8 2017-04-27 21:33:20 +00:00
assessment_question.rb da licença part 8 2017-04-27 21:33:20 +00:00
assessment_question_bank.rb da licença part 8 2017-04-27 21:33:20 +00:00
assessment_question_bank_user.rb da licença part 8 2017-04-27 21:33:20 +00:00
assessment_request.rb da licença part 8 2017-04-27 21:33:20 +00:00
asset_user_access.rb da licença part 8 2017-04-27 21:33:20 +00:00
assignment.rb rewrite assignment grade and submission after_saves 2017-05-24 23:34:23 +00:00
assignment_configuration_tool_lookup.rb da licença part 8 2017-04-27 21:33:20 +00:00
assignment_group.rb da licença part 8 2017-04-27 21:33:20 +00:00
assignment_override.rb Update DueDateCacher to use EffectiveDueDates 2017-05-11 20:54:44 +00:00
assignment_override_student.rb fix staleness issues with cached_due_date 2017-04-28 16:01:47 +00:00
assignment_student_visibility.rb da licença part 8 2017-04-27 21:33:20 +00:00
attachment.rb upgrade to aws v4 s3 signatures 2017-05-03 20:49:57 +00:00
attachment_association.rb da licença part 8 2017-04-27 21:33:20 +00:00
auditors.rb da licença part 8 2017-04-27 21:33:20 +00:00
big_blue_button_conference.rb da licença part 9 2017-04-27 21:33:39 +00:00
bookmark_service.rb da licença part 9 2017-04-27 21:33:39 +00:00
bookmarks.rb da licença part 9 2017-04-27 21:33:39 +00:00
bounce_notification_processor.rb da licença part 9 2017-04-27 21:33:39 +00:00
brand_config.rb da licença part 9 2017-04-27 21:33:39 +00:00
calendar_event.rb Appointment group reservation peer visibility 2017-05-02 21:55:41 +00:00
canvadoc.rb Canvadocs hijack crocodoc sessions 2017-05-03 22:11:01 +00:00
canvadocs_submission.rb da licença part 10 2017-04-28 17:30:08 +00:00
cloned_item.rb da licença part 10 2017-04-28 17:30:08 +00:00
collaboration.rb da licença part 10 2017-04-28 17:30:08 +00:00
collaborator.rb da licença part 10 2017-04-28 17:30:08 +00:00
communication_channel.rb da licença part 10 2017-04-28 17:30:08 +00:00
content_export.rb mark content exports older than 30 days as expired 2017-05-23 19:51:12 +00:00
content_migration.rb notify when a blueprint sync completes 2017-05-19 22:08:46 +00:00
content_participation.rb da licença part 10 2017-04-28 17:30:08 +00:00
content_participation_count.rb da licença part 10 2017-04-28 17:30:08 +00:00
content_tag.rb da licença part 10 2017-04-28 17:30:08 +00:00
context.rb da licença part 10 2017-04-28 17:30:08 +00:00
context_external_tool.rb da licença part 10 2017-04-28 17:30:08 +00:00
context_external_tool_assignment_lookup.rb da licença part 10 2017-04-28 17:30:08 +00:00
context_external_tool_placement.rb da licença part 10 2017-04-28 17:30:08 +00:00
context_module.rb da licença part 10 2017-04-28 17:30:08 +00:00
context_module_item.rb da licença part 10 2017-04-28 17:30:08 +00:00
context_module_progression.rb don't calculate module score requirements for muted assignments 2017-05-24 12:21:51 +00:00
context_module_sub_header.rb da licença part 10 2017-04-28 17:30:08 +00:00
conversation.rb da licença part 10 2017-04-28 17:30:08 +00:00
conversation_batch.rb da licença part 10 2017-04-28 17:30:08 +00:00
conversation_message.rb da licença part 10 2017-04-28 17:30:08 +00:00
conversation_message_participant.rb da licença part 10 2017-04-28 17:30:08 +00:00
conversation_participant.rb da licença part 10 2017-04-28 17:30:08 +00:00
course.rb change all labels to 'sync' for sis grade syncing 2017-05-13 00:16:54 +00:00
course_account_association.rb da licença part 10 2017-04-28 17:30:08 +00:00
course_date_range.rb da licença part 10 2017-04-28 17:30:08 +00:00
course_profile.rb da licença part 10 2017-04-28 17:30:08 +00:00
course_progress.rb da licença part 10 2017-04-28 17:30:08 +00:00
course_section.rb da licença part 10 2017-04-28 17:30:08 +00:00
crocodoc_document.rb Canvadocs hijack crocodoc sessions 2017-05-03 22:11:01 +00:00
custom_data.rb da licença part 10 2017-04-28 17:30:08 +00:00
custom_gradebook_column.rb da licença part 10 2017-04-28 17:30:08 +00:00
custom_gradebook_column_datum.rb da licença part 10 2017-04-28 17:30:08 +00:00
delayed_message.rb notify when a blueprint sync completes 2017-05-19 22:08:46 +00:00
delayed_notification.rb da licença part 10 2017-04-28 17:30:08 +00:00
designer_enrollment.rb da licença part 10 2017-04-28 17:30:08 +00:00
developer_key.rb Merge branch 'grahamb-developer_key_notes_field' 2017-05-10 08:21:39 -06:00
discussion_entry.rb da licença part 10 2017-04-28 17:30:08 +00:00
discussion_entry_participant.rb da licença part 10 2017-04-28 17:30:08 +00:00
discussion_topic.rb don't send course announcement notifications when soft-concluded 2017-05-18 12:31:33 +00:00
discussion_topic_participant.rb da licença part 10 2017-04-28 17:30:08 +00:00
document_service.rb da licença part 10 2017-04-28 17:30:08 +00:00
enrollment.rb fix staleness issues with cached_due_date 2017-04-28 16:01:47 +00:00
enrollment_dates_override.rb da licença part 11 2017-04-27 21:36:17 +00:00
enrollment_state.rb da licença part 11 2017-04-27 21:36:17 +00:00
enrollment_term.rb Update DueDateCacher to use EffectiveDueDates 2017-05-11 20:54:44 +00:00
eportfolio.rb da licença part 11 2017-04-27 21:36:17 +00:00
eportfolio_category.rb da licença part 11 2017-04-27 21:36:17 +00:00
eportfolio_entry.rb da licença part 11 2017-04-27 21:36:17 +00:00
epub_export.rb da licença part 11 2017-04-27 21:36:17 +00:00
error_report.rb sanitize unusual error report URLs when displaying them 2017-05-17 03:40:38 +00:00
etherpad_collaboration.rb da licença part 11 2017-04-27 21:36:17 +00:00
external_feed.rb da licença part 11 2017-04-27 21:36:17 +00:00
external_feed_entry.rb da licença part 11 2017-04-27 21:36:17 +00:00
external_integration_key.rb da licença part 11 2017-04-27 21:36:17 +00:00
external_tool_collaboration.rb da licença part 11 2017-04-27 21:36:17 +00:00
external_url.rb da licença part 11 2017-04-27 21:36:17 +00:00
favorite.rb da licença part 11 2017-04-27 21:36:17 +00:00
feature_flag.rb da licença part 11 2017-04-27 21:36:17 +00:00
folder.rb da licença part 11 2017-04-27 21:36:17 +00:00
google_docs_collaboration.rb da licença part 12 2017-04-27 21:36:29 +00:00
gradebook_csv.rb da licença part 12 2017-04-27 21:36:29 +00:00
gradebook_upload.rb da licença part 12 2017-04-27 21:36:29 +00:00
grading_period.rb Update DueDateCacher to use EffectiveDueDates 2017-05-11 20:54:44 +00:00
grading_period_group.rb Update DueDateCacher to use EffectiveDueDates 2017-05-11 20:54:44 +00:00
grading_standard.rb don't allow grading schemes with grade names > 255 chars 2017-05-03 16:12:46 +00:00
group.rb allow teachers in concluded courses to reply to discussions 2017-05-08 16:41:28 +00:00
group_category.rb da licença part 12 2017-04-27 21:36:29 +00:00
group_leadership.rb da licença part 12 2017-04-27 21:36:29 +00:00
group_membership.rb da licença part 12 2017-04-27 21:36:29 +00:00
ignore.rb da licença part 12 2017-04-27 21:36:29 +00:00
importers.rb da licença part 12 2017-04-27 21:36:29 +00:00
kaltura_media_file_handler.rb da licença part 13 2017-04-27 21:51:17 +00:00
late_policy.rb fix/ensure that latepolicy has unique course_id 2017-05-22 16:03:13 +00:00
learning_outcome.rb da licença part 13 2017-04-27 21:51:17 +00:00
learning_outcome_group.rb da licença part 13 2017-04-27 21:51:17 +00:00
learning_outcome_question_result.rb da licença part 13 2017-04-27 21:51:17 +00:00
learning_outcome_result.rb da licença part 13 2017-04-27 21:51:17 +00:00
live_assessments.rb da licença part 13 2017-04-27 21:51:17 +00:00
lti.rb da licença part 13 2017-04-27 21:51:17 +00:00
mailer.rb da licença part 13 2017-04-27 21:51:17 +00:00
master_courses.rb master courses: allow default restrictions to be set by type 2017-05-11 12:33:20 +00:00
media_object.rb da licença part 13 2017-04-27 21:51:17 +00:00
media_source_fetcher.rb da licença part 13 2017-04-27 21:51:17 +00:00
media_track.rb da licença part 13 2017-04-27 21:51:17 +00:00
message.rb notify when a blueprint sync completes 2017-05-19 22:08:46 +00:00
migration_issue.rb da licença part 13 2017-04-27 21:51:17 +00:00
moderated_grading.rb da licença part 13 2017-04-27 21:51:17 +00:00
notification.rb notify when a blueprint sync completes 2017-05-19 22:08:46 +00:00
notification_endpoint.rb da licença part 14 2017-04-28 17:30:12 +00:00
notification_failure_processor.rb da licença part 14 2017-04-28 17:30:12 +00:00
notification_finder.rb da licença part 14 2017-04-28 17:30:12 +00:00
notification_policy.rb da licença part 14 2017-04-28 17:30:12 +00:00
notification_preloader.rb da licença part 14 2017-04-28 17:30:12 +00:00
notifier.rb da licença part 14 2017-04-28 17:30:12 +00:00
oauth_request.rb da licença part 14 2017-04-28 17:30:12 +00:00
observer_enrollment.rb da licença part 14 2017-04-28 17:30:12 +00:00
one_time_password.rb MFA backup code support 2017-05-02 16:08:53 +00:00
originality_report.rb da licença part 14 2017-04-28 17:30:12 +00:00
page_comment.rb da licença part 14 2017-04-28 17:30:12 +00:00
page_view.rb da licença part 14 2017-04-28 17:30:12 +00:00
planner_note.rb add note to self model 2017-05-22 16:33:13 +00:00
planner_override.rb Planner API 2017-05-15 19:18:47 +00:00
plugin_setting.rb da licença part 14 2017-04-28 17:30:12 +00:00
polling.rb da licença part 14 2017-04-28 17:30:12 +00:00
profile.rb da licença part 14 2017-04-28 17:30:12 +00:00
progress.rb da licença part 14 2017-04-28 17:30:12 +00:00
pseudonym.rb da licença part 14 2017-04-28 17:30:12 +00:00
pseudonym_session.rb da licença part 14 2017-04-28 17:30:12 +00:00
report_snapshot.rb da licença part 15 2017-04-27 21:51:19 +00:00
role.rb da licença part 15 2017-04-27 21:51:19 +00:00
role_override.rb allow teachers in concluded courses to reply to discussions 2017-05-08 16:41:28 +00:00
rollup_score.rb da licença part 15 2017-04-27 21:51:19 +00:00
rubric.rb da licença part 15 2017-04-27 21:51:19 +00:00
rubric_assessment.rb da licença part 15 2017-04-27 21:51:19 +00:00
rubric_association.rb da licença part 15 2017-04-27 21:51:19 +00:00
score.rb da licença part 15 2017-04-27 21:51:19 +00:00
scribd_mime_type.rb da licença part 15 2017-04-27 21:51:19 +00:00
session_persistence_token.rb da licença part 15 2017-04-27 21:51:19 +00:00
setting.rb da licença part 15 2017-04-27 21:51:19 +00:00
sharded_bookmarked_collection.rb da licença part 15 2017-04-27 21:51:19 +00:00
shared_brand_config.rb da licença part 15 2017-04-27 21:51:19 +00:00
sis_batch.rb da licença part 15 2017-04-27 21:51:19 +00:00
sis_post_grades_status.rb da licença part 15 2017-04-27 21:51:19 +00:00
sis_pseudonym.rb refactor and unify User#find_pseudonym_for_account and SisPseudonym 2017-05-02 18:50:31 +00:00
split_users.rb da licença part 15 2017-04-27 21:51:19 +00:00
stream_item.rb da licença part 15 2017-04-27 21:51:19 +00:00
stream_item_instance.rb da licença part 15 2017-04-27 21:51:19 +00:00
student_enrollment.rb da licença part 15 2017-04-27 21:51:19 +00:00
student_view_enrollment.rb da licença part 15 2017-04-27 21:51:19 +00:00
submission.rb VeriCite: get all scores for an assignment in bulk 2017-05-24 17:09:57 +00:00
submission_comment.rb da licença part 15 2017-04-27 21:51:19 +00:00
submission_comment_interaction.rb da licença part 15 2017-04-27 21:51:19 +00:00
submission_version.rb da licença part 15 2017-04-27 21:51:19 +00:00
ta_enrollment.rb da licença part 15 2017-04-27 21:51:19 +00:00
tableless.rb da licença part 15 2017-04-27 21:51:19 +00:00
teacher_enrollment.rb da licença part 15 2017-04-27 21:51:19 +00:00
thumbnail.rb da licença part 15 2017-04-27 21:51:19 +00:00
usage_rights.rb da licença part 16 2017-04-27 21:51:21 +00:00
user.rb add note to self model 2017-05-22 16:33:13 +00:00
user_account_association.rb da licença part 16 2017-04-27 21:51:21 +00:00
user_merge_data.rb da licença part 16 2017-04-27 21:51:21 +00:00
user_merge_data_record.rb da licença part 16 2017-04-27 21:51:21 +00:00
user_note.rb da licença part 16 2017-04-27 21:51:21 +00:00
user_observer.rb da licença part 16 2017-04-27 21:51:21 +00:00
user_profile.rb da licença part 16 2017-04-27 21:51:21 +00:00
user_profile_link.rb da licença part 16 2017-04-27 21:51:21 +00:00
user_service.rb da licença part 16 2017-04-27 21:51:21 +00:00
web_conference.rb da licença part 16 2017-04-27 21:51:21 +00:00
web_conference_participant.rb da licença part 16 2017-04-27 21:51:21 +00:00
web_zip_export.rb da licença part 16 2017-04-27 21:51:21 +00:00
wiki.rb da licença part 16 2017-04-27 21:51:21 +00:00
wiki_page.rb Planner API 2017-05-15 19:18:47 +00:00
wimba_conference.rb da licença part 16 2017-04-27 21:51:21 +00:00