fix multiple a11y issues on the
grading schemes page.
closes CNVS-26083
closes CNVS-26082
closes CNVS-26206
closes CNVS-26217
test plan:
A) Verify extraneous focus area
no longer exists when editing
- Begin editing a grading scheme
- Press Tab to move from the title
field to the first row
- Note that the "+" is focused (before
this fix, a large, awkwardly placed
grey box would be focused before the
"+" button was focused)
B) Verify focus on grading schemes
- Tab to the "Add grading scheme" button
- Tab again and note that focus is on a
grading scheme (before this fix, the
focus would disappear and skip over the
grading scheme)
C) Verify the icon to add a new line on
a grading scheme is always visible when editing
- Begin editing a grading scheme
- Verify a "+" icon appears next to each line
of the grading scheme (before this fix, the
"+" icon would only appear when hovering
or focusing on a line)
D) Verify the 'Add a grading scheme button' is
announced as a 'Button'
- Navigate to the "Add a grading scheme" button
using a screenreader. Verify the "Add a grading
scheme" button is announced as a button (
previously, this was announced as a link)
E) Verify the icons to edit and trash grading
schemes are announced as 'Button's
- Using a screenreader, navigate to the pencil
icon within a grading scheme. Verify the
pencil icon is announced as a button (
previously, this was announced as a link)
- Using a screenreader, navigate to the trash
icon within a grading scheme. Verify the
trash icon is announced as a button (
previously, this was announced as a link)
F) Verify the icons to add and delete lines of
a grading scheme are announced as 'Button's
- Begin editing a grading scheme
- Navigate to the "+" icon using a screenreader.
Verify the "+" is announced as a button (
previously, this was announced as a link)
- Navigate to the "x" icon using a screenreader.
Verify the "x" is announced as a button (
previously, this was announced as a link)
Change-Id: I49c46fe8d9d7eaf40551e23f70673b519ed89898
Reviewed-on: https://gerrit.instructure.com/70796
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
4558243af0