ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/spec
History
Caleb Guanzon 63c8517942 respect granular course content permissions in announcements ui 
flag=granular_permissions_manage_course_content
fixes VICE-3285

Since the permission explainer test specifically specifies
that announcement locking and deleting should really
affect announcements locking and deleting,

we should make it so

this fix will also work with the manage course content
combined permission

test plan:
- turn on the
granular_permissions_manage_course_content feature flag

verify the following in the course announcements index:
- the delete row item menu option only shows for roles with
the manage_course_content_delete permission
- the lock/allow row item menu option only shows for roles with
the manage_course_content_edit permission
- if user has neither of these 2 permissions, the
announcement rows do not show a checkbox, and does
not show a manage menu

Change-Id: Ia4b2eee6461b6a85ae71a8b8e5af15586b7aad23
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/310593
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
QA-Review: Jason Gillett <jason.gillett@instructure.com>
 		2023-02-08 17:07:25 +00:00
..
apis include comment attempt in submission API 2023-02-06 18:09:06 +00:00
coffeescripts spec: Call deepLinkingResponsHandler with no title 2023-02-03 21:34:20 +00:00
contracts override pact-messages deprecated method usage 2022-12-14 17:26:49 +00:00
controllers Revert "Respect prevent_course_availability_editing_by_teachers in API" 2023-02-02 17:57:04 +00:00
factories also serialize shard in attachments martial functions 2022-11-28 19:49:14 +00:00
factory_bot RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
fixtures don't fail integrity_check when md5 is missing (local/s3) 2023-02-04 16:57:08 +00:00
formatters Remove unnecessary require statements 2023-01-04 21:38:21 +00:00
gem_integration/canvas_connect RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
graphql sort child_topics by context_name 2023-02-06 21:32:55 +00:00
helpers Handle JSON parse returning nil 2022-12-08 18:29:48 +00:00
initializers allow additional columns to be ignored through Consul 2023-02-08 17:05:57 +00:00
integration deprioritize section overrides for nonactive enrollments 2022-12-22 18:20:06 +00:00
javascripts respect granular course content permissions in announcements ui 2023-02-08 17:07:25 +00:00
lib setting nq grade to nil not showing submissions 2023-02-08 17:00:17 +00:00
manual_seeding RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
messages point entry specific notifications to entry 2023-02-03 01:50:53 +00:00
migrations introduce bootsnap 2022-10-04 13:18:03 +00:00
models Set ConversationMessageParticipant root_account_ids on create 2023-02-08 15:59:02 +00:00
observers fix duplicated LiveEvent when locking a quiz 2022-09-22 20:12:17 +00:00
presenters guard from bogus query param values for MarkDonePresenter 2023-01-06 17:38:28 +00:00
requests update student pace in table after publishing 2023-02-02 22:21:38 +00:00
schemas/lti RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
selenium bring proxy submission into individual gradebook 2023-02-02 14:25:50 +00:00
serializers Include resource link custom vars in NRPS 2022-12-06 18:32:49 +00:00
services/course_pacing update student pace in table after publishing 2023-02-02 22:21:38 +00:00
shared_examples fix grading periods within controller shared examples for ruby 3.x 2022-12-13 19:16:47 +00:00
support allow forcing crystal ball to run despite config changes 2022-10-18 16:32:35 +00:00
views fix student unread grade content participation 2023-01-13 18:06:08 +00:00
.eslintrc
…
.rspec_parallel
…
ams_spec_helper.rb Kill require_dependency 2023-01-09 19:51:01 +00:00
broadcast_integration.rb
…
canvas_simplecov.rb Repair canvas coverage 2022-01-05 17:55:26 +00:00
cassandra_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
conditional_release_spec_helper.rb Move Mastery Path to an account/course setting 2022-04-13 22:26:57 +00:00
coverage_tool.rb Repair canvas coverage 2022-01-05 17:55:26 +00:00
factories.rb Stop leaking siteadmin ids from spec setup 2022-02-25 23:11:11 +00:00
factory_bot_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
feature_flag_helper.rb RuboCop: Performance 2021-11-17 20:03:38 +00:00
file_upload_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
force_failure_spec.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
import_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
jspec.sh Improve Karma test loading 2022-10-12 18:23:35 +00:00
lti2_course_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
lti2_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
lti_1_3_spec_helper.rb rename Canvas::DynamicSettings => DynamicSettings 2022-01-12 21:54:51 +00:00
lti_1_3_tool_configuration_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
lti_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
plagiarism_platform_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
quiz_spec_helper.rb
…
rcov.opts
…
rspec_mock_extensions.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
sharding_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
simple_cov_result_merger.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
spec.opts
…
spec_helper.rb Kill require_dependency 2023-01-09 19:51:01 +00:00