closes ADV-104
flag=top_navigation_placement
Test plan:
- NOTE: You must restart the web container after running Setting.set
- PreReqs:
- A tool with the `top_navigation` placement
- On a Canvas page with the Top Navigation, check the following
- Without the tool in the allow list
- ENV does not have key `top_navigation_tools`
- No tool buttons show up in the navigation bar
- With the tool in the allow list by dev key
Setting.set("top_navigation_allowed_dev_keys", "global-dev-key-id")
- ENV.top_navigation_tools is populated with the tool config
- The tool menu button shows up in the top navigation bar
- The tool is listed in the menu and can be launched in drawer
- Adjust the page to mobile width
- Ensure the tool menu shows up in mobile header and can be launched
- The tool should open in a tray that overlays the content
- Repeat with the tool only in the domain list
Setting.set("top_navigation_allowed_dev_keys", "")
Setting.set("top_navigation_allowed_launch_domains", "tool-launch-domain")
- With the tool in either allow list, add it to the pinned keys list
Setting.set("top_navigation_pinned_dev_keys", "global-dev-key-id")
- Ensure the tool has a dedicated button in top nav and the tool menu
is not rendered.
- Repeate with the tool only in the allowd domains list
Setting.set("top_navigation_pinned_dev_keys", "")
Setting.set("top_navigation_pinned_launch_domains", "tool-launch-domain")
- With the tool in the pinned list but not the allowed list, ensure it
is not rendered in the top navigation menu and is not in ENV.
Change-Id: I267b78316e54dab7f811e3a7d8eaa752668ac5db
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347352
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Dustin Cowles <dustin.cowles@instructure.com>
c3e952a1a4