bf2e54176f
only_visible_to_overrides should be set to false IF - there is an everyone card that is NOT because of a course override, or if there are only module overrides. Otherwise only_visible_to_override should be set to true. closes LX-1670 flag=differentiated_modules test plan: - this should work anywhere the tray works, test in assignment edit pages and discussion edit pages as well - have a module with assignment overrides and a learning object in the module - I suggest having a rails console open to check the value of only_visible_to_overrides as you test. Aka, run learning_object.only_visible_to_overrides - if you're testing a graded discussion, run discussion.assignment.only_visible_to_overrides - open the assign to tray for the object, and add an override - expect only_visible_to_overrides to be true - remove the override, leaving only the module overrides - expect only_visible_to_overrides to be false - if you add everyone back to the assignment, because you are adding everyone through a course override, only_visible_to_overrides should be true. - expect behavior without any module overrides to be the same (aka, if there is an everyone card then only_visible_to_overrides is false) Change-Id: I6fd71ec27227df72c7d9c8227660b6242057a411 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348243 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jackson Howe <jackson.howe@instructure.com> QA-Review: Jackson Howe <jackson.howe@instructure.com> Product-Review: Sarah Gerard <sarah.gerard@instructure.com> |
||
|---|---|---|
| .. | ||
| backbone | ||
| jquery | ||
| jst | ||
| react | ||
| util | ||
| AssignmentOverrideHelper.js | ||
| package.json | ||