Closes CNVS-21176
Note: This affects the main canvas layout. Before,
the context menu was to the left side of the
breadcrumb as can be seen here:
http://www.screencast.com/t/Oj8s3Fnbu. Now, the
context menu and page content is below the
breadcrumb, as can be seen here:
http://www.screencast.com/t/0eQv3UBvBSix.
We need a full regression on this to make sure our
padding maintains integrity throughout Canvas (for
example, avoiding situations as can be seen here
http://www.screencast.com/t/4cF0mccTwCt where the
padding is ommitted and content is flush with other
elements on the page)
Test Plan:
-The scope of this commit is across all of Canvas.
Essentially, every page in the NUI (especially
those with a breadcrumb) will need to be examined
for the following:
-The context menu should be below the
breadcrumb on any page that has a breadcrumb
(http://www.screencast.com/t/0eQv3UBvBSix)
except for Courses->Files (this page should
be unaffected and behave as before)
-All page content should have padding as can
be seen here:
http://www.screencast.com/t/NAo0jdtZvzr
(Note: LTI tools intentionally omit the top
padding, as can be seen here:
http://www.screencast.com/t/Vk202kWm2x6)
-On resize, there should still be padding
between the global nav and the page content
-On resize, there should still be padding
between the right side of the browser window
and the page content.
-On resize, when the right side content
collapses and moves to the bottom of the page,
its margins should be consistent with the width
of the footer as can be seen here:
http://www.screencast.com/t/OjQGqA3nBi
-Legacy Canvas should be unaffected by the changes
made here. Breadcrumb pages in the legacy ui would
be especially important to review.
Change-Id: I05ef5fbdb3e2bd7f9106e57a7a5ab651ccc51aaa
Reviewed-on: https://gerrit.instructure.com/58516
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
84973a5691