13711dc255
fixes PLAT-1762 test plan: * Add a manual external app * Enter valid settings but leave the description and domain blank * Save the app * Edit the same app and save again * Edit and ensure the domain and description are not "null" Change-Id: I7046ef564790acd8ae790c42611d832ae9f803e6 Reviewed-on: https://gerrit.instructure.com/88861 Reviewed-by: Pedro Fajardo <pfajardo@instructure.com> Tested-by: Jenkins QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com> Reviewed-by: Andrew Butterfield <abutterfield@instructure.com> Product-Review: August Thornton <august@instructure.com> |
||
---|---|---|
.. | ||
account_course_user_search | ||
assignments | ||
authentication_providers | ||
calendar/scheduler | ||
collaborations | ||
conditional_release_stats | ||
context_modules | ||
course_link_validator | ||
course_settings | ||
course_wizard | ||
custom_help_link_settings | ||
dashboard_card | ||
discussion_topics | ||
due_dates | ||
editor | ||
epub_exports | ||
external_apps | ||
files | ||
gradebook | ||
gradebook2 | ||
grading | ||
groups | ||
help_dialog | ||
login | ||
navigation_header | ||
notification_preferences | ||
outcomes | ||
quizzes | ||
shared | ||
styleguide | ||
theme_editor | ||
README.md | ||
railsFlashNotificationsHelper.jsx |
README.md
This directory is temporary until we rework the front-end build This is where we are headed.
Stuff you can do in Canvas JSX files
BUT WAIT!
Your file needs to:
- Have a file name with the
.jsx
extension.
JSX
function foo(paths) {
return <svg>{paths}</svg>;
}
Arrow Functions
var arr = ['hydrogen', 'helium', 'lithium'];
// es5
var a = arr.map(function(s){ return s.length });
// es6
var b = arr.map( s => s.length );
// with curlies requires normal return
var b = arr.map( (s) => {
return s.length
});
// lexical `this`
var obj = {
multiplier: 3,
multiplyStuff (stuff) {
return stuff.map((x) =>
// no bind!
return this.multiplier * x;
)
}
};
Classes
class EventEmitter {
constructor() {
// called when created
}
emit() {
// ...
}
on() {
// ...
}
once() {
// ...
}
removeListener() {
// ...
}
removeAllListeners() {
// ...
}
}
Extending and calling super
.
class Domain extends EventEmitter {
constructor() {
super();
this.members = [];
}
}
Creating instances
var domain = new Domain();
Destructuring
// es5
var map = _.map;
var each = _.each;
// es6
var {map, each} = _;
Concise Object Methods
// es5
var obj = {
foo: function() {}
bar: function() {}
};
// es6
var obj = {
foo() {}
bar() {}
};
Object Short Notation
// es5
function() {
// ...
return {foo: foo, bar: bar, x: 10};
}
// es6
function() {
// ...
return {foo, bar, x: 10};
}
Rest Parameters
// es5
function multiply(multiplier) {
var numbers = Array.prototype.slice.call(arguments, 0);
return number.map(function(n) { return multiplier * n; });
}
// es6
function multiply(multiplier, ...numbers) {
return numbers.map( n => multiplier * n);
}
String Templates
Multiline strings:
// es5
console.log("string text line 1" +
"string text line 2");
// es6
console.log(`string text line 1
string text line 2`);
Interpolated strings
var a = 5;
var b = 10;
// es5
console.log("Fifteen is " + (a + b) + " and not " + (2 * a + b) + ".");
// es6
console.log(`Fifteen is ${a + b} and not ${2 * a + b}.`);