ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/spec/lib
History
Juan Chavez 3f8026e1b2 Fix RCE links for unpublished/date-locked files 
fixes MAT-374

flag=none

test plan 1:
- Upload a pdf to course root folder.
- Set visibility of the file to unpublished.
- Create a page with a link to the file (using
RCE course links).
- Replace the pdf (same name, without changing
visibility).
- As a student, navigate to the page and click the
file link.
- Verify that there is no error and Canvas doc
viewer is opened (saying that the file is locked).

test plan 2:
- Upload a pdf to course root folder.
- Set visibility of the file to date-locked.
- Create a page with a link to the file (using
RCE course links).
- Replace the pdf (same name, without changing
visibility).
- As a student, navigate to the page and click the
file link.
- Verify that there is no error and Canvas doc
viewer is opened (saying that the file is locked).

Change-Id: I91c79dd1ec1ab362eb387ac39dab9a638fc275f0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275803
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Juan Chavez <juan.chavez@instructure.com>
 		2021-10-28 18:58:27 +00:00
..
active_support/cache Don't rely on cache options mutability 2021-08-10 22:32:54 +00:00
address_book spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
api spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
app_center spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
authentication_methods spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
basic_lti add prioritizeNonToolGrade extension to grade passback 2021-10-27 15:03:43 +00:00
canvadocs spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
canvas spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
cc spec: use require_relative instead of require File.expand_path 2021-10-28 00:15:03 +00:00
cdc_migration_testing add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
data_fixup spec: use require_relative instead of require File.expand_path 2021-10-28 00:15:03 +00:00
ext spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
features spec: use require_relative instead of require File.expand_path 2021-10-28 00:15:03 +00:00
gradebook RuboCop: Layout spec/lib 2021-09-22 19:17:20 +00:00
latex spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
lti spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
message_bus spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
messageable_user spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
microsoft_sync spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
outcomes spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
rake spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
reporting spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
services spec: use require_relative instead of require File.expand_path 2021-10-28 00:15:03 +00:00
sis spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
support_helpers RuboCop: Layout spec/lib 2021-09-22 19:17:20 +00:00
turnitin spec: use require_relative instead of require File.expand_path 2021-10-28 00:15:03 +00:00
user_content Fix RCE links for unpublished/date-locked files 2021-10-28 18:58:27 +00:00
utils RuboCop: RSpec/ExampleWording 2021-09-24 02:15:35 +00:00
acts_as_list_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
address_book_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
anonymity_spec.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
api_scope_mapper_loader_spec.rb spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
api_spec.rb spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
asset_signature_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
assignment_override_applicator_spec.rb spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
assignment_util_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
authentication_methods_spec.rb Add asymmetric encryption for service tokens 2021-10-06 15:11:06 +00:00
basic_lti_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
brand_config_helpers_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
brand_config_regenerator_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
brandable_css_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
canvadocs_spec.rb RuboCop: Layout spec/lib 2021-09-22 19:17:20 +00:00
canvas_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
content_notices_spec.rb RuboCop: Lint/UnusedBlockArgument spec 2021-10-26 20:41:00 +00:00
content_zipper_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
course_link_validator_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
crummy_spec.rb RuboCop: Lint/UnusedBlockArgument spec 2021-10-26 20:41:00 +00:00
csv_with_i18n_spec.rb rename CSVWithI18n to inflect properly for zeitwerk 2021-10-11 18:52:05 +00:00
cuty_capt_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
dates_overridable_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
delayed_message_scrubber_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
differentiable_assignment_spec.rb RuboCop: Lint/UnusedBlockArgument spec 2021-10-26 20:41:00 +00:00
due_date_cacher_spec.rb RuboCop: RSpec/ExampleWording 2021-09-24 02:15:35 +00:00
dump_helper_spec.rb iterate on dump helper 2021-09-01 16:08:13 +00:00
duplicating_objects_spec.rb RuboCop: Layout spec/lib 2021-09-22 19:17:20 +00:00
effective_due_dates_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
email_address_validator_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
enrollments_from_user_list_spec.rb RuboCop: RSpec/ExampleWording 2021-09-24 02:15:35 +00:00
external_feed_aggregator_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
feature_flag_definitions_spec.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
feature_flags_spec.rb spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
feature_spec.rb spec: use require_relative instead of require File.expand_path 2021-10-28 00:15:03 +00:00
file_authenticator_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
file_in_context_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
google_analytics_dimensions_spec.rb RuboCop: RSpec/ExampleWording 2021-09-24 02:15:35 +00:00
grade_calculator_coffee_spec.rb spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
grade_calculator_spec.rb spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
gradebook_exporter_spec.rb Include student first/last name in gradebook export 2021-10-28 17:35:35 +00:00
gradebook_grading_period_assignments_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
gradebook_importer_spec.rb rubocop: update to 1.21 2021-09-28 02:40:46 +00:00
gradebook_user_ids_spec.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
grading_period_helper_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
ha_store_spec.rb Don't rely on cache options mutability 2021-08-10 22:32:54 +00:00
host_url_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
i18n_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
i18n_time_zone_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
imported_html_converter_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
inst_fs_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
job_live_events_context_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
late_policy_applicator_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
latex_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
local_cache_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
locale_selection_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
logging_filter_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
math_man_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
message_bus_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
message_dispatcher_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
messageable_user_spec.rb spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
missing_policy_applicator_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
model_cache_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
moderation_spec.rb spec: use require_relative instead of require File.expand_path 2021-10-28 00:15:03 +00:00
must_view_module_progressor_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
mutable_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
notification_message_creator_spec.rb spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
pace_plan_due_dates_calculator_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
package_root_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
password_policy_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
permissions_helper_spec.rb spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
plannable_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
planner_api_helper_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
planner_helper_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
postgresql_adapter_spec.rb several postgres extensions have moved to the gem 2021-06-08 16:04:32 +00:00
progress_runner_spec.rb RuboCop: Lint/UnusedBlockArgument spec 2021-10-26 20:41:00 +00:00
safe_yaml_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
samesite_transition_cookie_store_spec.rb RuboCop: Layout spec/lib 2021-09-22 19:17:20 +00:00
scope_filter_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
score_statistics_generator_spec.rb RuboCop: Layout spec/lib 2021-09-22 19:17:20 +00:00
security_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
sentry_proxy_spec.rb RuboCop: Layout spec/lib 2021-09-22 19:17:20 +00:00
session_token_spec.rb RuboCop: Lint 2021-09-29 03:38:23 +00:00
sort_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
sorts_assignments_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
spec_helper_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
ssl_common_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
stats_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
sticky_sis_fields_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
submission_list_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
submission_search_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
submittable_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
summary_message_consolidator_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
text_helper_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
timed_cache_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
token_scopes_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
turnitin_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
unzip_attachment_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
user_content_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
user_list_spec.rb spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
user_list_v2_spec.rb spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
user_merge_spec.rb spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
user_search_spec.rb spec: remove sharding_spec_helper requires 2021-10-28 00:19:18 +00:00
uuid_helper_spec.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
validates_as_url.rb spec: remove manual requires of spec_helper 2021-10-26 20:38:27 +00:00
yaml_spec.rb RuboCop: Layout spec/lib 2021-09-22 19:17:20 +00:00