ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/spec/models
History
Benjamin Porter 5a975d407f Include pdfjs in preferred_plugins array 
Instead of sending a separate param to canvadocs for pdfjs as
a preferred plugin, just put it in the preferred_plugins array (which
used to be called preferred_renders)

Refs CNVS-30582

Test Plan:

    - This is very difficult to test manually, particularly without
      changing any code.  The reason for this is that canvadocs doesn't
      currently do anything with the pdfjs preferred plugin so you can't
      just check for that behavior.  However, this is something you can
      do even tho it isn't ideal (and this is how I tested this patch in
      development):
      - get canvas working with a canvadocs instance on which you can
        modify code.  By modifying the canvadocs instead of the canvas,
        the integrity of this patch is maintained for test purposes.
      - In the canvadocs session controller
        (app/controllers/session_controller.js), add a log statement to
        display what comes in in the body of the request.  Something
        like:
        - console.log('Request body: ')
        - console.dir(req.body)
      - Submit an assignment to a course as a student.
      - As a teacher, open speedgrader from that assignment.  This will
        cause a new canvadocs viewing session to be created.
      - In the console output of the canvadocs instance, see that the
        body did not include a preferred_plugin of pdfjs.
      - Toggle the feature flag to enable new annotations.
      - Repeat opening speedgrader but this time observe that the body
        includes pdfjs in the list of preferred_plugins.

Change-Id: Ie3e16e1331fcdd757e96888f033e8341e7d6a0bc
Reviewed-on: https://gerrit.instructure.com/86549
Tested-by: Jenkins
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
Product-Review: Benjamin Porter <bporter@instructure.com>
 		2016-08-03 03:07:50 +00:00
..
account_authorization_config configure SAML via metadata URI 2016-05-27 18:31:08 +00:00
alerts drop a bunch of unused columns 2016-03-17 17:19:13 +00:00
assignment honor gradebook inactive/concluded settings in speedgrader 2016-07-22 16:40:51 +00:00
assignments fix anonymous moderated grading 2016-07-14 22:07:45 +00:00
attachments cache 'false' values in adheres_to_policy 2015-06-22 15:58:28 +00:00
auditors add score and points_possible to grade_change live event 2016-06-30 18:19:19 +00:00
broadcast_policies don't send grade notifications to soft-concluded students 2016-05-16 12:29:12 +00:00
conditional_release add domain to cyoe jwt 2016-07-29 18:30:48 +00:00
content_migration conditional release content migration service 2016-08-02 15:11:13 +00:00
courses fix delayed alerts for courses with only section-limited teachers 2014-10-30 16:07:12 +00:00
discussion_topic don't autorequire a bunch of gems that are rarely used 2015-04-09 18:47:50 +00:00
enrollment show correct total activity time for users 2015-04-22 20:44:29 +00:00
epub_exports allow TAs to download course content epubs 2016-07-06 18:14:29 +00:00
exporters rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
group_categories rails 4.2: misc spec fixes 2016-01-18 21:45:39 +00:00
importers fix import issues when trying to import invalid items 2016-06-07 19:31:26 +00:00
incoming_mail link to community docs in unlinked channel bounce message 2016-03-29 15:49:19 +00:00
live_assessments rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
lti use the extracted lti security code 2016-06-08 18:16:19 +00:00
messages update email notification for peer review to be anonymous 2015-09-14 21:19:20 +00:00
moderated_grading fix anonymous moderated grading 2016-07-14 22:07:45 +00:00
page_view fix csv limit for pv4 page view csv report 2016-06-03 16:12:36 +00:00
polling remove non-draft-state everything 2014-12-10 17:57:18 +00:00
quizzes allow course admins without manage rights to preview quizzes 2016-08-02 12:47:16 +00:00
users add skip_registration param to create user action 2015-08-24 19:09:47 +00:00
wiki_pages some straggler includes 2015-09-03 15:42:38 +00:00
access_token_spec.rb use cached developer key from critical API request path 2016-04-18 18:14:19 +00:00
account_authorization_config_spec.rb federated attributes backend 2016-07-13 19:00:00 +00:00
account_notification_spec.rb Cache account notifications by sub account ids 2016-04-15 19:57:32 +00:00
account_spec.rb fix qualified names bug with Account#users_name_like 2016-07-27 16:15:32 +00:00
account_user_spec.rb new roles 2014-10-31 19:44:14 +00:00
active_record_base_spec.rb drop sis_source_id from enrollment 2016-05-16 19:13:45 +00:00
alert_spec.rb fix a syntax error with alerts looking up account roles 2015-05-04 22:11:40 +00:00
announcement_spec.rb fixes for :read_forum and :read_announcements permissions 2016-04-12 15:08:13 +00:00
appointment_group_spec.rb allow appointment groups in soft-concluded courses to be managed 2016-06-01 18:50:02 +00:00
assessment_question_bank_spec.rb turn on Timecop safe_mode, fixes SD-1019 2016-05-16 18:59:40 +00:00
assessment_question_spec.rb spec: eliminate ClonedItem dependency 2016-04-28 15:20:46 +00:00
assessment_request_spec.rb Show anonymous user on peer reviews when setting enabled 2015-07-08 21:18:45 +00:00
asset_user_access_spec.rb cache asset on asset_user_access 2016-06-16 12:20:20 +00:00
assignment_group_spec.rb send grading policy notifications to observers 2016-03-29 23:46:54 +00:00
assignment_override_spec.rb Fix duplicate entries for adhoc overrides in due dates hash 2016-06-24 22:21:45 +00:00
assignment_override_student_spec.rb create enrollment_states table 2016-06-27 13:56:02 +00:00
assignment_spec.rb make Download Submissions respect anonymous grading 2016-07-27 00:11:42 +00:00
assignment_student_visibility_spec.rb remove differentiated assignments feature checks 2016-03-07 18:44:46 +00:00
attachment_spec.rb preserve publishing state and usage rights when overwriting 2016-07-01 19:57:59 +00:00
big_blue_button_conference_spec.rb Canvas API to mark a web conference as having a prepared recording 2015-05-11 19:33:41 +00:00
bookmark_service_spec.rb Fix Diigo API Calls 2014-10-28 17:00:50 +00:00
bounce_notification_processor_spec.rb Ping statsd when bounce notifications are processed 2015-12-22 19:49:56 +00:00
brand_config_spec.rb Generate JSON file for brand configs 2016-05-04 19:18:28 +00:00
broadcast_policies_spec.rb Initial commit. 2011-01-31 18:57:29 -07:00
calendar_event_spec.rb send appointment group notifications to observers 2016-05-06 20:46:29 +00:00
canvadoc_spec.rb Include pdfjs in preferred_plugins array 2016-08-03 03:07:50 +00:00
cloned_item_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
collaboration_spec.rb do not add the same group to a collaboration multiple times 2016-07-12 22:41:29 +00:00
collaborator_spec.rb Spec: Add testrail ids to some notification specs 2015-12-03 17:28:04 +00:00
communication_channel_spec.rb rails 4.2: s/destroy!/destroy_permanently! 2016-01-07 14:00:13 +00:00
content_export_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
content_migration_spec.rb prevent multiple content_migrations from running at the same time 2016-03-16 15:20:45 +00:00
content_participation_count_spec.rb Decouple grades and comments in gradebook api 2016-06-15 22:17:17 +00:00
content_participation_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
content_tag_spec.rb publish files when publishing module 2015-09-30 00:09:42 +00:00
context_external_tool_spec.rb Do not generate LTI jwt tokens outside of the current context 2016-07-06 22:22:07 +00:00
context_module_progression_spec.rb require students to be active to complete requirements 2016-02-08 18:12:47 +00:00
context_module_spec.rb remove differentiated assignments feature checks 2016-03-07 18:44:46 +00:00
context_spec.rb make Context.get_account work with CourseSections 2016-01-18 21:08:51 +00:00
conversation_batch_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
conversation_message_participant_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
conversation_message_spec.rb Spec: Add testrail ids to some notification specs 2015-12-03 17:28:04 +00:00
conversation_participant_spec.rb prevent negative unread_conversation_counts 2016-06-28 14:01:28 +00:00
conversation_spec.rb remove closed and completed from groups 2016-06-16 22:24:25 +00:00
course_date_range_spec.rb adds due date validations to assignment quick add and quick edit 2015-03-19 16:29:43 +00:00
course_progress_spec.rb require students to be active to complete requirements 2016-02-08 18:12:47 +00:00
course_section_spec.rb Mark enrollments as deleted when their associated section is deleted 2015-08-24 19:49:14 +00:00
course_spec.rb Add image as an option for course settings hash 2016-07-27 15:15:14 +00:00
crocodoc_document_spec.rb revert the revert crocodoc permissions change 2016-01-04 20:01:55 +00:00
custom_data_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
delayed_message_spec.rb rip out more polymorphic shims 2016-01-11 17:40:03 +00:00
delayed_notification_spec.rb rip out more polymorphic shims 2016-01-11 17:40:03 +00:00
developer_key_spec.rb allow multiple redirect URIs 2016-07-28 01:07:58 +00:00
discussion_entry_spec.rb drop inbox_items 2016-03-23 16:02:17 +00:00
discussion_topic_participant_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
discussion_topic_spec.rb fix discussion topic permissions for unauthenticated users 2016-07-11 18:42:51 +00:00
enrollment_spec.rb create enrollment_states table 2016-06-27 13:56:02 +00:00
enrollment_state_spec.rb create enrollment_states table 2016-06-27 13:56:02 +00:00
enrollment_term_spec.rb associate grading period groups with root accounts 2016-07-01 20:15:56 +00:00
eportfolio_category_spec.rb Initial commit. 2011-01-31 18:57:29 -07:00
eportfolio_entry_spec.rb fixes timestamp on eportfolio page 2015-02-26 22:00:17 +00:00
eportfolio_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
epub_export_spec.rb make ePub export locale-aware 2016-05-13 21:31:18 +00:00
error_report_spec.rb don't allow overwriting certain ErrorReport fields 2015-12-07 21:04:25 +00:00
external_feed_spec.rb allow deleting external feeds that have created announcmenets 2015-02-11 21:45:05 +00:00
external_integration_key_spec.rb add type scope for external integration keys 2015-04-24 16:39:45 +00:00
external_tool_collaboration_spec.rb collaborations edit launch 2016-05-18 21:43:24 +00:00
feature_flag_spec.rb fix feature flag page error with hidden+root_opt_in 2016-05-16 17:01:25 +00:00
folder_spec.rb read-only submissions folder 2016-04-28 21:41:51 +00:00
general_model_spec.rb ensure strong_params flag is inherited 2016-03-04 00:49:51 +00:00
google_docs_collaboration_spec.rb Remove Google Docs plugin 2016-02-01 23:41:53 +00:00
gradebook_csv_spec.rb don't wait for failed gradebook csv exports 2015-12-04 21:43:49 +00:00
gradebook_upload_spec.rb gradebook importer files through S3 2016-02-05 16:06:02 +00:00
grading_period_grade_spec.rb associate grading period groups with root accounts 2016-07-01 20:15:56 +00:00
grading_period_group_spec.rb spec: add testRail associations 2016-07-19 22:50:49 +00:00
grading_period_permissions_spec.rb associate grading period groups with root accounts 2016-07-01 20:15:56 +00:00
grading_period_spec.rb spec: update weighted grading period api 2016-07-27 19:52:03 +00:00
grading_standard_spec.rb fix grading standard comparisons to use BigDecimals not floats 2016-04-21 17:57:50 +00:00
group_category_spec.rb fix cloned group set to not dup unique fields 2016-03-21 13:00:39 +00:00
group_leadership_spec.rb rails 4.2: s/destroy!/destroy_permanently! 2016-01-07 14:00:13 +00:00
group_membership_spec.rb suppress some notifications when a course is soft-concluded 2016-03-03 16:21:32 +00:00
group_spec.rb Add new collaborations feature flag 2016-05-23 20:30:47 +00:00
kaltura_media_file_handler_spec.rb use query string syntax for kaltura partner_data 2016-05-25 21:49:10 +00:00
learning_outcome_group_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
learning_outcome_result_spec.rb scale aggregate bank scores to parent outcome mastery 2016-05-04 16:06:42 +00:00
learning_outcome_spec.rb adjust outcome scores: decaying average and n_mastery rules 2016-01-27 23:48:23 +00:00
mailer_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
media_object_spec.rb remove JSON support from MediaObject.build_media_objects 2016-06-30 20:13:12 +00:00
media_source_fetcher_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
message_spec.rb spec: ensure we can have long subjects 2016-02-25 21:14:53 +00:00
notification_endpoint_spec.rb don't send to notification endpoints whose token has changed 2015-09-30 19:54:14 +00:00
notification_failure_processor_spec.rb clean up stale push notification endpoints 2016-06-09 20:25:13 +00:00
notification_finder_spec.rb gemify broadcast policy 2014-09-24 11:35:33 +00:00
notification_policy_spec.rb rails4.2: replace Relation#scoped 2015-12-30 18:42:04 +00:00
notification_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
notifier_spec.rb gemify broadcast policy 2014-09-24 11:35:33 +00:00
observer_enrollment_spec.rb don't auto-activate observer enrollments for unregistered users 2016-03-14 20:58:02 +00:00
page_view_spec.rb fix not-writing page views anywhere, but still work with PV4 2016-03-22 19:33:29 +00:00
plugin_setting_spec.rb spec: change a bunch of before(:all)s to before(:once) 2015-10-23 19:52:30 +00:00
profile_spec.rb expand "native" polymorphic associations to most polymorphics 2016-02-22 19:14:31 +00:00
progress_spec.rb rip out more polymorphic shims 2016-01-11 17:40:03 +00:00
pseudonym_spec.rb query unique_id as string 2016-06-18 03:54:33 +00:00
quiz_student_visibility_spec.rb remove differentiated assignments feature checks 2016-03-07 18:44:46 +00:00
role_override_spec.rb don't grant permissions to students for unpublished courses 2016-04-12 15:08:10 +00:00
role_spec.rb fix user enrollment create permissions 2015-03-24 19:31:25 +00:00
rubric_assessment_spec.rb migrate yaml in database into a psych compatible format 2016-02-25 20:07:15 +00:00
rubric_association_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
rubric_spec.rb fix change detection for imported rubrics 2016-03-19 00:23:01 +00:00
settings_spec.rb default settings values to strings 2015-05-07 21:24:54 +00:00
sharded_bookmarked_collection_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
shared_brand_config_spec.rb All of the stuff from the save_a_theme dev branch 2016-05-18 22:01:25 +00:00
sis_batch_spec.rb record deleted courses through full batch sis imports 2016-07-05 18:30:34 +00:00
sis_pseudonym_spec.rb pick sis pseudonym reliably 2015-06-25 22:18:14 +00:00
split_user_spec.rb handle attachments on user split 2016-07-08 17:24:11 +00:00
stream_item_instance_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
stream_item_spec.rb rip out more polymorphic shims 2016-01-11 17:40:03 +00:00
student_enrollment_spec.rb rails4: even more models spec fixes 2015-07-13 15:25:18 +00:00
student_view_enrollment_spec.rb rails4: even more models spec fixes 2015-07-13 15:25:18 +00:00
submission_comment_interaction_spec.rb fix teacher interaction report to work with submission comments 2015-02-06 18:54:59 +00:00
submission_comment_spec.rb autosave comments on navigating to different user in speedgrader 2016-07-14 21:51:55 +00:00
submission_spec.rb Add feature flag for canvadocs preferred plugin 2016-07-15 21:15:37 +00:00
submission_version_spec.rb switch yaml engine to psych 2016-04-22 16:51:15 +00:00
ta_enrollment_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
teacher_enrollment_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
usage_rights_spec.rb add new variable expansions for attachments 2015-02-19 17:12:38 +00:00
user_observer_spec.rb create linked_enrollments when restoring user_observers 2016-04-27 17:10:45 +00:00
user_profile_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
user_service_spec.rb Remove Google Docs plugin 2016-02-01 23:41:53 +00:00
user_spec.rb search common accounts more exhaustively for user permissions 2016-08-02 20:36:26 +00:00
web_conference_spec.rb don't treat manually-ended web conferences as active 2016-03-17 18:24:00 +00:00
web_conference_spec_helper.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00
wiki_page_spec.rb Add WikiPage assignment type 2016-04-21 17:25:15 +00:00
wiki_spec.rb don't grant access to wiki pages for public unpublished courses 2016-06-15 12:56:12 +00:00
wimba_conference_spec.rb rspec 3-ify spec/models 2014-10-14 20:10:03 +00:00