ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/spec/lib
History
Ryan Shaw a3342e5429 include siteadmin css/js always if set in newUI 
fixes: CNVS-30679

in new UI, if you had custom CSS/JS for siteadmin
theme, but you didn't create any themes for your
root accounts or child accounts. when you loaded
a page, it would not include the site admin's custom
css/js

test plan:

* make sure no brand configs are applied to the root
account or the sub account you are looking at
* create a theme for the site admin that has custom
  css/js.
* load a page
* it should include the css/js for that theme

this should have already worked, but good to confirm
that it still does:
* now, with that theme applied to site_admin,
  make a theme for your root and child accounts
  and give them some custom css/js too
* load a page
* it should include js/css from
    first, the site admin account
    second, the root account
    last, the child account

Change-Id: I65e676b9b015959995d205e949021ac1c7211381
Reviewed-on: https://gerrit.instructure.com/86544
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
 		2016-08-01 21:08:13 +00:00
..
api include siteadmin css/js always if set in newUI 2016-08-01 21:08:13 +00:00
app_center Rebuilt App Center in React 2015-01-05 21:34:02 +00:00
basic_lti Fix speedgrader LTI integration bugs 2016-06-27 22:19:11 +00:00
canvas Migrate wiki page assignment relationship in course copy 2016-07-18 19:23:54 +00:00
cc separate discussion topics and announcements in importers 2016-07-12 13:30:10 +00:00
data_fixup datafixup: set grading period close date to end date 2016-07-18 15:58:12 +00:00
ext rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
lti use the new ims lti message authenticator 2016-07-07 19:34:32 +00:00
messageable_user rails4.2: replace Relation#scoped 2015-12-30 18:42:04 +00:00
outcomes adjust outcome scores: decaying average and n_mastery rules 2016-01-27 23:48:23 +00:00
reporting be liberal in checked account namespace 2014-12-12 23:13:20 +00:00
services remove notification service load test setting 2016-05-02 15:32:16 +00:00
sis add course_format column to courses.csv SIS import 2016-08-01 14:50:55 +00:00
turnitin Create an error submission for turn it in errors 2016-03-08 23:26:41 +00:00
user_content add public_user_content helper 2016-07-27 15:08:42 +00:00
utils turn on Timecop safe_mode, fixes SD-1019 2016-05-16 18:59:40 +00:00
acts_as_list_spec.rb refactor views for unified AAC administration 2015-05-14 21:47:05 +00:00
api_spec.rb fix API links in headers 2016-06-20 18:48:26 +00:00
asset_signature_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
assignment_override_applicator_spec.rb Fix duplicate entries for adhoc overrides in due dates hash 2016-06-24 22:21:45 +00:00
authentication_methods_spec.rb refactor CSRF handling for clarity and rails3+ 2016-01-11 23:31:47 +00:00
basic_lti_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
brand_config_helpers_spec.rb theme editor for siteadmin 2016-07-12 22:02:04 +00:00
brand_config_regenerator_spec.rb theme editor for siteadmin 2016-07-12 22:02:04 +00:00
brandable_css_spec.rb include asset host in theme json files 2016-06-09 19:00:53 +00:00
canvas_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
content_notices_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
content_zipper_spec.rb display download submissions button on screenreader gradebook 2016-01-19 17:45:08 +00:00
course_link_validator_spec.rb don't flag url encoded wiki pages in course link validator 2016-02-22 17:41:49 +00:00
crummy_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
cuty_capt_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
dates_overridable_spec.rb create enrollment_states table 2016-06-27 13:56:02 +00:00
delayed_message_scrubber_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
differentiable_assignment_spec.rb remove differentiated assignments feature checks 2016-03-07 18:44:46 +00:00
due_date_cacher_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
email_address_validator_spec.rb SIS Import validates email address 2015-10-13 14:51:50 +00:00
ember_bundle_spec.rb rails4: use preload instead of includes for context associations 2015-07-08 13:03:29 +00:00
enrollments_from_user_list_spec.rb make batch user enrollment a bit easier on the database 2016-03-07 20:20:23 +00:00
external_feed_aggregator_spec.rb fix ExternalFeedAggregator with psych and atom 2016-03-15 17:18:14 +00:00
feature_flags_spec.rb refactor multiple grading periods code 2016-05-11 17:18:53 +00:00
feature_spec.rb spec: don't break feature definitions in feature_spec 2014-11-03 15:35:20 +00:00
file_in_context_spec.rb Properly escape filenames with slashes on local storage 2015-10-13 15:11:51 -07:00
grade_calculator_spec.rb recalculate grades when assignment group changes 2016-07-19 19:21:01 +00:00
gradebook_exporter_spec.rb associate grading period groups with root accounts 2016-07-01 20:15:56 +00:00
gradebook_importer_spec.rb associate grading period groups with root accounts 2016-07-01 20:15:56 +00:00
has_content_tags_spec.rb turn on Timecop safe_mode, fixes SD-1019 2016-05-16 18:59:40 +00:00
host_url_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
i18n_spec.rb fix locale fallbacks in JS land, fixes CNVS-29506, refs SD-71 2016-05-20 20:56:19 +00:00
i18n_time_zone_spec.rb rails 4.2: couple more fixes 2016-02-03 16:17:49 +00:00
imported_html_converter_spec.rb catch URI::Error instead of URI::InvalidURIError 2015-07-28 02:17:49 +00:00
locale_selection_spec.rb allow tagging custom locales 2016-04-04 15:04:34 +00:00
logging_filter_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
message_dispatcher_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
message_scrubber_spec.rb scrub old unsent messages 2015-12-11 22:36:30 +00:00
messageable_user_spec.rb quote table names in joins 2015-07-16 16:35:31 +00:00
model_cache_spec.rb spec: fix model pollution in general_model_spec 2016-02-09 17:34:16 +00:00
multi_cache_spec.rb remove rails 3 support 2015-12-23 21:36:43 +00:00
mutable_spec.rb don't perform mute/unmute side effects w/o change 2015-07-19 02:26:34 +00:00
notification_message_creator_spec.rb fix cross-shard summary message root accounts 2016-06-09 16:30:23 +00:00
password_policy_spec.rb limit passwords to 255 characters with canvas auth 2016-03-02 21:18:19 +00:00
progress_runner_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
safe_yaml_spec.rb fix plugin class yaml serialization/deserialization 2016-05-20 15:53:21 +00:00
sanitize_spec.rb A11y: Allow the insertion of MathML via the HTML editor 2016-06-27 15:30:37 +00:00
scope_filter_spec.rb rails4.2: replace Relation#scoped 2015-12-30 18:42:04 +00:00
security_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
sentry_proxy_spec.rb setup a generalized way to leave out errors from sentry reporting 2015-06-23 22:41:26 +00:00
sort_spec.rb spec: make sure test-queue workers don't bail on this spec 2016-03-05 04:33:05 +00:00
sorts_assignments_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
spec_helper_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
ssl_common_spec.rb make grade passback specs more robust 2014-03-06 15:23:50 +00:00
stats_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
sticky_sis_fields_spec.rb use prepend instead of alias_method_chain in SisStickiness 2015-06-16 19:54:30 +00:00
submission_list_spec.rb add excused assignment support to grading history 2015-07-14 15:14:53 +00:00
summary_message_consolidator_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
text_helper_spec.rb turn on Timecop safe_mode, fixes SD-1019 2016-05-16 18:59:40 +00:00
timed_cache_spec.rb fix timecop spec leaks 2015-02-04 19:36:16 +00:00
turnitin_spec.rb make Turnitin::Client#id shard aware 2015-10-07 20:57:02 +00:00
unzip_attachment_spec.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00
user_content_spec.rb stop stripping alt tag when generating mathml 2015-12-14 17:08:47 +00:00
user_list_spec.rb don't allow non-site admins to add site admins to courses/accounts 2016-03-24 00:20:53 +00:00
user_merge_spec.rb don't delete conflicting enrollments on user merge 2016-03-30 16:45:01 +00:00
user_search_spec.rb fix performance regression on course users api endpoint 2016-07-07 15:51:44 +00:00
validates_as_url.rb rspec 3-ify spec/lib 2014-10-14 20:47:42 +00:00