![]() closes: CNVS-18168 also fixes semantics so: 1. if you press "esc" to close the dialog (instead of pressing the "cancel" button) it does not throw a js "can't call method preventDefaut on null" 2. uses a <button type="submit"> so that when you are on any input element in the form and you hit "enter" it will submit the form, as is standard. test plan: open styleguide open the react-modal example make sure it works Change-Id: I6b1a8b6c757ef8205a59af17bde8743ce24e0dc5 Reviewed-on: https://gerrit.instructure.com/47745 Tested-by: Jenkins Reviewed-by: Matt Zabriskie <mzabriskie@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> QA-Review: August Thornton <august@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> |
||
---|---|---|
.. | ||
ReactModalExample.jsx |