ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/lib/data_fixup
History
Cameron Ray 0dd4aec595 assignment_group rules 
prevent decimal ignore rules from being added to
assignment_groups

Test plan:
 - As a teacher
 - In the Assignment Groups edit modal
 - Enter a non-integer value to 'Lowest Scores'
 - Click save
 - Should show error
 - Enter a non-integer value to 'Highest Scores'
 - Should show error

Refs EVAL-2720

flag=none

Change-Id: I51b86da6c0692231c1d7a6f28dbdeaf1dd1aac5f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304051
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Migration-Review: Isaac Moore <isaac.moore@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
 		2022-11-16 21:22:18 +00:00
..
granular_permissions Stop leaking siteadmin ids from spec setup 2022-02-25 23:11:11 +00:00
lti replace settings.use_1_3 with lti_version: 1.3 2022-08-23 18:14:00 +00:00
add_beta_domain_to_outcomes_service.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
add_lti_id_to_users.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
add_manage_account_banks_permission_to_quiz_lti_tools.rb datafix manage_account_bank permission field on Quiz LTI tools 2021-10-08 17:55:00 +00:00
add_new_default_report.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
add_post_policies_to_assignments.rb RuboCop: heredocs 2021-11-16 06:36:00 +00:00
add_rcs_app_host_to_quiz_lti_tools.rb Add rcs_host custom field on Quiz LTI tools 2022-09-05 11:16:36 +00:00
add_rcs_service_jwt_to_quiz_lti_tools.rb Add rcs_service_jwt custom field on Quiz LTI tools 2022-09-28 08:24:36 +00:00
add_role_overrides_for_new_permission.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
add_tool_proxy_to_message_handler.rb add # frozen_string_literal: true for lib 2020-10-27 20:49:50 +00:00
add_user_uuid_to_learning_outcome_results.rb RuboCop: heredocs 2021-11-16 06:36:00 +00:00
back_fill_permanent_expires_at.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
backfill_dev_key_account_bindings.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
backfill_dev_key_account_bindings_for_deleted_keys.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
backfill_dummy_root_account_id_on_folders.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
backfill_moderation_graders.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
backfill_new_default_help_link.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
backfill_nulls.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
backfill_posted_at_on_submissions.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
change_immersive_reader_allowed_on_to_on.rb Stop leaking siteadmin ids from spec setup 2022-02-25 23:11:11 +00:00
cleanup_cross_shard_developer_keys.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
cleanup_invalid_assignment_group_rules.rb assignment_group rules 2022-11-16 21:22:18 +00:00
clear_account_settings.rb clear account sms overrides 2021-08-31 19:12:00 +00:00
clear_feature_flags.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
clear_old_communication_channel_root_account_ids.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
clear_old_user_root_account_ids.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
copy_big_blue_button_settings.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
copy_built_in_roles_by_root_account.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
copy_role_overrides.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
create_lti_links_for_legacy_lti_tool_settings.rb RuboCop: Lint/UselessAssignment app, config, doc, gems, lib 2021-10-27 15:36:29 +00:00
create_quiz_lti_navigation_placements.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
create_subscriptions_for_plagiarism_tools.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
delete_duplicate_rows.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
delete_empty_adhoc_assignment_overrides.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
delete_empty_progressions.rb convert a few more places to .in_batches.delete_all 2021-08-19 19:38:03 +00:00
delete_extra_placeholder_submissions.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
delete_invalid_communication_channels.rb RuboCop: Style/NumericLiterals 2021-11-24 23:31:34 +00:00
delete_scores_for_assignment_groups.rb Revert "Revert "re-implement in_batches and friends"" 2021-07-06 19:54:25 +00:00
fix_assignment_peer_review_jobs.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
fix_discussion_topic_materialized_views.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
fix_grader_visibility_data.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
fix_nan_group_weights.rb add # frozen_string_literal: true for lib 2020-10-27 20:49:50 +00:00
fix_overwritten_file_module_items.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
fix_planner_overrides_marked_complete_data.rb add # frozen_string_literal: true for lib 2020-10-27 20:49:50 +00:00
fix_points_possible_sums_in_quizzes.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
fix_reinserted_verifier_question_yaml.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
fix_resource_links_from_copied_courses.rb Prefer a Resource link's own url in export 2022-07-27 19:07:59 +00:00
fix_resource_links_from_copied_courses_null_urls.rb fixup more broken course copied resource links 2022-08-03 21:34:44 +00:00
fix_select_final_grade_for_existing_accounts.rb Stop leaking siteadmin ids from spec setup 2022-02-25 23:11:11 +00:00
fixup_group_originality_reports.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
flag_eportfolios_on_empty_users.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
import_instfs_attachments.rb RuboCop: Style/RedundantFreeze 2021-11-11 02:06:47 +00:00
init_account_index_for_course_audit_log.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
init_new_grade_history_audit_log_indexes.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
initialize_submission_cached_due_date.rb add # frozen_string_literal: true for lib 2020-10-27 20:49:50 +00:00
invalidate_built_in_role_caches.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
migrate_homeroom_settings_to_columns.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
migrate_messages_to_partitions.rb RuboCop: Style/RedundantSelf 2021-11-20 16:41:21 +00:00
move_feature_flags_to_settings.rb Some rails 7 tests passing 2022-06-06 14:23:03 +00:00
move_master_import_results.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
move_rce_favorites_to_account_settings.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
move_sub_account_grading_periods_to_courses.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
populate_account_report_date_times.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
populate_context_on_outcome_proficiencies.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
populate_context_on_wiki_pages.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
populate_conversation_participant_private_hash.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
populate_course_id_on_submissions.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
populate_field_on_model_from_association.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
populate_identity_hash_on_context_external_tools.rb Improve performance on backfill identity hash 2022-02-07 23:54:32 +00:00
populate_last_comment_at_on_submissions.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
populate_media_tracks_web_vtt_content.rb add # frozen_string_literal: true for lib 2020-10-27 20:49:50 +00:00
populate_missing_root_account_ids_if_single_root_account_install.rb Stop leaking siteadmin ids from spec setup 2022-02-25 23:11:11 +00:00
populate_points_for_all_scores.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
populate_root_account_id_for_assignments.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
populate_root_account_id_for_enrollment_dates_overrides.rb backfill root_account_id for enrollment_dates_overrides 2022-10-20 20:06:15 +00:00
populate_root_account_id_for_group_categories.rb add # frozen_string_literal: true for lib 2020-10-27 20:49:50 +00:00
populate_root_account_id_on_asset_user_accesses.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
populate_root_account_id_on_attachments.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
populate_root_account_id_on_calendar_events.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
populate_root_account_id_on_models.rb add enrollment_dates_overrides root account association and infer defaults 2022-10-20 16:53:08 +00:00
populate_root_account_id_on_user_observers.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
populate_root_account_ids_on_communication_channels.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
populate_root_account_ids_on_conversations_tables.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
populate_root_account_ids_on_learning_outcomes.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
populate_root_account_ids_on_users.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
populate_scores_and_metadata_for_assignment_groups_and_teacher_view.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
populate_scores_course_score.rb Revert "Revert "re-implement in_batches and friends"" 2021-07-06 19:54:25 +00:00
populate_submission_anonymous_ids.rb add # frozen_string_literal: true for lib 2020-10-27 20:49:50 +00:00
reassociate_grading_period_groups.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
rebuild_quiz_submissions_from_quiz_submission_events.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
rebuild_quiz_submissions_from_quiz_submission_versions.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
reclaim_instfs_attachments.rb RuboCop: Style/CommentAnnotation 2021-11-21 00:50:46 +00:00
reinsert_assessment_question_file_verifiers.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
remove_invalid_assignment_overrides.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
remove_invalid_course_pace_module_items.rb Fix non-paceable content tags being updated/created 2022-11-08 19:36:22 +00:00
remove_invalid_locales.rb data fixup for removing invalid locales 2022-03-23 14:55:53 +00:00
remove_orphaned_assignment_override_students.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
resend_plagiarism_events.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
run_due_date_cacher_for_quiz_lti.rb make datafixup classes zeitwerk compatible 2021-10-08 12:57:11 +00:00
run_update_course_score_statistic.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
run_update_score_statistics.rb Improve score details and grade statistics 2022-07-20 13:24:01 +00:00
set_account_setting_enable_turnitin.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
set_actl_context_type_for_course_level_tool_proxies.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
set_existing_binding_state.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
set_lti_line_items_coupled.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
set_navigation_placement_settings_for_quiz_lti_tools.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
set_posting_notification_frequency.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
split_up_user_preferences.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00
turn_off_anonymous_grading_for_discussion_topics_and_quizzes.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
update_anonymous_grading_settings.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
update_developer_key_access_token_counts.rb add # frozen_string_literal: true for lib 2020-10-27 20:49:50 +00:00
update_developer_key_scopes.rb Clean up duplicate subscription creation code 2022-10-27 18:18:32 +00:00
update_grading_standards_to_full_range.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
update_mastery_connect_tool_config.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
validate_assignment_overrides.rb RuboCop: Style/HashSyntax 2021-11-25 14:02:35 +00:00