c856299406
refs INTEROP-7258
flag=none
These can exist when exporting a course where there are
Lti::ResourceLinks whose current_external_tool is an LTI 1.1 tool
without a URL. A future commit will prevent ResourceLinks with no URL
from appearing in an export, but since people already have export files
with these LRLs without URLs, we should fix it to not crash the import.
Test plan:
- Have a course with some resource links (e.g. create an LTI 1.3
assignmentor use deep linking in RCE in the syllabus, when editing an
assignment body, etc.)
- Create an LTI 1.1 tool without a URL (but with a domain) in the course
or account.
- In a Rails console, change the context_external_tool_id of the
Lti::ResourceLink to point to the LTI 1.1 tool with no URL.
- Export the course. Check in the resulting imscc file (actually a zip
file) that there is a file in lti_resource_links/ that does not have a
launch_url or secure_launch_url.
- Import the course content in some course. The import should succeed.
- In a rails console lookup resource links with the same lookup_uuid as
the one pointing to an LTI 1.1 tool to make sure no resource links
were created by the import:
Lti::ResourceLinks.where(lookup_uuid:
lrl_pointing_to_11tool.lookup_uuid)
Change-Id: I420929b2d291d551f43bd2189a48cb911971e1cf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/285477
Product-Review: Evan Battaglia <ebattaglia@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
|
||
|---|---|---|
| .. | ||
| asset_files | ||
| data_generation | ||
| docs | ||
| exporter | ||
| files | ||
| gradebooks | ||
| importer | ||
| lti | ||
| migration | ||
| sis | ||
| 100mpx.png | ||
| alphabet_soup.zip | ||
| attachments.zip | ||
| bounces.json | ||
| courses.yml | ||
| file_mail.txt | ||
| html_mail.txt | ||
| huge_zip.zip | ||
| mail.txt | ||
| message_1.txt | ||
| message_2.txt | ||
| message_3.txt | ||
| multipart-request | ||
| selection_test_lti.xml | ||
| submissions.zip | ||
| test.js | ||
| test.xsd | ||
| test_image.jpg | ||
| tilde.zip | ||
| zip_with_long_filename_inside.zip | ||
| zipbomb.zip | ||
