canvas-lms/lib
Cody Cutrer d37a8066b5 RuboCop: Rails grab bag
[skip-stages=Flakey]

see .rubocop.common.yml for list of cops applied

auto-corrected

Change-Id: I1a7309395a3bdb0d074b9af3a0ce5d6c0143fe67
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279005
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-19 22:47:08 +00:00
..
active_record RuboCop: Performance/MapCompact 2021-11-16 16:20:07 +00:00
active_support RuboCop: Style/IdenticalConditionalBranches 2021-11-19 22:34:16 +00:00
address_book RuboCop: Style/InverseMethods 2021-11-18 21:37:28 +00:00
api RuboCop: Style/CaseEquality 2021-11-19 22:42:08 +00:00
app_center RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
authentication_methods move inst_access to gem 2021-11-05 19:47:46 +00:00
basic_lti RuboCop: Style/MethodCallWithoutArgsParentheses 2021-11-18 23:07:30 +00:00
canvadocs RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
canvas RuboCop: Rails grab bag 2021-11-19 22:47:08 +00:00
cc RuboCop: Style/ClassCheck, Style/ClassEqualityComparison 2021-11-19 22:39:31 +00:00
cdc_migration_testing RuboCop: Style/TrailingCommaInArguments 2021-11-19 22:22:20 +00:00
data_fixup RuboCop: Style/IdenticalConditionalBranches 2021-11-19 22:34:16 +00:00
external_auth_observation external auth observation zeitwerk compatibility 2021-10-07 22:35:20 +00:00
feature_flags RuboCop: Rails/FilePath 2021-11-17 20:03:07 +00:00
global_lookups make globalLookups a module to extend, not a stub 2021-10-26 14:58:27 +00:00
gradebook RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
latex RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
lti RuboCop: Rails/Delegate 2021-11-19 22:42:26 +00:00
message_bus RuboCop: Style/RescueStandardError 2021-11-18 01:28:36 +00:00
messageable_user RuboCop: Style/ExplicitBlockArgument 2021-11-17 20:04:02 +00:00
microsoft_sync RuboCop: Style/TrailingCommaInArguments 2021-11-19 22:22:20 +00:00
migration_helpers RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
outcomes RuboCop: Style/TrailingCommaInArguments 2021-11-19 22:22:20 +00:00
rake RuboCop: Style/SignalException 2021-11-19 22:24:25 +00:00
reporting RuboCop: Style/AndOr, Style/Not 2021-11-19 22:22:35 +00:00
schemas add module_index_menu_modal placement 2021-11-16 21:00:04 +00:00
services RuboCop: Naming/RescuedExceptionsVariableName 2021-11-18 02:24:17 +00:00
sis RuboCop: Style/AndOr, Style/Not 2021-11-19 22:22:35 +00:00
support_helpers RuboCop: Naming/RescuedExceptionsVariableName 2021-11-18 02:24:17 +00:00
tasks RuboCop: Style/CaseEquality 2021-11-19 22:42:08 +00:00
turnitin RuboCop: Style/SignalException 2021-11-19 22:24:25 +00:00
user_content RuboCop: Rails/DynamicFindBy 2021-11-17 20:00:54 +00:00
utils RuboCop: Style/RedundantReturn 2021-11-12 16:33:45 +00:00
account_services.rb RuboCop: Lint/UnusedMethodArgument lib 2021-10-27 15:54:27 +00:00
address_book.rb RuboCop: Style/RedundantReturn 2021-11-12 16:33:45 +00:00
anonymity.rb RuboCop: Lint 2021-11-09 21:42:31 +00:00
api.rb RuboCop: Style/HashEachMethods 2021-11-19 22:29:07 +00:00
api_route_set.rb RuboCop: Style/RedundantRegexpCharacterClass 2021-11-18 02:08:52 +00:00
api_scope_mapper_fallback.rb Fix flakey spec 2021-11-12 23:36:55 +00:00
asset_signature.rb RuboCop: Lint/IneffectiveAccessModifier 2021-11-08 15:50:15 +00:00
assignment_override_applicator.rb RuboCop: Style/CaseEquality 2021-11-19 22:42:08 +00:00
assignment_util.rb RuboCop: Lint/UnusedMethodArgument lib 2021-10-27 15:54:27 +00:00
authentication_methods.rb RuboCop: Rails grab bag 2021-11-19 22:47:08 +00:00
basic_lti.rb add # frozen_string_literal: true for lib 2020-10-27 20:49:50 +00:00
brand_config_helpers.rb preload parent and root account associations when loading account chain 2021-08-05 18:53:42 +00:00
brand_config_regenerator.rb RuboCop: Lint/UselessAssignment app, config, doc, gems, lib 2021-10-27 15:36:29 +00:00
brandable_css.rb RuboCop: Style/RegexpLiteral 2021-11-18 02:08:34 +00:00
browser_support.rb RuboCop: Style/ExpandPathArguments 2021-11-17 22:06:59 +00:00
canvadocs.rb RuboCop: Style/TrailingCommaInArguments 2021-11-19 22:22:20 +00:00
canvas.rb RuboCop: Style/RaiseArgs 2021-11-19 22:22:51 +00:00
canvas_cache_init.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
canvas_logger.rb RuboCop: Performance/RedundantBlockCall 2021-11-17 20:03:24 +00:00
cc.rb Initial work on getting zeitwerk loader running 2021-03-16 19:55:12 +00:00
content_licenses.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
content_notices.rb RuboCop: Style/MutableConstant 2021-11-16 16:19:54 +00:00
content_zipper.rb RuboCop: Style/RegexpLiteral 2021-11-18 02:08:34 +00:00
conversation_batch_scrubber.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
conversation_helper.rb avoid usage of Shard#activate! 2021-10-06 15:19:03 +00:00
copy_authorized_links.rb RuboCop: Lint 2021-11-09 21:42:31 +00:00
course_link_validator.rb RuboCop: Style/CaseEquality 2021-11-19 22:42:08 +00:00
csv_with_i18n.rb RuboCop: Style/RedundantFreeze 2021-11-11 02:06:47 +00:00
custom_validations.rb RuboCop: Style/PercentLiteralDelimiters 2021-11-18 23:05:50 +00:00
cuty_capt.rb RuboCop: Style/MutableConstant 2021-11-16 16:19:54 +00:00
dates_overridable.rb RuboCop: Performance/RedundantMerge 2021-11-16 16:35:34 +00:00
delayed_message_scrubber.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
delicious.rb RuboCop: Style/RedundantReturn 2021-11-12 16:33:45 +00:00
differentiable_assignment.rb RuboCop: Performance/RedundantBlockCall 2021-11-17 20:03:24 +00:00
due_date_cacher.rb RuboCop: heredocs 2021-11-16 06:36:00 +00:00
dump_helper.rb RuboCop: Style/CaseLikeIf 2021-11-12 20:24:23 +00:00
duplicating_objects.rb RuboCop: Performance/StringReplacement 2021-11-11 22:00:48 +00:00
effective_due_dates.rb RuboCop: heredocs 2021-11-16 06:36:00 +00:00
email_address_validator.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
enrollments_from_user_list.rb RuboCop: Style/PreferredHashMethods 2021-11-12 16:24:14 +00:00
eportfolio_page.rb set SECTION_COUNT_IDX before layout and templates are rendered 2021-11-12 16:55:14 +00:00
external_feed_aggregator.rb RuboCop: Style/RedundantBegin 2021-11-11 02:19:27 +00:00
external_statuses.rb RuboCop: Style/MutableConstant 2021-11-16 16:19:54 +00:00
feature.rb RuboCop: Style/PercentLiteralDelimiters 2021-11-18 23:05:50 +00:00
feature_flags.rb RuboCop: Lint 2021-09-29 03:38:23 +00:00
file_authenticator.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
file_in_context.rb RuboCop: Style/SafeNavigation 2021-11-16 06:36:38 +00:00
file_splitter.rb RuboCop: Style/ExplicitBlockArgument 2021-11-17 20:04:02 +00:00
global_lookups.rb make globalLookups a module to extend, not a stub 2021-10-26 14:58:27 +00:00
google_analytics_dimensions.rb RuboCop: Style/RedundantArgument 2021-11-18 21:38:20 +00:00
google_docs_preview.rb RuboCop: Style/PercentLiteralDelimiters 2021-11-18 23:05:50 +00:00
grade_calculator.rb RuboCop: Performance/RedundantBlockCall 2021-11-17 20:03:24 +00:00
gradebook_exporter.rb RuboCop: Style/MutableConstant 2021-11-16 16:19:54 +00:00
gradebook_grading_period_assignments.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
gradebook_importer.rb RuboCop: Style/MethodCallWithoutArgsParentheses 2021-11-18 23:07:30 +00:00
gradebook_settings_helpers.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
gradebook_user_ids.rb RuboCop: Rails/WhereExists 2021-11-16 21:19:43 +00:00
grading_period_helper.rb RuboCop: Style/RedundantSort 2021-11-19 22:25:07 +00:00
has_content_tags.rb RuboCop: Style/PercentLiteralDelimiters 2021-11-18 23:05:50 +00:00
host_url.rb RuboCop: Style/PreferredHashMethods 2021-11-12 16:24:14 +00:00
i18n_time_zone.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
imported_html_converter.rb RuboCop: Style/MutableConstant 2021-11-16 16:19:54 +00:00
inst_fs.rb RuboCop: Style/ClassCheck, Style/ClassEqualityComparison 2021-11-19 22:39:31 +00:00
late_policy_applicator.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
latex.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
lazy_presumptuous_i18n_backend.rb Fix locale loading in deployed envs 2021-11-09 20:08:48 +00:00
learning_outcome_context.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
local_cache.rb RuboCop: Style/ConditionalAssignment 2021-11-11 17:39:06 +00:00
locale_selection.rb RuboCop: Style/HashEachMethods 2021-11-19 22:29:07 +00:00
locked_for.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
logging_filter.rb RuboCop: Style/RegexpLiteral 2021-11-18 02:08:34 +00:00
login_hooks.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
math_man.rb Make typeset math and math image match 2021-11-09 19:28:42 +00:00
message_bus.rb RuboCop: Style/MethodCallWithoutArgsParentheses 2021-11-18 23:07:30 +00:00
message_dispatcher.rb RuboCop: Lint/IneffectiveAccessModifier 2021-11-08 15:50:15 +00:00
message_scrubber.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
messageable_user.rb RuboCop: heredocs 2021-11-16 06:36:00 +00:00
missing_policy_applicator.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
model_cache.rb RuboCop: Style/HashEachMethods 2021-11-19 22:29:07 +00:00
moderation.rb add # frozen_string_literal: true for lib 2020-10-27 20:49:50 +00:00
multi_cache.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
must_view_module_progressor.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
mutable.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
net_ldap_extensions.rb wrap net_ldap_extensions in a zeitwerk compatible module 2021-10-07 18:50:58 +00:00
notification_message_creator.rb RuboCop: Style/NilComparison, Style/NonNilCheck 2021-11-19 22:38:10 +00:00
open_object.rb RuboCop: Style/CaseLikeIf 2021-11-12 20:24:23 +00:00
pace_plan_due_dates_calculator.rb Add pace plans publish endpoint 2021-10-12 22:08:36 +00:00
pace_plan_hard_end_date_compressor.rb RuboCop: Style/TrailingCommaInArguments 2021-11-19 22:22:20 +00:00
pace_plans_date_helpers.rb Add hard end dates compression 2021-11-18 19:10:40 +00:00
package_root.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
permissions.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
permissions_helper.rb RuboCop: Performance/InefficientHashSearch 2021-11-16 16:45:20 +00:00
plannable.rb RuboCop: Style/CaseLikeIf 2021-11-12 20:24:23 +00:00
planner_api_helper.rb RuboCop: Performance/RegexpMatch 2021-11-11 22:02:06 +00:00
planner_helper.rb RuboCop: Lint/IneffectiveAccessModifier 2021-11-08 15:50:15 +00:00
progress_runner.rb RuboCop: Performance 2021-11-17 20:03:38 +00:00
pronouns.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
quiz_math_data_fixup.rb RuboCop: Style/ZeroLengthPredicate 2021-11-18 23:07:03 +00:00
request_cache.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
request_error.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
rubric_context.rb RuboCop: Style/RedundantReturn 2021-11-12 16:33:45 +00:00
scope_filter.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
score_statistics_generator.rb RuboCop: Performance/Sum 2021-11-16 17:10:38 +00:00
scrypt_provider.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
search_term_helper.rb RuboCop: Style/ConditionalAssignment 2021-11-11 17:39:06 +00:00
send_to_stream.rb RuboCop: Performance/MapCompact 2021-11-16 16:20:07 +00:00
sentry_proxy.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
session_token.rb RuboCop: Style/RedundantReturn 2021-11-12 16:33:45 +00:00
simple_stats.rb RuboCop: Performance/Sum 2021-11-16 17:10:38 +00:00
simple_tags.rb RuboCop: Style/EachWithObject 2021-11-18 21:37:54 +00:00
sis.rb do away with non-conventional "common" module 2021-10-07 21:55:24 +00:00
sorts_assignments.rb RuboCop: Style/NilComparison, Style/NonNilCheck 2021-11-19 22:38:10 +00:00
ssl_common.rb RuboCop: Performance/Casecmp 2021-11-16 16:45:36 +00:00
stats.rb RuboCop: Style/ZeroLengthPredicate 2021-11-18 23:07:03 +00:00
sticky_sis_fields.rb RuboCop: Style/ExplicitBlockArgument 2021-11-17 20:04:02 +00:00
submission_list.rb RuboCop: Style/EachWithObject 2021-11-18 21:37:54 +00:00
submission_search.rb RuboCop: Style/RedundantAssignment 2021-11-11 17:39:20 +00:00
submittable.rb RuboCop: Style/EachWithObject 2021-11-18 21:37:54 +00:00
submittables_grading_period_protection.rb RuboCop: Style/InverseMethods 2021-11-18 21:37:28 +00:00
summary_message_consolidator.rb RuboCop: Style/SelfAssignment 2021-11-17 20:01:07 +00:00
syslog_wrapper.rb RuboCop: Style/MutableConstant 2021-11-16 16:19:54 +00:00
temp_cache.rb RuboCop: Style/PreferredHashMethods 2021-11-12 16:24:14 +00:00
text_helper.rb RuboCop: Style/IdenticalConditionalBranches 2021-11-19 22:34:16 +00:00
time_zone_helper.rb RuboCop: Style/HashConversion 2021-11-17 15:17:51 +00:00
timed_cache.rb RuboCop: Style/MethodCallWithoutArgsParentheses 2021-11-18 23:07:30 +00:00
token_scopes.rb RuboCop: Style/RegexpLiteral 2021-11-18 02:08:34 +00:00
token_scopes_helper.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
turnitin.rb RuboCop: Style/WhenThen, Style/MultilineWhenThen 2021-11-19 22:38:24 +00:00
turnitin_id.rb add # frozen_string_literal: true for lib 2020-10-27 20:49:50 +00:00
unzip_attachment.rb RuboCop: Style/MethodCallWithoutArgsParentheses 2021-11-18 23:07:30 +00:00
user_content.rb RuboCop: Style/StructInheritance 2021-11-19 22:38:42 +00:00
user_list.rb RuboCop: Style/AndOr, Style/Not 2021-11-19 22:22:35 +00:00
user_list_v2.rb RuboCop: Style/PercentLiteralDelimiters 2021-11-18 23:05:50 +00:00
user_merge.rb RuboCop: Style/MethodCallWithoutArgsParentheses 2021-11-18 23:07:30 +00:00
user_search.rb RuboCop: Rails/WhereEquals 2021-11-16 21:19:56 +00:00
uuid_helper.rb RuboCop: Style/MutableConstant 2021-11-16 16:19:54 +00:00
vericite.rb RuboCop: Style/NilComparison, Style/NonNilCheck 2021-11-19 22:38:10 +00:00
visibility_plucking_helper.rb RuboCop: Style/HashConversion 2021-11-17 15:17:51 +00:00
zip_extractor.rb RuboCop: Style/SafeNavigation 2021-11-16 06:36:38 +00:00