ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/spec
History
Evan Battaglia 74bc1c72bc MSFT Sync: clarify if owners don't have MS users 
Give less confusing error when course owners do not have Microsoft users
associated with them. This has happened locally and been confusing, but
it will also give us a heads up if, for real customers, the way of
linking a Canvas user to Microsoft user is not working how they expect.

refs INTEROP-6556
flag=microsoft_group_enrollments_syncing

Test plan:
- Have a course with teachers but no users which correspond to users
  in our test tenant,
- Run the sync. It should fail with an error saying 'A Microsoft 365
  Group must have owners, and no users to the instructors of the Canvas
  course could be found on the Microsoft side'. This can be seen on the
  MicrosoftGroup in the last_error field.
- Run a full sync with valid teachers just to make sure it still works.

Change-Id: I9a8c4f4421d04ed4c17e541fffb2ce69154c9cdb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/263263
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Evan Battaglia <ebattaglia@instructure.com>
 		2021-04-21 22:47:12 +00:00
..
apis add support for 'student_annotation' for submissions api 2021-04-21 15:30:49 +00:00
coffeescripts Fix: Sub type suggestion not working 2021-04-19 21:48:37 +00:00
contracts retire import_to_quizzes_next FF 2021-04-05 14:39:23 +00:00
controllers Modify index and show views for K5 mode 2021-04-21 18:21:41 +00:00
factories add comment_bank_item type to graphql 2021-04-20 18:57:56 +00:00
factory_bot add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
fixtures Use secure launch URL when present on link import 2021-03-17 23:06:21 +00:00
formatters add frozen_string_literal commment to spec stragglers 2021-03-30 15:31:24 +00:00
gem_integration/canvas_connect add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
graphql don't return counts for non root_entries 2021-04-21 20:13:48 +00:00
helpers Show due date for differentiated assignments in Speedgrader 2021-04-20 23:25:50 +00:00
initializers fix reversible (`change`) migrations with if_exists/if_not_exists 2021-04-09 17:14:49 +00:00
instfs/selenium add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
integration Revert "detect client's disconnecting during requests" 2021-04-15 20:44:09 +00:00
javascripts allow external tools to toggle course nav 2021-04-21 18:31:19 +00:00
lib MSFT Sync: clarify if owners don't have MS users 2021-04-21 22:47:12 +00:00
manual_seeding add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
messages use root_account in enrollment reg. message 2021-04-06 18:17:05 +00:00
migrations add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
models Add button to schedule MSFT sync 2021-04-20 20:44:28 +00:00
observers revert overridden_requirements_met in course completion live events 2021-03-10 23:20:49 +00:00
presenters Fixes unposted message for unpublished assignments 2021-03-17 18:55:16 +00:00
requests Fix url to speedgrader guide 2021-04-02 14:28:09 +00:00
schemas/lti add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
selenium spec: skip flakey specs for now 2021-04-20 20:35:52 +00:00
serializers part 3: change lookup_id and resource_link_id to UUID datatype 2021-02-11 18:02:20 +00:00
shared_examples remove reassign_assignments feature flag 2021-03-24 21:14:24 +00:00
support add migration claim to LTI 1.3 launches 2021-04-14 19:34:24 +00:00
views add student annotation assignments to course statistics 2021-04-20 16:48:38 +00:00
.eslintrc
…
.rspec_parallel use parallel_tests for more parallelization 2020-03-30 21:38:47 +00:00
ams_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
axe_selenium_helper.rb spec: tweak axe-selenium a11y rules 2021-03-22 22:48:33 +00:00
broadcast_integration.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
cassandra_spec_helper.rb move database_builder to canvas_cassandra 2021-02-25 15:19:20 +00:00
conditional_release_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
coverage_tool.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
factories.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
factory_bot_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
feature_flag_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
file_upload_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
force_failure_spec.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
import_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
jspec.sh
…
lti2_course_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
lti2_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
lti_1_3_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
lti_1_3_tool_configuration_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
lti_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
plagiarism_platform_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
quiz_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
rcov.opts
…
rspec_mock_extensions.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
sharding_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
simple_cov_result_merger.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
spec.opts remove abort_on_consistent_badness_formatter 2020-10-13 18:10:04 +00:00
spec_helper.rb ensure MultiCache has a TTL, even if falling back 2021-04-05 19:57:34 +00:00