ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/client_apps
History
Ryan Shaw ba2680a62e Fix gerrit-builder by s/const/var in quiz-stats 
the quizzes client apps have their own build
process and don’t pass things through babel.
which means that things like ‘let’ or ‘const’
pass through undetected. Which means this
file has not worked in ie11/safari for a long
time now.

The bug was caught because an updated version of 
UglifyJS noticed the const and said “hey, that’s
Not valid es5 code”.

That passed Jenkins because it runs its tests
without uglifying the code so uglify didn’t error out on it.

Test plan:
* open quiz-stats & quiz-events page in safari 9 or ie11, 
  it should work with no js errors
* the gerrit-builder Jenkins build for this commit should pass

Change-Id: I3d0607e0d72ee32b827e5fd6fde7744e39a7e26a
Reviewed-on: https://gerrit.instructure.com/123201
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins
 		2017-08-18 04:45:24 +00:00
..
canvas_quizzes Fix gerrit-builder by s/const/var in quiz-stats 2017-08-18 04:45:24 +00:00
README client app: canvas_quiz_statistics 2014-08-19 20:09:21 +00:00

README 

# --------------------------------------------------------------------------- #
# TOTALLY EXPERIMENTAL. DO NOT TOUCH. TOTALLY EXPERIMENTAL.
# --------------------------------------------------------------------------- #

Yes.