ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/spec/models
History
Brian Palmer 69d9f0262d don't create a new external_tool_tag on assignment update 
Not only is this unnecessary, but worse it changes the assignment's
resource_link_id, messing up any LTI tools that rely on that
parameter.

fixes CNVS-5884

test plan: Create an LTI assignment using any tool, and inspect the html
to view the launch parameters. Record the resource_link_id. Then edit
and save the assignment, and inspect the launch parameters again. The
resource_link_id should remain the same.

Change-Id: Ib2adcff90474cbb60a85c18b8f233f9fd9a1eff7
Reviewed-on: https://gerrit.instructure.com/20656
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
 		2013-05-16 19:03:32 +00:00
..
broadcast_policies fix quiz submission notifications 2013-05-15 21:29:18 +00:00
discussion_topic fixes for api translation of attachment links 2013-04-19 18:20:01 +00:00
quiz_questions fix non-deterministic spec failures for quiz student analyis csv 2013-05-09 19:39:58 +00:00
quiz_statistics fix non-deterministic spec failures for quiz student analyis csv 2013-05-09 19:39:58 +00:00
access_token_spec.rb allow 3rd parties to use oauth for authentication 2013-03-18 14:53:29 -06:00
account_authorization_config_spec.rb support multiple SAML private keys for decryption 2013-03-15 14:31:57 -06:00
account_notification_spec.rb spec: fix sharding it_should_behave_like for rspec 2 2013-04-01 15:26:44 +00:00
account_spec.rb lti configuration refactor 2013-04-29 21:05:58 +00:00
account_user_spec.rb spec: fix sharding it_should_behave_like for rspec 2 2013-04-01 15:26:44 +00:00
active_record_base_spec.rb arel-ify specs 2013-03-27 21:51:21 +00:00
alert_spec.rb Cross-shard conversations 2013-01-31 17:11:48 -07:00
announcement_spec.rb optionally lock all course announcements. 2013-02-11 16:55:32 -07:00
appointment_group_spec.rb clean up course account associations 2013-02-08 16:33:25 -07:00
assessment_question_bank_spec.rb don't repeat questions when picking from banks, fixes #4212 2011-10-19 09:42:29 -06:00
assessment_question_spec.rb move infer_defaults to before_validation so validation passes 2012-10-17 09:58:10 -06:00
assessment_request_spec.rb only send reminder notifications for peer reviews. 2013-05-07 22:23:14 +00:00
asset_user_access_spec.rb refs #8395 expanded page views 2012-11-30 08:34:18 -07:00
assignment_group_spec.rb use a meaningful context for confirmation notifications 2012-02-22 14:43:53 -07:00
assignment_override_spec.rb arel-ify specs 2013-03-27 21:51:21 +00:00
assignment_override_student_spec.rb vdd backend for quizzes 2012-12-18 14:28:34 -07:00
assignment_spec.rb don't create a new external_tool_tag on assignment update 2013-05-16 19:03:32 +00:00
attachment_spec.rb upload attachments to s3 outside of the AR#save db transaction 2013-05-06 19:28:37 +00:00
bookmark_service_spec.rb switch to mocha mock framework for specs 2011-10-27 08:37:13 -06:00
broadcast_policies_spec.rb Initial commit. 2011-01-31 18:57:29 -07:00
calendar_event_spec.rb fix failing specs (caused by libxml2 upgrade) 2013-04-18 16:29:44 +00:00
collaboration_spec.rb add new collaborator picker interface. fixes #CNVS-1160 2013-01-11 09:57:04 -07:00
collaborator_spec.rb spec: avoid before(:all) where possible 2013-03-18 17:04:46 -06:00
collection_item_spec.rb spec: fix sharding it_should_behave_like for rspec 2 2013-04-01 15:26:44 +00:00
collections_spec.rb allow setting collections to private 2012-07-30 09:10:31 -06:00
communication_channel_spec.rb spec: fix sharding it_should_behave_like for rspec 2 2013-04-01 15:26:44 +00:00
content_export_spec.rb spec: don't use user for user_id in communication_channel_model 2013-03-20 22:47:22 +00:00
content_migration_spec.rb remove 1.8 compatibility shims 2013-05-03 01:43:52 +00:00
content_participation_count_spec.rb fix grade badge count with comments 2013-04-25 17:58:02 +00:00
content_participation_spec.rb arel-ify specs 2013-03-27 21:51:21 +00:00
content_tag_spec.rb arel-ify specs 2013-03-27 21:51:21 +00:00
context_external_tool_spec.rb lti configuration refactor 2013-04-29 21:05:58 +00:00
context_module_spec.rb arel-ify specs 2013-03-27 21:51:21 +00:00
context_spec.rb string validations/fixes, closes #4154. wiki fixes, closes #3973, #4168 2011-04-05 11:22:50 -06:00
conversation_batch_spec.rb spec: fix sharding it_should_behave_like for rspec 2 2013-04-01 15:26:44 +00:00
conversation_message_spec.rb improve robustness of incoming message processor 2013-04-29 14:47:09 +00:00
conversation_participant_spec.rb spec: fix sharding it_should_behave_like for rspec 2 2013-04-01 15:26:44 +00:00
conversation_spec.rb update conversation tags when new courses exist. 2013-05-03 21:25:50 +00:00
course_section_spec.rb don't disallow deleting a section due to StudentViewEnrollments 2013-04-02 15:02:58 +00:00
course_spec.rb make some boolean logic clearer 2013-05-07 15:16:16 +00:00
crocodoc_document_spec.rb limit query of CrocodocDocument for status checking 2013-01-15 14:49:08 -07:00
delayed_message_spec.rb arel-ify scopes 2013-04-01 21:57:16 +00:00
developer_key_spec.rb spec: fix sharding it_should_behave_like for rspec 2 2013-04-01 15:26:44 +00:00
discussion_entry_spec.rb add forced_read_state to DiscussionEntryParticipant and APIs 2013-05-10 21:45:23 +00:00
discussion_topic_participant_spec.rb ensure unread_entry_counts never drop below 0. 2013-02-28 13:23:01 -07:00
discussion_topic_spec.rb add forced_read_state to DiscussionEntryParticipant and APIs 2013-05-10 21:45:23 +00:00
enrollment_spec.rb arel-ify models 2013-04-01 18:42:38 +00:00
enrollment_term_spec.rb fix i18n for default term name 2011-08-03 11:20:39 -06:00
eportfolio_category_spec.rb Initial commit. 2011-01-31 18:57:29 -07:00
eportfolio_entry_spec.rb Initial commit. 2011-01-31 18:57:29 -07:00
eportfolio_spec.rb Initial commit. 2011-01-31 18:57:29 -07:00
error_report_spec.rb filter sensitive data from error reports 2012-08-02 16:24:45 -06:00
external_feed_spec.rb Initial commit. 2011-01-31 18:57:29 -07:00
folder_spec.rb don't allow multiple root folders for courses 2013-02-01 16:02:16 -07:00
general_model_spec.rb ignore a model from an old migration for attr_accessible check 2011-09-27 09:39:07 -06:00
google_doc_entry.rb support for lazy loading google docs (backend) 2013-02-20 15:30:59 -07:00
grading_standard_spec.rb avoid interacting with deleted grading standards 2012-12-18 17:03:20 -07:00
group_category_spec.rb correctly associate group assignment submissions 2012-07-17 11:39:17 -06:00
group_membership_spec.rb limit self-assigned group size, closes #CNVS-5407 2013-05-08 16:47:14 +00:00
group_spec.rb limit self-assigned group size, closes #CNVS-5407 2013-05-08 16:47:14 +00:00
inbox_item_spec.rb remove 1.9 hash from inbox_item_spec. 2013-02-22 14:44:11 -07:00
learning_outcome_group_spec.rb learning outcomes refactor 2012-08-22 09:51:39 -06:00
learning_outcome_spec.rb clarify/fix outcome API permissions 2012-11-01 11:44:59 -06:00
media_object_spec.rb specs: more generalization of delayed jobs in specs 2012-08-21 10:34:56 -06:00
message_spec.rb use RailsXss::Erubis for html email templates, fixes CNVS-5414 2013-04-23 16:56:53 +00:00
notification_policy_spec.rb spec: fix sharding it_should_behave_like for rspec 2 2013-04-01 15:26:44 +00:00
notification_spec.rb arel-ify specs 2013-03-27 21:51:21 +00:00
observer_enrollment_spec.rb fix page error if observed is not an active student 2012-03-09 10:46:56 -07:00
page_view_spec.rb preserve created_at in page views from redis 2013-04-30 21:50:15 +00:00
plugin_setting_spec.rb proactively clear cache when changing plugin settings 2012-10-29 12:11:31 -06:00
profile_spec.rb context profiles, refs CNVS-2650 2013-02-01 17:57:07 -07:00
pseudonym_spec.rb use right host names on communication channel merge emails. 2013-05-14 23:10:57 +00:00
quiz_group_spec.rb show re-publish button when editing a quiz question group 2013-03-15 09:19:12 -06:00
quiz_question_spec.rb make question data always a HashWithIndifferentAccess 2012-02-09 16:29:54 -07:00
quiz_spec.rb make quiz_statistics model 2013-04-09 23:21:09 +00:00
quiz_statistics_spec.rb remove 1.8 compatibility shims 2013-05-03 01:43:52 +00:00
quiz_submission_spec.rb fix quiz submission notifications 2013-05-15 21:29:18 +00:00
role_override_spec.rb include attribute to exclude permissions based on plugins 2013-04-22 16:36:24 +00:00
role_spec.rb add users from courses/:id/users page 2013-04-18 19:43:54 +00:00
rubric_assessment_spec.rb Show freeform rubric comments to students, fixes #4864 2012-02-27 16:40:46 -07:00
rubric_association_spec.rb don't try to link account rubrics to assessments; fixes #8864 2012-06-13 13:01:51 -06:00
rubric_spec.rb Nested outcomes UI, closes #9158 2012-10-25 11:03:21 -06:00
scribd_account_spec.rb Initial commit. 2011-01-31 18:57:29 -07:00
sis_batch_spec.rb [#5773] multiple ruby 1.9 spec fixes 2012-10-23 10:14:24 -06:00
stream_item_instance_spec.rb remove 1.8 compatibility shims 2013-05-03 01:43:52 +00:00
stream_item_spec.rb spec: fix sharding it_should_behave_like for rspec 2 2013-04-01 15:26:44 +00:00
student_enrollment_spec.rb Initial commit. 2011-01-31 18:57:29 -07:00
student_view_enrollment_spec.rb student view; closes #6995 2012-04-03 14:11:07 -06:00
submission_comment_spec.rb improve robustness of incoming message processor 2013-04-29 14:47:09 +00:00
submission_spec.rb fix quiz submission notifications 2013-05-15 21:29:18 +00:00
submission_version_spec.rb skip submission versions that have no assignment 2013-05-08 14:20:57 +00:00
ta_enrollment_spec.rb Initial commit. 2011-01-31 18:57:29 -07:00
teacher_enrollment_spec.rb Initial commit. 2011-01-31 18:57:29 -07:00
test.txt Initial commit. 2011-01-31 18:57:29 -07:00
user_follow_spec.rb spec: fix sharding it_should_behave_like for rspec 2 2013-04-01 15:26:44 +00:00
user_observer_spec.rb user co-enrollment backend work, closes #8588 2012-05-23 12:21:00 -06:00
user_profile_spec.rb include root_account in section_tabs cache key 2012-08-17 14:15:10 -06:00
user_service_spec.rb Initial commit. 2011-01-31 18:57:29 -07:00
user_spec.rb add toggle for discussion auto-mark as read option. 2013-05-10 22:50:45 +00:00
web_conference_spec.rb arel-ify specs 2013-03-27 21:51:21 +00:00
wiki_page_spec.rb wiki page draft state support 2013-04-26 16:31:27 +00:00
wiki_spec.rb Initial commit. 2011-01-31 18:57:29 -07:00
wimba_conference_spec.rb spec: avoid before(:all) where possible 2013-03-18 17:04:46 -06:00
zip_file_import_spec.rb make zip file processing asynchronous 2012-02-29 14:04:53 -07:00