ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/spec
History
Brian Palmer 69d9f0262d don't create a new external_tool_tag on assignment update 
Not only is this unnecessary, but worse it changes the assignment's
resource_link_id, messing up any LTI tools that rely on that
parameter.

fixes CNVS-5884

test plan: Create an LTI assignment using any tool, and inspect the html
to view the launch parameters. Record the resource_link_id. Then edit
and save the assignment, and inspect the launch parameters again. The
resource_link_id should remain the same.

Change-Id: Ib2adcff90474cbb60a85c18b8f233f9fd9a1eff7
Reviewed-on: https://gerrit.instructure.com/20656
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
 		2013-05-16 19:03:32 +00:00
..
apis create 'page' type module items through API using wiki page url 2013-05-16 16:08:01 +00:00
coffeescripts increment/decrement method for Backbone model attributes 2013-05-15 17:12:54 +00:00
controllers fix changing an ungraded survey to a graded quiz 2013-05-16 03:13:27 +00:00
factories a new [image] button in tinyMCE's toolbar 2013-05-06 19:20:14 +00:00
fixtures a new [image] button in tinyMCE's toolbar 2013-05-06 19:20:14 +00:00
helpers don't load translations in test mode by default 2013-05-14 21:16:35 +00:00
initializers remove 1.8 compatibility shims 2013-05-03 01:43:52 +00:00
integration Locked graded discussions are now visible to students 2013-05-02 17:21:31 +00:00
javascripts add users from courses/:id/users page 2013-04-18 19:43:54 +00:00
lib adding additional api support for the app center 2013-05-15 17:22:31 +00:00
messages resolved html emails including html tags 2013-05-10 16:48:50 +00:00
migrations fix dissociated discussion topics. 2013-04-23 18:06:22 +00:00
models don't create a new external_tool_tag on assignment update 2013-05-16 19:03:32 +00:00
observers cross shard dashboards 2012-11-29 17:36:24 -07:00
presenters optionally disable grade distributions in courses with many submissions 2013-04-23 02:41:29 +00:00
selenium don't load translations in test mode by default 2013-05-14 21:16:35 +00:00
views add account quotas tab 2013-05-11 02:56:32 +00:00
broadcast_integration.rb Initial commit. 2011-01-31 18:57:29 -07:00
cassandra_spec_helper.rb spec: more generically clear cassandra tables for specs 2012-11-06 07:22:16 -07:00
mocha_extensions.rb initialize any_instantiation class variable 2011-12-14 13:28:10 -07:00
mocha_rspec_adapter.rb improve robustness of incoming message processor 2013-04-29 14:47:09 +00:00
nested_instafail_formatter.rb add a rspec nested_instafail_formatter 2011-12-28 16:18:28 -07:00
rcov.opts Initial commit. 2011-01-31 18:57:29 -07:00
sharding_spec_helper.rb spec: remove shared_examples_for "sharding" 2013-04-10 16:48:07 +00:00
spec.opts fixes for ruby 1.9.3 2012-05-12 14:34:23 -06:00
spec_helper.rb remove 1.8 compatibility shims 2013-05-03 01:43:52 +00:00