![]() fixes CNVS-14666 altered styles and markup to include form elements in group category edit view. abstracted some element handling for autoloader controls into edit view to be shared by create view. updated group category API to include auto_leader in JSON serialization (so the edit form can set the state correctly) Changed edit view to set form state based on auto_leader value in GroupCategory model from API. add tests for GroupCategoryEditView in coffee script update GroupCategories::Params to favor form submission value over raw api value for auto leader if both are specified and the form version is enabled. add ability to nil out auto_leader status by unchecking checkbox on form TEST PLAN: - login as a teacher - create a group set - edit the group set - you should be able to change the group leadership settings - you should be able to nil out autoloader settings by unchecking the checkbox on the edit form - ensure that as students are added to the groups the leadership settings are effective (that is a leader still gets assigned at random or by first joining student depending on leadership strategy selected) Change-Id: Iecbb4829f5efccda1bd97bca1d99c3bd4c15bffe Reviewed-on: https://gerrit.instructure.com/41965 Tested-by: Jenkins <jenkins@instructure.com> QA-Review: Trevor deHaan <tdehaan@instructure.com> Reviewed-by: Matthew Wheeler <mwheeler@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> |
||
---|---|---|
.. | ||
params.rb | ||
params_policy.rb |