1581b4cf91
ensure inferred keys are never scoped to the file
this fixes the current broken behavior:
{{#t}}...{{/t}}
scoped at extraction time
not scoped at runtime
{{t ...}} and I18n.t
not scoped at extraction time
scoped at runtime
ruby key inference already works correctly (never scoped to the file)
notes:
running i18n:generate will now put all inferred keys at the root level.
since no js/hbs inferred keys were actually resolving to their
translations, this won't break any currently working translations and
will fix a lot of stuff...
the inline hbs t and I18n.t calls will start working immediately (since it
was just a runtime scoping issue), the #t calls will automatically sort
themselves out with a transifex round trip (since they were scoped
incorrectly at extraction time). there are over 300 over the former and
about a dozen of the latter.
test plan:
1. confirm missing strings listed on ticket now show up. a good example of
this is the new course wizard; whereas before nothing was translated,
now everything is (apart from a few new strings that haven't made the
transifex round trip)
2. see all the new specs
3. also, try it out yourself. essentially:
1. run `rake i18n:generate`
2. find the string you want to verify, and put a corresponding value
in the right place in es.yml (or wherever) if there isn't already
one
3. run `rake canvas:compile_assets`
4. run canvas with `RAILS_LOAD_ALL_LOCALES=true USE_OPTIMIZED_JS=true`
5. switch to es (or whatever) and verify the translation is displayed
Change-Id: I0574b90acbdc4f6fda9c814a3607a9002c9e6a00
Reviewed-on: https://gerrit.instructure.com/47626
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
|
||
|---|---|---|
| .. | ||
| hbs | ||
| js | ||