canvas-lms/gems/dr_diff
Cody Cutrer f7271c4e3e run linters on previous commit if there are no local changes
this was lost in https://gerrit.instructure.com/#/c/90657/33

Change-Id: Ie3a0c38cb7df0b627954ebc00ec9b0fc99bf43c7
Reviewed-on: https://gerrit.instructure.com/100330
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2017-01-24 18:53:38 +00:00
..
config incremental linting via dr diff, fixes SD-1521 2016-09-22 20:06:57 +00:00
lib run linters on previous commit if there are no local changes 2017-01-24 18:53:38 +00:00
spec run linters on previous commit if there are no local changes 2017-01-24 18:53:38 +00:00
Gemfile incremental linting via dr diff, fixes SD-1521 2016-09-22 20:06:57 +00:00
README.md incremental linting via dr diff, fixes SD-1521 2016-09-22 20:06:57 +00:00
Rakefile incremental linting via dr diff, fixes SD-1521 2016-09-22 20:06:57 +00:00
dr_diff.gemspec run linters on previous commit if there are no local changes 2017-01-24 18:53:38 +00:00
test.sh incremental linting via dr diff, fixes SD-1521 2016-09-22 20:06:57 +00:00

README.md

Dr Diff

Dr Diff is a linter's best friend forever.

Say you want to add rubocop or eslint to your project, but you'd have to fix a million linter errors throughout your monolithic app for the linter to pass your commit. Don't worry, Dr Diff is here! He can make your linter run only on the diff of your commit! That is, only on the files/lines your commit changed. Huzzah! Now you can polish your app one small piece at a time, saving your QA friends from:

add rubocop, fixes CNVS-1234

test plan:
* regression test the entire app

Usage

require "dr_diff"

# Create a manager.
# -- (optional) git_dir (uses cwd by default)
# -- (optional) sha (runs on outstanding changes by default)
dr_diff = DrDiff::Manager.new(git_dir: git_dir, sha: env_sha)

# Collect the files for this change.
# -- (optional) regex to filter results
ruby_files = dr_diff.files(/\.rb$/)

# Collect relevant linter comments.
# -- (required) format
# -- (required) command
# Under the hood, Dr Diff uses Gergich (github.com/instructure/gergich)
# to collect linter comments.
# See github.com/instructure/gergich#gergich-capture-format-command
# for details on format and command parameters.
comments = dr_diff.comments(format: "rubocop",
                            command: "rubocop #{ruby_files.join(' ')}")

# These comments will be objects of the form:
# {
#   path: "/path/to/file.rb",
#   message: "[rubocop] Avoid using sleep.\n\n       sleep 1\n       ^^^^^^^\n",
#   position: 5, # line number
#   severity: "error" # one of %w(error warn info)
# }

# If you are using gergich, you may want him to post these comments via:
if comments.length > 0
  require 'shellwords'
  `gergich comment #{Shellwords.escape(comments.to_json)}`
end

# Take a peek at /script/rlint to see how Canvas uses Dr Diff.