ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/spec
History
Jeff Largent eed550ce62 Don't give RCE the `application` role 
It looks like tinymce by default wraps the whole RCE element in a
`role="application"` attribute, which causes NVDA to skip over it as
an editable element.  This switches that to a `role="document"`
attribute to make it more visible to NVDA and other screen readers.

fixes LS-1659
flag = rce_enhancements

Test plan:
  - create a new assignment for a course
  - when in NVDA's "browse" mode, hit the "E" key to skip to the next
    editable text field
  - verify that NVDA does not skip over the RCE to the points field
    any longer
  - ensure that screen readers continue to read content within the
    RCE the same way they did before

Change-Id: If03e1ce8fb7cc4af9dbf3531012cfb4c366cbfce
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/254517
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Daniel Sasaki <dsasaki@instructure.com>
 		2020-12-08 19:55:43 +00:00
..
apis allow anonymous user take ugraded quiz in public courses 2020-12-08 19:31:48 +00:00
coffeescripts New approach to MathJax-ifying equations 2020-11-09 22:38:36 +00:00
contracts spec: Run live events specs if an env var is set 2020-11-10 00:31:34 +00:00
controllers fix moderation list for differentiated quizzes 2020-12-08 17:56:35 +00:00
factories No custom JS for users from other root accounts (like siteadmin) 2020-12-03 19:08:09 +00:00
factory_bot add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
fixtures add api for group category import 2020-10-07 18:21:45 +00:00
formatters add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
gem_integration/canvas_connect add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
graphql add address book graphql types 2020-12-08 17:15:30 +00:00
helpers siteadmins either see no custom assets 2020-12-04 22:03:17 +00:00
initializers update all invocations of send_later and friends to new syntax 2020-10-30 19:13:54 +00:00
instfs/selenium add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
integration Add granular permissions for course sections 2020-11-20 19:09:47 +00:00
javascripts add release flag to load assignments by grading period 2020-12-08 18:54:19 +00:00
lib stop NaN failures on lti scores 2020-12-08 17:50:43 +00:00
manual_seeding add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
messages add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
middleware add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
migrations add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
models allow anonymous user take ugraded quiz in public courses 2020-12-08 19:31:48 +00:00
observers update to inst-jobs 1.0 via shims 2020-10-28 13:46:49 +00:00
presenters add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
requests add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
schemas/lti add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
selenium Don't give RCE the `application` role 2020-12-08 19:55:43 +00:00
serializers add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
shared_examples add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
support add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
views add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
.eslintrc spec: add global sandbox 2018-07-13 15:16:23 +00:00
.rspec_parallel use parallel_tests for more parallelization 2020-03-30 21:38:47 +00:00
ams_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
broadcast_integration.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
cassandra_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
conditional_release_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
coverage_tool.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
factories.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
factory_bot_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
feature_flag_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
file_upload_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
force_failure_spec.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
import_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
jspec.sh
…
lti2_course_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
lti2_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
lti_1_3_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
lti_1_3_tool_configuration_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
lti_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
plagiarism_platform_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
quiz_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
rcov.opts
…
rspec_mock_extensions.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
sharding_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
simple_cov_result_merger.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
spec.opts remove abort_on_consistent_badness_formatter 2020-10-13 18:10:04 +00:00
spec_helper.rb speed up app boot with lazy translations 2020-11-18 00:40:13 +00:00