ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/spec
History
Charley Kline 53fef6fb10 Make InstUI render links, not buttons, in the help menu 
Fixes FOO-2779
flag=none

InstUI's <Link> component automatically adds `role="button"` whenever
an onClick prop is sent to it, but for screenreader purposes those help
links need to read out as links.

While we investigate a way to control the behavior of <Link> regarding
the element role, for now the solution is to wrap the <Link> in a <span>
and put the click action on the span.

Test Plan:
- See the steps to reproduce in the ticket
- All the links in the help menu should get read out by a
  screenreader as "Link" not "Button"

Change-Id: Ia2493e89f6816696d7a46bebe958377410fa53a3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289242
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
 		2022-04-08 20:07:14 +00:00
..
apis add an endpoint to translate migration_ids 2022-04-07 22:19:29 +00:00
coffeescripts fix eager I18n.t() calls 2022-04-07 18:33:37 +00:00
contracts rename Canvas::DynamicSettings => DynamicSettings 2022-01-12 21:54:51 +00:00
controllers Count of entries on redesign vist 2022-04-08 19:33:24 +00:00
factories create results for manually graded LTI submissions 2022-04-04 20:00:01 +00:00
factory_bot RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
fixtures Refactor PacePlan to CoursePace 2022-03-15 19:10:16 +00:00
formatters spec: add formatter for example count 2022-01-14 22:13:42 +00:00
gem_integration/canvas_connect RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
graphql Remove IORCM FF from backend and frontend code 2022-04-08 19:35:20 +00:00
helpers Remove IORCM FF from backend and frontend code 2022-04-08 19:35:20 +00:00
initializers add job context to short log format 2022-04-05 19:48:54 +00:00
instfs/selenium RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
integration Improve Sentry APM sampling decisions 2022-02-05 00:17:52 +00:00
javascripts Delete a troublesome modules spec 2022-04-08 13:27:05 +00:00
lib Add file check to crystalball smoke test and move to rspecq 2022-04-07 15:09:29 +00:00
manual_seeding RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
messages Rename mentions notification type to correct one 2022-03-10 20:48:48 +00:00
migrations Clean up for external tool UI/testing 2022-03-09 02:09:30 +00:00
models Increment discussion entry created 2022-04-08 17:33:58 +00:00
observers Announce MasterMigration completed on LiveEvents 2022-03-24 20:10:38 +00:00
presenters Refactor PacePlan to CoursePace 2022-03-15 19:10:16 +00:00
requests Don't allow updates to anonymous_state on discussion topic 2021-12-01 16:57:35 +00:00
schemas/lti RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
selenium Make InstUI render links, not buttons, in the help menu 2022-04-08 20:07:14 +00:00
serializers expose launch url in AGS Line Item API 2022-03-15 22:26:05 +00:00
shared_examples fix speedgrader moderated grading concluded/deactivated bug 2022-03-24 17:21:25 +00:00
support Add file check to crystalball smoke test and move to rspecq 2022-04-07 15:09:29 +00:00
views add submission comment emojis 🎉 2022-03-17 14:46:07 +00:00
.eslintrc Update eslint to v7 2021-05-20 18:28:51 +00:00
.rspec_parallel
…
ams_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
broadcast_integration.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
canvas_simplecov.rb Repair canvas coverage 2022-01-05 17:55:26 +00:00
cassandra_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
conditional_release_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
coverage_tool.rb Repair canvas coverage 2022-01-05 17:55:26 +00:00
factories.rb Stop leaking siteadmin ids from spec setup 2022-02-25 23:11:11 +00:00
factory_bot_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
feature_flag_helper.rb RuboCop: Performance 2021-11-17 20:03:38 +00:00
file_upload_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
force_failure_spec.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
import_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
jspec.sh
…
lti2_course_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
lti2_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
lti_1_3_spec_helper.rb rename Canvas::DynamicSettings => DynamicSettings 2022-01-12 21:54:51 +00:00
lti_1_3_tool_configuration_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
lti_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
plagiarism_platform_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
quiz_spec_helper.rb add # frozen_string_literal: true for specs 2020-10-27 20:48:35 +00:00
rcov.opts
…
rspec_mock_extensions.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
sharding_spec_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
simple_cov_result_merger.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
spec.opts remove abort_on_consistent_badness_formatter 2020-10-13 18:10:04 +00:00
spec_helper.rb Add file check to crystalball smoke test and move to rspecq 2022-04-07 15:09:29 +00:00