ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
7,673 Commits 324 Branches 20,019 Tags 1.7 GiB
Ruby 51.2%
JavaScript 33.7%
TypeScript 10.3%
HTML 2.5%
SCSS 1.3%
Other 1%
Go to file
Cody Cutrer 5254bfc09d clean up some rubric assessment requests stuff 
refs CNVS-7414

first, start at RubricsController#assessments. there is no route for it,
so remove the action and it's view. The rubric_association partial was
only used from that view, so remove it as well. Then in
RubricAssessmentController and RubricAssociationsController #create,
note that nothing ever provides an invitations param, so remove that,
and cascade down to removing or simplifying a few other methods
(particularly RubricAssociation#invite_assessors, which created users
in a bad way, and RubricAssociation#invite_assessor, which never
assigned assessor_asset, which will shortly be non-null, and is
obviously never used cause that column is never null in production).

Finally, fix some specs to properly create rubric assessments since
the (bad) helper methods are now gone.

test plan:
 * specs
 * basic regression test around using rubrics for grading and
   peer reviews

Change-Id: Ibd7713d9fc1f847d49c47b95d8c51ce28fa41e92
Reviewed-on: https://gerrit.instructure.com/23412
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 		2013-08-20 17:34:36 +00:00
app clean up some rubric assessment requests stuff 2013-08-20 17:34:36 +00:00
config clean up some rubric assessment requests stuff 2013-08-20 17:34:36 +00:00
db/migrate add the ability to regrade a quiz 2013-08-19 17:29:26 +00:00
doc generate an api.json file from 'yard' API docs 2013-08-16 21:45:35 +00:00
guard ember 2013-08-14 20:04:10 +00:00
lib remove redis.pipelined usage 2013-08-19 20:33:45 +00:00
loom added ember generators 2013-08-19 17:22:01 +00:00
node_modules update require.js node module 2012-06-27 17:29:47 -06:00
public add the ability to regrade a quiz 2013-08-19 17:29:26 +00:00
script useful find_each 2013-07-18 22:26:46 +00:00
spec clean up some rubric assessment requests stuff 2013-08-20 17:34:36 +00:00
vendor/plugins remove redis.pipelined usage 2013-08-19 20:33:45 +00:00
.gitignore implemented dress_code 2013-04-09 15:43:16 +00:00
.jshintrc make jslint settings more sane 2012-08-17 11:04:40 -06:00
CONTRIBUTING.md add a contributing doc for github coolness 2012-09-19 10:16:04 -06:00
COPYRIGHT Initial commit. 2011-01-31 18:57:29 -07:00
Gemfile update fake_rails3_routes to 1.0.4 2013-08-12 22:21:37 +00:00
Guardfile ember 2013-08-14 20:04:10 +00:00
LICENSE Initial commit. 2011-01-31 18:57:29 -07:00
README.md README changes to point more directly to installation instructions 2011-02-01 17:36:01 -07:00
Rakefile get rspec 2 running with rails 3.0 2013-03-27 15:41:28 +00:00
config.ru start adding rails 3.0 support 2013-03-22 19:08:40 +00:00
package.json added ember generators 2013-08-19 17:22:01 +00:00

README.md

Canvas LMS

Canvas is a new, open-source LMS by Instructure Inc. It is released under the AGPLv3 license for use by anyone interested in learning more about or using learning management systems.

Please see our main wiki page for more information

Installation

Detailed instructions for installation and configuration of Canvas are provided on our wiki.