canvas-lms/spec/lib/lti
Ryan Hawkins 994d21b65b Don't forward empty titles in LTI 1.3 Launches
why:
- In 29304fe219, we passed the resource
  link title through to the assignment and thus the update_line_items
  method.
- That method also left some resource link's behind in the database that
  have an empty title. We don't want to send an empty title.

refs INTEROP-8606

test-plan:
- Replicate production first by doing the following:
  - Create an assignment with a resource link by using the LTI 1.3 test
    tool. You won't be able to set
    the title to an empty string through the UI.
  - Run `Lti::ResourceLink.last.update!(title: "")` to replicate the bad
    data in production.
  - Launch the assignment again. The resource link title should be an
    empty string.
- Check this commit out.
- Launch the assignment again. The resource link title should now match
  the assignment title.

Change-Id: I7796f5988aa898c41be569a966e154c2da00ae58
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347831
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Ryan Hawkins <ryan.hawkins@instructure.com>
2024-05-20 20:52:41 +00:00
..
errors RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
helpers bump rubocop gems and apply changes 2023-08-07 20:13:35 +00:00
ims Add support for multiple lti_grant_hosts 2023-05-25 15:28:18 +00:00
membership_service Remove a lot of settings 2024-01-09 21:32:17 +00:00
messages Don't forward empty titles in LTI 1.3 Launches 2024-05-20 20:52:41 +00:00
oauth2 Remove a lot of settings 2024-01-09 21:32:17 +00:00
api_service_helper_spec.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
app_util_spec.rb respond to all postMessages in active RCE 2023-09-28 15:41:45 +00:00
asset_spec.rb don't null out lti_context_id in deleted shadow records 2023-10-24 18:48:32 +00:00
capabilities_helper_spec.rb bump rubocop gems and apply changes 2023-08-07 20:13:35 +00:00
content_item_converter_spec.rb rubocop: prep for updating rubocop-rspec 2023-04-12 19:30:10 +00:00
content_item_response_spec.rb bump rubocop gems and apply changes 2023-08-07 20:13:35 +00:00
content_item_selection_request_spec.rb Remove more settings 2024-01-29 16:21:38 +00:00
content_item_util_spec.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
context_tool_finder_spec.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
deep_linking_data_spec.rb rubocop: prep for updating rubocop-rspec 2023-04-12 19:30:10 +00:00
deep_linking_util_spec.rb rubocop: Layout/Multiline*LineBreaks 2023-05-01 19:31:42 +00:00
external_tool_name_bookmarker_spec.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
external_tool_tab_spec.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
logging_spec.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
message_authenticator_spec.rb rubocop: prep for updating rubocop-rspec 2023-04-12 19:30:10 +00:00
message_handler_name_bookmarker_spec.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
name_bookmarker_base_shared_examples.rb switch to native pg12 collation for ICU sorting 2023-04-12 17:18:46 +00:00
permission_checker_spec.rb rubocop: prep for updating rubocop-rspec 2023-04-12 19:30:10 +00:00
plagiarism_subscriptions_helper_spec.rb introduce bootsnap 2022-10-04 13:18:03 +00:00
platform_storage_spec.rb remove lti_platform_storage FF 2024-01-11 10:11:52 +00:00
privacy_level_expander_spec.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
re_reg_constraint_spec.rb bump rubocop gems and apply changes 2023-08-07 20:13:35 +00:00
redis_message_client_spec.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
scope_union_spec.rb bundle update rubocop 2024-04-10 16:31:10 +00:00
security_spec.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
substitutions_helper_spec.rb LTI: variable substitution for adminable accounts 2023-09-21 15:30:08 +00:00
tool_proxy_name_bookmarker_spec.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
tool_proxy_validator_spec.rb bump rubocop gems and apply changes 2023-08-07 20:13:35 +00:00
variable_expander_spec.rb Sort sectionNames var expansion by section id 2024-03-07 21:49:07 +00:00
variable_expansion_spec.rb Kill require_dependency 2023-01-09 19:51:01 +00:00