9b15eab25d
closes MAT-220
flag=rce_enhancements
The root problem was ENV.use_rce_enhancements not being set because
@context in application_controller was nil.
While I was getting that sorted out I had canvas trying to initialize
the new rce with old rce props, and a couple things were blowing up
so I added some defense to RCEWrapper.js
With the new RCE tinymce will not get loaded if you haven't actually
rendered it so I had to import tinymce into
sanitize-html-with-tinymce so it's guaranteed to be there when
you sanitize the content of the HTML/Embeded Content section
of ePortfolio on clicking Save Page.
test plan:
- with the rce enhancements feature on (defaults to on in dev)
- with ePortfolios enabled in account settings
- as a student, click on account section of the global nav
- select eportfolios
- select MyPortfolio (or click "Create an ePortfolio" then "Make ePortfolio")
- click "Welcome" in the sidebar
- click "Edit this page"
> expect the new rce
- this opens automatically for me in dev, but not during selenium
tests, which I don't understand. You may have to click the
"Rich Text Content' link in the sidebar.
> expect it to work and save your content
Change-Id: Ieacbd1dcb7c5690223c96238657e3a9562159e5f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/265976
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ahmad Amireh <ahmad@instructure.com>
QA-Review: Ahmad Amireh <ahmad@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
|
||
|---|---|---|
| .. | ||
| __tests__ | ||
| index.js | ||
| package.json | ||