ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/lib/api/v1
History
Venk Natarajan 3b666a93ba Include inactive users in group members. 
In the groups index page for a course, we were not displaying
inactive users.  This caused problems when a student tried to
sign up for a full group that had inactive users in it, since
we told them that the group had spaces.

This change now displays inactive as well as active users, so
the student is now told that the group is full.  It is up to
the teacher to remove such students if they see fit.

Fixes COMMS-4

Test plan:
* Have a course with some self sign-up groups, with a limit.
* Fill the group up to the limit with active students, making
  sure you have a student left that is not in the group.
* Now, deactivate one of the students in the group.
* With the student *not* in the group, act as that user.
* Go to the "people" page for the course and click on groups.
* Now the student will be told that the group is full.
* Become the teacher again.
* Go to the group in question, the inactive users in it should
  be marked as such.

Change-Id: If54df1e22779a5c0a4a97ed79245e7d5a6d76713
Reviewed-on: https://gerrit.instructure.com/131728
Tested-by: Jenkins
Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
 		2017-11-08 18:21:15 +00:00
..
account.rb da licença part 25 2017-04-27 21:51:40 +00:00
account_authorization_config.rb da licença part 25 2017-04-27 21:51:40 +00:00
account_notifications.rb da licença part 25 2017-04-27 21:51:40 +00:00
account_report.rb add current_line and total_lines to account_reports 2017-05-17 19:34:01 +00:00
admin.rb add workflow_state to account_users 2017-08-01 18:31:37 +00:00
api_context.rb da licença part 25 2017-04-27 21:51:40 +00:00
assessment_request.rb da licença part 25 2017-04-27 21:51:40 +00:00
assignment.rb add criterion_use_range and rating long_description to api 2017-11-02 15:26:51 +00:00
assignment_group.rb da licença part 25 2017-04-27 21:51:40 +00:00
assignment_override.rb invalidate cached override list when creating new override 2017-09-25 13:07:48 +00:00
attachment.rb don't break on 201 Created response from S3 2017-10-27 19:49:48 +00:00
authentication_event.rb da licença part 25 2017-04-27 21:51:40 +00:00
avatar.rb request thumbnails from instfs when enabled 2017-10-03 20:00:08 +00:00
calendar_event.rb Enable viewing of CalendarEvents cross shard 2017-10-11 21:53:37 +00:00
collaboration.rb da licença part 25 2017-04-27 21:51:40 +00:00
collaborator.rb da licença part 25 2017-04-27 21:51:40 +00:00
comm_message.rb add from_name to CommMessage api 2017-08-15 15:47:22 +00:00
communication_channel.rb da licença part 25 2017-04-27 21:51:40 +00:00
conferences.rb da licença part 25 2017-04-27 21:51:40 +00:00
content_export.rb mark content exports older than 30 days as expired 2017-05-23 19:51:12 +00:00
content_migration.rb mark content imports as expired after X days 2017-08-15 03:29:19 +00:00
context.rb Wiki Pages for student planner 2017-05-26 21:31:37 +00:00
context_module.rb fix incorrect module sequence with autograded mastery path items 2017-09-14 23:41:44 +00:00
conversation.rb add mobile_student_label mobile_teacher_state API 2017-08-31 23:18:14 +00:00
course.rb master courses: return restriction info in course api 2017-10-11 19:47:08 +00:00
course_event.rb da licença part 25 2017-04-27 21:51:40 +00:00
course_json.rb add sis_import_id to courses api 2017-11-03 20:49:33 +00:00
custom_gradebook_column.rb da licença part 25 2017-04-27 21:51:40 +00:00
developer_key.rb Add DeveloperKey/vendor code association for LTI2 2017-08-07 16:32:48 +00:00
discussion_topics.rb Show availability time for group ungraded discussions. 2017-11-03 15:52:23 +00:00
enrollment_term.rb add sis_import_id to terms api 2017-11-06 17:53:10 +00:00
epub_export.rb da licença part 25 2017-04-27 21:51:40 +00:00
external_feeds.rb da licença part 25 2017-04-27 21:51:40 +00:00
external_tools.rb show the correct url for pagination on groups 2017-06-16 13:57:24 +00:00
favorite.rb da licença part 25 2017-04-27 21:51:40 +00:00
feature_flag.rb da licença part 25 2017-04-27 21:51:40 +00:00
folders.rb da licença part 25 2017-04-27 21:51:40 +00:00
grade_change_event.rb add current grade to new gradebook history 2017-09-06 15:43:17 +00:00
gradebook_history.rb add mobile_student_label mobile_teacher_state API 2017-08-31 23:18:14 +00:00
grading_standard.rb da licença part 25 2017-04-27 21:51:40 +00:00
group.rb Include inactive users in group members. 2017-11-08 18:21:15 +00:00
group_category.rb da licença part 25 2017-04-27 21:51:40 +00:00
json.rb da licença part 25 2017-04-27 21:51:40 +00:00
locked.rb da licença part 25 2017-04-27 21:51:40 +00:00
master_courses.rb API/data model for linking planner notes to objects 2017-10-31 16:11:41 +00:00
media_object.rb da licença part 25 2017-04-27 21:51:40 +00:00
notification_policy.rb da licença part 25 2017-04-27 21:51:40 +00:00
outcome.rb da licença part 25 2017-04-27 21:51:40 +00:00
outcome_results.rb da licença part 25 2017-04-27 21:51:40 +00:00
page_view.rb da licença part 25 2017-04-27 21:51:40 +00:00
planner_item.rb Add new_activity tag to planner item json 2017-08-08 20:18:12 +00:00
planner_note.rb API/data model for linking planner notes to objects 2017-10-31 16:11:41 +00:00
planner_override.rb Add dismissed attribute to planner override API 2017-07-10 20:00:15 +00:00
post_grades_status.rb da licença part 25 2017-04-27 21:51:40 +00:00
preview_html.rb da licença part 25 2017-04-27 21:51:40 +00:00
progress.rb da licença part 25 2017-04-27 21:51:40 +00:00
pseudonym.rb da licença part 25 2017-04-27 21:51:40 +00:00
quiz.rb Whitelist virtual attribute locked for quiz locking via UI 2017-05-15 19:38:05 +00:00
quiz_group.rb da licença part 25 2017-04-27 21:51:40 +00:00
quiz_ip_filter.rb da licença part 25 2017-04-27 21:51:40 +00:00
quiz_question.rb da licença part 25 2017-04-27 21:51:40 +00:00
quiz_submission.rb fix quiz submissions serializer args 2017-09-29 16:43:16 +00:00
quiz_submission_question.rb da licença part 25 2017-04-27 21:51:40 +00:00
role.rb da licença part 25 2017-04-27 21:51:40 +00:00
rubric.rb da licença part 25 2017-04-27 21:51:40 +00:00
rubric_assessment.rb da licença part 25 2017-04-27 21:51:40 +00:00
section.rb don't include test students in course section student count 2017-10-11 18:50:07 +00:00
section_enrollments.rb da licença part 25 2017-04-27 21:51:40 +00:00
sis_assignment.rb da licença part 25 2017-04-27 21:51:40 +00:00
sis_import.rb add user object to sis import api 2017-10-06 19:41:18 +00:00
stream_item.rb add mobile_student_label mobile_teacher_state API 2017-08-31 23:18:14 +00:00
submission.rb Add canvadoc_document_id to submissions endpoint 2017-10-16 18:15:25 +00:00
submission_comment.rb add edited_at to submission_comments 2017-09-29 14:54:03 +00:00
tab.rb da licença part 25 2017-04-27 21:51:40 +00:00
todo_item.rb da licença part 25 2017-04-27 21:51:40 +00:00
usage_rights.rb da licença part 25 2017-04-27 21:51:40 +00:00
user.rb Revert "remove deprecated sis_login_id" 2017-11-06 17:53:57 +00:00
user_profile.rb da licença part 25 2017-04-27 21:51:40 +00:00
web_zip_export.rb da licença part 25 2017-04-27 21:51:40 +00:00
wiki_page.rb Wiki Pages for student planner 2017-05-26 21:31:37 +00:00