ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/lib
History
Jeremy Stanley edfe0d9540 rewind before retrying inst-fs upload 
otherwise we may end up sending an incomplete
or empty file on the second attempt

test plan: specs

fixes FOO-4119

Change-Id: I6105f6f0fe32e5a1436fa4f56fd963d16bbe1136
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/334370
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Mysti Lilla <mysti@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
 		2023-12-04 20:31:49 +00:00
..
address_book rubocop: Layout/Multiline*LineBreaks 2023-05-01 19:31:42 +00:00
api Wire up assingment overrides for DT create 2023-12-01 22:32:05 +00:00
app_center Remove unnecessary require statements 2023-01-04 21:38:21 +00:00
authentication_methods Consider client_id as identifier for service JWTs 2023-09-26 22:01:14 +00:00
base Teach cache register to support redis cluster hash tags 2023-11-17 22:27:44 +00:00
basic_lti bundle update rubocop 2023-08-14 16:32:06 +00:00
canvadocs Remove from canvadocs session the crocodoc_id 2023-10-26 17:29:37 +00:00
canvas allow a handful of succesful logins in short succession 2023-11-28 23:19:29 +00:00
cc Fix selective media attachment links 2023-11-06 16:53:46 +00:00
data_fixup Add comments pointing people to BulkToolUpdater 2023-11-28 21:31:55 +00:00
external_auth_observation Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
feature_flags Add archive_outcomes FF to Canvas 2023-11-20 17:20:44 +00:00
global_lookups Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
gradebook grade override status with null score 2023-11-02 20:31:50 +00:00
i18n/backend Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
latex Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
lti Make sure defined TTL constant is used 2023-12-04 15:25:19 +00:00
messageable_user Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
microsoft_sync rubocop: Rails/I18nLocaleAssignment 2023-06-13 21:59:50 +00:00
migration_helpers Account for unassign_item in ASV/QSV views 2023-11-20 15:16:31 +00:00
outcomes Filter Out Alignments to Deleted Quizzes in Alignments Summary 2023-10-20 16:58:46 +00:00
pandata_events wrap existing PandataEvents usage in service 2023-11-30 22:19:03 +00:00
rake Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
reporting Remove unnecessary require statements 2023-01-04 21:38:21 +00:00
schemas Fix LTI schema broken in non-MRA canvas 2023-10-09 17:08:37 +00:00
sentry_extensions remove Setting.skip_cache 2023-09-27 17:08:20 +00:00
services Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
sis fix "deleted sis login" error message 2023-11-20 17:53:10 +00:00
support_helpers Rename DueDateCacher to SubmissionLifecycleManager 2023-07-11 14:43:12 +00:00
tasks don't create error reports cross-region 2023-10-12 20:08:09 +00:00
turnitin standardize use of CET.from_content_tag 2023-08-28 15:43:53 +00:00
user_content Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
utils Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
account_services.rb Remove Delicious from Canvas 2023-03-22 15:01:28 +00:00
address_book.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
anonymity.rb RuboCop: Style/RedundantSelf 2021-11-20 16:41:21 +00:00
api.rb fix media_type for media submission comments 2023-10-27 15:56:09 +00:00
api_route_set.rb Hack around rails routing "constraints" deficiency 2023-09-13 18:56:21 +00:00
asset_signature.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
assignment_override_applicator.rb Unassign_item in AssignmentOverrideApplicator 2023-10-03 19:31:55 +00:00
assignment_util.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
authentication_methods.rb Don't authorize inst_access tokens from unusable keys 2023-09-26 22:01:03 +00:00
basic_lti.rb Kill require_dependency 2023-01-09 19:51:01 +00:00
brand_account_chain_resolver.rb favor active sub-account for branding 2021-12-08 18:15:55 +00:00
brand_config_helpers.rb Don't include parents in chain for regular accounts 2022-04-14 16:56:51 +00:00
brand_config_regenerator.rb rubocop: Layout/Multiline*LineBreaks 2023-05-01 19:31:42 +00:00
brandable_css.rb Remove unnecessary require statements 2023-01-04 21:38:21 +00:00
browser_support.rb Revert "(temp) only support LTI Platform Storage in Safari" 2023-10-16 15:01:46 +00:00
canvadocs.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
canvas_imported_html_converter.rb Set up methods for html migration 2023-07-18 21:44:46 +00:00
canvas_logger.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
capture_job_ids.rb add job_ids to sis_batches and parallel_importers 2023-06-07 17:09:46 +00:00
cc.rb Kill require_dependency 2023-01-09 19:51:01 +00:00
checkpoint.rb Add checkpoints to some REST endpoints 2023-10-25 18:03:15 +00:00
checkpoint_labels.rb Create CheckpointLabels 2023-10-13 18:25:53 +00:00
checkpointable.rb aggregate points_possible for checkpointed assignments 2023-10-24 16:42:00 +00:00
content_licenses.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
content_notices.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
content_zipper.rb Ensure BP downstream changes and re-locking works 2023-06-13 23:51:21 +00:00
conversation_batch_scrubber.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
conversation_helper.rb Data fix up for Conversation/ConversationParticipant 2023-02-17 19:17:24 +00:00
copy_authorized_links.rb rubocop: Lint/SendWithMixinArgument 2023-06-09 16:04:56 +00:00
course_link_validator.rb handle sylalbus links more robustly 2023-10-18 20:09:13 +00:00
course_pace_due_dates_calculator.rb Include account blackout dates in compressor 2023-11-15 18:13:23 +00:00
course_pace_hard_end_date_compressor.rb Include account blackout dates in compressor 2023-11-15 18:13:23 +00:00
course_paces_date_helpers.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
custom_validations.rb rubocop: Lint/SendWithMixinArgument 2023-06-09 16:04:56 +00:00
cuty_capt.rb rubocop: Lint/NonAtomicFileOperation 2023-04-11 14:48:13 +00:00
dates_overridable.rb Respect course overrides in AssignmentOverrideApplicator 2023-10-02 16:01:02 +00:00
delayed_message_scrubber.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
differentiable_assignment.rb allow consortium users to view assignments w/ assignment_overrides only 2023-06-12 16:47:37 +00:00
dump_helper.rb Remove unnecessary require statements 2023-01-04 21:38:21 +00:00
duplicating_objects.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
effective_due_dates.rb Respect 'unassign_item' in EffectiveDueDates 2023-10-25 13:10:49 +00:00
email_address_validator.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
enrollments_from_user_list.rb Rename DueDateCacher to SubmissionLifecycleManager 2023-07-11 14:43:12 +00:00
eportfolio_page.rb improve recent submission filtering in eportfolios 2023-01-10 22:55:55 +00:00
external_feed_aggregator.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
external_statuses.rb RuboCop: Style/MutableConstant 2021-11-16 16:19:54 +00:00
feature.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
feature_flags.rb add reasonable failsafes for several usages of Consul 2023-07-12 14:51:15 +00:00
file_authenticator.rb Use SHA256 for cache keys 2023-04-05 17:57:09 +00:00
file_in_context.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
file_splitter.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
global_lookups.rb make globalLookups a module to extend, not a stub 2021-10-26 14:58:27 +00:00
google_docs_preview.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
grade_calculator.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
grade_display.rb display minus instead of en-dash 2023-10-09 16:24:10 +00:00
gradebook_exporter.rb add custom status to gradebook exports 2023-08-23 20:56:59 +00:00
gradebook_grading_period_assignments.rb fix viewing grades for deactivated students 2022-02-16 17:56:03 +00:00
gradebook_importer.rb fix csv import override score 2023-09-19 17:11:05 +00:00
gradebook_settings_helpers.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
gradebook_user_ids.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
grading_period_helper.rb RuboCop: Style/RedundantSort 2021-11-19 22:25:07 +00:00
has_content_tags.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
health_checks.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
host_url.rb Rails 6.1 basic spec functionality 2022-02-16 17:31:11 +00:00
i18n_time_zone.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
inst_fs.rb rewind before retrying inst-fs upload 2023-12-04 20:31:49 +00:00
late_policy_applicator.rb add n_strand to late policy applicator jobs 2023-02-17 21:45:15 +00:00
latex.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
learning_outcome_context.rb rubocop: Lint/SendWithMixinArgument 2023-06-09 16:04:56 +00:00
locale_selection.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
locked_for.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
logging_filter.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
login_hooks.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
material_changes.rb avoid recalculating enrollment states due to truncation 2023-05-16 19:36:36 +00:00
math_man.rb Use SHA256 for cache keys 2023-04-05 17:57:09 +00:00
message_dispatcher.rb Improve error logging for message batch dispatching 2022-06-23 15:10:18 +00:00
message_scrubber.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
messageable_user.rb rubocop: Layout/Multiline*LineBreaks 2023-05-01 19:31:42 +00:00
missing_policy_applicator.rb fix missing policies not updating badge count 2023-10-02 17:26:04 +00:00
model_cache.rb rubocop: Lint/SendWithMixinArgument 2023-06-09 16:04:56 +00:00
moderation.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
must_view_module_progressor.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
mutable.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
net_ldap_extensions.rb wrap net_ldap_extensions in a zeitwerk compatible module 2021-10-07 18:50:58 +00:00
notification_message_creator.rb cancel_duplicate messages for cross-shard users 2023-06-14 16:05:07 +00:00
open_ai.rb smart search: index existing courses when feature enabled 2023-11-01 22:06:35 +00:00
package_root.rb Remove unnecessary require statements 2023-01-04 21:38:21 +00:00
pandata_events.rb support sending PandataEvents from Canvas 2023-11-30 22:20:26 +00:00
permissions.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
permissions_helper.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
plannable.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
planner_api_helper.rb use unique_constraint_retry for planner ovveride sync 2023-07-28 16:32:53 +00:00
planner_helper.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
progress_runner.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
pronouns.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
quiz_math_data_fixup.rb update rubocop, and apply new cops 2023-07-03 22:11:42 +00:00
request_error.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
rubric_context.rb rubocop: Lint/SendWithMixinArgument 2023-06-09 16:04:56 +00:00
scope_filter.rb RuboCop: Layout lib 2021-09-22 20:01:52 +00:00
score_statistics_generator.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
scrypt_provider.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
search_term_helper.rb Support basic unicode normalization in search helper 2022-02-16 22:19:10 +00:00
send_to_stream.rb rubocop: Lint/SendWithMixinArgument 2023-06-09 16:04:56 +00:00
sentry_proxy.rb Misc changes to kickstart ruby 3.0 testing 2022-12-13 14:27:41 +00:00
session_token.rb RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
simple_stats.rb rubocop: Style/TernaryParentheses, Style/RedundantParentheses 2023-04-12 14:56:48 +00:00
simple_tags.rb rubocop: Lint/SendWithMixinArgument 2023-06-09 16:04:56 +00:00
sis.rb do away with non-conventional "common" module 2021-10-07 21:55:24 +00:00
sorts_assignments.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
ssl_common.rb bundle update multipart-post 2023-08-14 16:37:46 +00:00
stats.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
sticky_sis_fields.rb rubocop: Lint/SendWithMixinArgument 2023-06-09 16:04:56 +00:00
submission_lifecycle_manager.rb Remove DueDateCacher alias 2023-08-15 17:18:14 +00:00
submission_list.rb remove (direct) dependency on hashery 2023-08-30 19:02:57 +00:00
submission_search.rb Update the submission_search so that it can take a user_id 2023-06-22 16:17:02 +00:00
submittable.rb fix n+1s in DiscussionTopicsController#index 2023-10-31 20:50:55 +00:00
submittables_grading_period_protection.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
summary_message_consolidator.rb rubocop: Layout/Multiline*LineBreaks 2023-05-01 19:31:42 +00:00
syslog_wrapper.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
text_helper.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
time_zone_helper.rb rubocop: Layout/Multiline*LineBreaks 2023-05-01 19:31:42 +00:00
timed_cache.rb RuboCop: Style/MethodCallWithoutArgsParentheses 2021-11-18 23:07:30 +00:00
token_scopes.rb hide internal permissions from LTI Advantage Services section 2022-08-29 19:36:02 +00:00
token_scopes_helper.rb Fail a test on route changes used by dev keys 2022-07-12 20:24:05 +00:00
turnitin.rb bundle update multipart-post 2023-08-14 16:37:46 +00:00
turnitin_id.rb add # frozen_string_literal: true for lib 2020-10-27 20:49:50 +00:00
unzip_attachment.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
user_content.rb Change content translations in lib/user_content 2023-11-22 16:40:12 +00:00
user_list.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
user_list_v2.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
user_merge.rb add guard to user merge copy_favorites for null context 2023-10-11 22:28:42 +00:00
user_search.rb scope to active and future enrollments for temp enroll filters 2023-10-17 19:19:51 +00:00
uuid_helper.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
vericite.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
visibility_plucking_helper.rb RuboCop: Style/RedundantSelf 2021-11-20 16:41:21 +00:00
zip_extractor.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00