553b2fe558
this is very difficult to test, because it's a race condition, but the test plan would work... the changes are just plumbing through if the primary db should be used or a replica, and then methods that have been well tested and used. for parallel account_reports we write rows to account_report_rows and then read from account_report_rows to generate the csv file. If this is done on a replica, it can be lagging and not get all the records. Typical reports, this would not be a problem because it is old data for a report... but when we just wrote the data it may not exist, so use the primary database. test plan - run a report with a primary database and read_only replica - pause replication - the report should work fixes PFS-16619 flag = none Change-Id: I93140ce8f566a4e0553377388d6296ec36d800cb Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/248863 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Mark Valentine <mvalentine@instructure.com> QA-Review: Rob Orton <rob@instructure.com> Product-Review: Rob Orton <rob@instructure.com> |
||
|---|---|---|
| .. | ||
| activesupport-suspend_callbacks | ||
| acts_as_list | ||
| adheres_to_policy | ||
| attachment_fu | ||
| autoextend | ||
| bookmarked_collection | ||
| broadcast_policy | ||
| canvas_breach_mitigation | ||
| canvas_cassandra | ||
| canvas_color | ||
| canvas_crummy | ||
| canvas_dynamodb | ||
| canvas_ext | ||
| canvas_http | ||
| canvas_i18nliner | ||
| canvas_kaltura | ||
| canvas_mimetype_fu | ||
| canvas_panda_pub | ||
| canvas_partman | ||
| canvas_quiz_statistics | ||
| canvas_sanitize | ||
| canvas_slug | ||
| canvas_sort | ||
| canvas_stringex | ||
| canvas_text_helper | ||
| canvas_time | ||
| canvas_unzip | ||
| csv_diff | ||
| diigo | ||
| dr_diff | ||
| event_stream | ||
| google_drive | ||
| html_text_helper | ||
| i18n_extraction | ||
| i18n_tasks | ||
| incoming_mail_processor | ||
| json_token | ||
| linked_in | ||
| live_events | ||
| lti-advantage | ||
| lti_outbound | ||
| multipart | ||
| paginated_collection | ||
| plugins | ||
| rubocop-canvas | ||
| stringify_ids | ||
| tatl_tael | ||
| turnitin_api | ||
| utf8_cleaner | ||
| workflow | ||
| README.md | ||
| test_all_gems.sh | ||
README.md
Gems
Testing
To test all the gems:
cd gems
./test_all_gems.sh
To test an individual gem
Run ./test.sh inside the gem's folder. This is basically the same as:
cd gems/google_drive
bundle
rspec