ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
53,664 Commits 324 Branches 20,019 Tags 1.7 GiB
Ruby 51.2%
JavaScript 33.7%
TypeScript 10.3%
HTML 2.5%
SCSS 1.3%
Other 1%
Go to file
Eric Saupe 0b0620ef7e Filter authenticity_token field when disabling 
The authenticity_token is changed from a document event. The disabling
of all input fields causes the form value to be locked in to a possibly
invalid authenticty_token when submitted because the disabling runs
before the document event is able to change it. By leaving this field
available it accepts the change from the document event.

See ui/boot/initializers/injectAuthTokenIntoForms.js

fixes LS-3661
flag=none

test plan:
- Go to the dashboard
- Click the Start a New Course button
- Open the browser developer console
- Find the authenticity_token field in the #new_course_form
- Submit the form
- Verify the field was never disabled
- Verify the course was created

test plan in production:
This is not causing an error locally but is happening in production. To
verify this fix works in production go to the link provided on the ticket
where the problem is seen by impersonating the user.
- Click the Start a New Course button.
- Open the browser developer console.
- Place a breakpoint after the elements are disabled around
jquery.disableWhileLoading.js:77.
- Submit the form.
- Find the authenticty_token field.
- Remove the disabled attribute.
- Allow the flow to continue.
- Verify the course was created.
- Delete the course.

Change-Id: I371a96ceb68fe9dbd19f05d7b5538def5b1b0510
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/307805
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Eric Saupe <eric.saupe@instructure.com>
 		2023-01-04 17:39:11 +00:00
.github update github reviewers list 2022-06-28 19:24:59 +00:00
.storybook Organize backbone code better 2022-11-22 01:22:46 +00:00
.vscode Add configurations to enable remote IDE debugging with rdebug-ide 2021-09-16 18:33:11 +00:00
Gemfile.d Bump some gems for necessary ruby 3.1 transitive deps 2023-01-03 23:31:22 +00:00
app Request internal URL for streaming download and canvadocs inst-fs 2023-01-04 17:29:11 +00:00
bin Don't terminate web container when disconnecting debugger 2022-11-07 15:59:29 +00:00
build Fix linters on ruby 3.1 2022-12-21 15:32:12 +00:00
config Set the lti_multiple_assignment_deep_linking ff on 2023-01-03 19:48:07 +00:00
db/migrate Change dev key scopes that reference old API routes 2023-01-04 16:53:01 +00:00
doc doc: fix typo in LTI postMessages 2023-01-03 16:09:53 +00:00
docker-compose docker-compose config to build:watch es packages 2022-12-15 22:18:24 +00:00
engines RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
gems Downgrade mail gem 2022-12-21 20:08:15 +00:00
hooks Fix git pre-commit hook 2022-03-10 22:50:42 +00:00
jest label unlabeled FormField components 2022-11-04 16:16:05 +00:00
lib Request internal URL for streaming download and canvadocs inst-fs 2023-01-04 17:29:11 +00:00
log Update parallel_runtime_rspec.log from build 264 2021-10-25 16:59:25 +00:00
packages remove old equation editor and related cruft 2022-12-21 14:27:15 +00:00
public Update en.json 2022-08-23 14:54:19 +00:00
script docker-compose config to build:watch es packages 2022-12-15 22:18:24 +00:00
spec Refactor dev key scope fixup 2023-01-04 16:52:38 +00:00
tmp Alpine canvas-lms based image 2020-07-15 17:21:56 +00:00
ui Filter authenticity_token field when disabling 2023-01-04 17:39:11 +00:00
ui-build Organize backbone code better 2022-11-22 01:22:46 +00:00
.codeclimate.yml disable ESLint in code climate 2017-02-14 17:47:39 +00:00
.dive-ci Spec: Add dive build 2020-03-26 14:52:06 +00:00
.dockerignore (i18n-js:5) flatten translation files 2022-06-27 18:35:04 +00:00
.editorconfig
…
.eslintignore Speed up ESLint 2022-10-16 21:16:17 +00:00
.eslintrc.js Resolve ESLint warnings 2022-10-28 20:24:33 +00:00
.git-blame-ignore-revs Hide Prettier formatting commit from git blame 2022-09-29 22:49:12 +00:00
.gitignore Speed up ESLint 2022-10-16 21:16:17 +00:00
.gitmessage prepend some blank lines to .gitmessage 2019-08-09 16:12:53 +00:00
.groovylintrc.json stop loading webpack-builder image twice before running JS specs 2022-08-17 13:45:40 +00:00
.i18nignore Don't try to extract translations from vendor 2022-03-03 17:48:51 +00:00
.i18nrc (i18n-js:4) use i18nliner-canvas from npm 2022-06-23 18:42:23 +00:00
.irbrc disable irb autocomplete 2022-03-29 21:34:33 +00:00
.lintstagedrc.js Initial pace plans import 2021-09-01 19:58:33 +00:00
.npmrc
…
.nvmrc upgrade node from 14.x to 16.x 2022-07-12 12:41:09 +00:00
.prettierrc Use trailing commas where valid in ES5 2022-09-23 19:05:01 +00:00
.rspec spec: automatically require spec_helper 2021-10-26 17:39:19 +00:00
.rubocop.yml replace default_scope override with rubocop linter 2022-11-22 19:42:05 +00:00
.sentryignore Only upload production source maps to Sentry 2022-03-24 18:17:54 +00:00
.stylelintrc modernize canvas_quizzes 2021-01-14 22:45:10 +00:00
.travis.yml
…
CONTRIBUTING.md Remove more freenode references 2021-06-02 16:18:53 +00:00
COPYRIGHT
…
Dockerfile docker-compose config to build:watch es packages 2022-12-15 22:18:24 +00:00
Dockerfile.githook Add precommit hook for auto fixing files 2018-11-27 21:07:31 +00:00
Dockerfile.jenkins remove fontforge from jenkins build images 2022-09-01 17:50:38 +00:00
Dockerfile.jenkins-cache split vendor overrides into own file 2022-11-30 15:22:04 +00:00
Dockerfile.jenkins.final split vendor overrides into own file 2022-11-30 15:22:04 +00:00
Dockerfile.jenkins.js use bind mounts for cache helper image copies 2022-09-26 11:51:46 +00:00
Dockerfile.jenkins.linters-final remove need to mount .git directory as volume for Linters 2021-05-10 18:57:42 +00:00
Dockerfile.jenkins.linters-runner Revert "Replace old config ymls with newer mutagen ymls" 2022-03-28 17:38:37 +00:00
Dockerfile.jenkins.ruby-runner try to fix bundle install intermittent failure 2022-11-29 19:34:37 +00:00
Dockerfile.jenkins.webpack-assets use bind mounts for cache helper image copies 2022-09-26 11:51:46 +00:00
Dockerfile.jenkins.webpack-builder use bind mounts for cache helper image copies 2022-09-26 11:51:46 +00:00
Dockerfile.jenkins.webpack-cache cache compiled webpack assets 2022-09-27 19:43:55 +00:00
Dockerfile.jenkins.webpack-runner split vendor overrides into own file 2022-11-30 15:22:04 +00:00
Dockerfile.jenkins.yarn-runner use bind mounts for cache helper image copies 2022-09-26 11:51:46 +00:00
Dockerfile.package-translations Make package-translations build fail when it fails 2022-10-21 13:29:29 +00:00
Gemfile RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
Jenkinsfile allow forcing crystal ball to run despite config changes 2022-10-18 16:32:35 +00:00
Jenkinsfile.axe always upload junit results as artifact 2022-06-10 15:07:32 +00:00
Jenkinsfile.cassandra fix docker sync job 2021-10-01 15:11:55 +00:00
Jenkinsfile.contract-tests spec: Remove Quizzes Pact Contracts 2022-08-30 02:59:30 +00:00
Jenkinsfile.coverage fix skipped spec reporting 2022-06-10 17:16:51 +00:00
Jenkinsfile.coverage-js add jest coverage in js coverage report 2022-03-29 19:50:14 +00:00
Jenkinsfile.crystalball rename webpack-cache image to webpack-assets 2022-09-20 16:57:47 +00:00
Jenkinsfile.dive fix jenkins file linter issues autofixable 2021-05-18 16:48:15 +00:00
Jenkinsfile.docker-smoke allow node label to be overridden for testing 2022-06-29 14:41:05 +00:00
Jenkinsfile.docker-sync updgrade Jenkins Chrome version 107 2022-12-06 02:28:57 +00:00
Jenkinsfile.dynamodb fix docker sync job 2021-10-01 15:11:55 +00:00
Jenkinsfile.js updgrade Jenkins Chrome version 107 2022-12-06 02:28:57 +00:00
Jenkinsfile.junit-uploader allow node label to be overridden for testing 2022-06-29 14:41:05 +00:00
Jenkinsfile.master-bouncer-check-all fix docker sync job 2021-10-01 15:11:55 +00:00
Jenkinsfile.package-translations More translations build improvements 2021-06-30 15:32:09 +00:00
Jenkinsfile.parallel_logs fix jenkins file linter issues autofixable 2021-05-18 16:48:15 +00:00
Jenkinsfile.postgres update copyright disclaimer 2021-10-01 15:44:27 +00:00
Jenkinsfile.redis improve readability jenkins redis 2021-11-18 20:17:08 +00:00
Jenkinsfile.rspecq support globs in node count computation 2022-10-19 11:24:49 +00:00
Jenkinsfile.selenium.flakey_spec_catcher spec: Re-enable HTML editor sanitize HTML spec 2022-08-23 15:05:30 +00:00
Jenkinsfile.selenium.performance.chrome remove mostly useless copy files script 2022-06-09 15:16:39 +00:00
Jenkinsfile.test-subbuild fix jenkins file linter issues autofixable 2021-05-18 16:48:15 +00:00
Jenkinsfile.vendored-gems allow node label to be overridden for testing 2022-06-29 14:41:05 +00:00
Jenkinsfile.xbrowser fix docker sync job 2021-10-01 15:11:55 +00:00
LICENSE
…
README.md Update README.md since Canvas is still modern 2016-12-15 03:18:28 +00:00
Rakefile RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
bower.json Move k5uplodaer to /packages 2019-05-10 18:30:51 +00:00
code_of_conduct.md
…
config.ru RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 2021-11-25 14:03:06 +00:00
docker-compose.new-jenkins-flakey-spec-catcher.yml update fsc to go into the plugin directory to do tests 2020-06-17 14:58:09 +00:00
docker-compose.new-jenkins-js.yml remove translations/_core_en.js in production try 2 2022-02-18 00:08:38 +00:00
docker-compose.new-jenkins-package-translations.yml Create shared translation infrastructure for packages 2019-11-06 22:42:03 +00:00
docker-compose.new-jenkins-selenium.yml updgrade Jenkins Chrome version 107 2022-12-06 02:28:57 +00:00
docker-compose.new-jenkins.consumer.yml Bump rails 2021-12-23 15:26:13 +00:00
docker-compose.new-jenkins.vendored-gems.yml extract canvas::redis to canvas_cache 2021-03-02 14:38:55 +00:00
docker-compose.new-jenkins.yml don’t perform redundant DB operations in Jenkins test runs 2022-06-01 17:42:18 +00:00
docker-compose.spring.yml (i18n-js:4) use i18nliner-canvas from npm 2022-06-23 18:42:23 +00:00
docker-compose.yml Revert "asset install in Dockerfile" 2021-06-29 13:36:09 +00:00
gulpfile.js Fix yarn install error with @canvas/engine 2022-07-15 14:51:56 +00:00
issue_template.md Update community urls to reflect platform move 2020-08-12 20:17:02 +00:00
jest.config.js enforce strict Jest test time limits for build health 2022-08-09 13:32:17 +00:00
karma.conf.js Improve Karma test loading 2022-10-12 18:23:35 +00:00
package.json bump tinymce-a11y-checker dependency w/in canvas 2022-12-05 20:14:17 +00:00
tsconfig.json Speed up ESLint 2022-10-16 21:16:17 +00:00
webpack.config.js move crystalball webpack config into ui-build 2022-01-12 20:19:41 +00:00
yarn.lock Always use native fullscreen 2022-12-06 15:35:10 +00:00

README.md

Canvas LMS

Canvas is a modern, open-source LMS developed and maintained by Instructure Inc. It is released under the AGPLv3 license for use by anyone interested in learning more about or using learning management systems.

Please see our main wiki page for more information

Installation

Detailed instructions for installation and configuration of Canvas are provided on our wiki.