ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/spec
History
Sarah Gerard 08d9ceb884 move SQL from UngradedDiscussionStudentVisibility view to rails 
moving logic from a view (that has become too complex
to properly push down WHERE clause predicates) to a
service.  The SQL is existing view definition SQL,
from MigrationHelpers::StudentVisibilities::StudentVisibilitiesV7
with the improvements recommended by DBAs (don't use a view;
put the WHERE clause on each SELECT in the UNION or EXCEPT)

New tests call this service, but no application
code is calling it yet.

flag = differentiated_modules

refs LX-1727

Test Plan:
  - tests pass

Change-Id: Ia6f3fd3f6edc4f90f5d0686ce8f84e38c722d6fb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348646
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jen Smith <jen.smith@instructure.com>
QA-Review: Jen Smith <jen.smith@instructure.com>
Product-Review: Jen Smith <jen.smith@instructure.com>
 		2024-05-30 17:36:16 +00:00
..
apis Add checkpoint data to submissions and assignment group API response 2024-05-30 16:17:02 +00:00
coffeescripts unify SpeedGrader text 2024-05-29 18:41:43 +00:00
contracts Remove Canvas Outcome Pact Tests 2023-11-29 18:00:03 +00:00
controllers Add checkpoint data to submissions and assignment group API response 2024-05-30 16:17:02 +00:00
factories support API Lti::Registration delete 2024-05-28 23:36:33 +00:00
factory_bot rubocop: FactoryBot 2024-03-01 22:27:49 +00:00
fixtures rails 7.1: use fixture_file helper 2024-02-20 17:51:31 +00:00
formatters update rubocop, and apply new cops 2023-07-03 22:11:42 +00:00
gem_integration/canvas_connect
…
graphql Discussion Redesign 'Quote Reply' removes bullet points 2024-05-30 06:27:51 +00:00
helpers Sortable User Course List 2024-05-29 17:42:41 +00:00
initializers spec: fix timebomb with partitions 2024-03-22 16:42:36 +00:00
integration unify SpeedGrader text 2024-05-29 18:41:43 +00:00
javascripts unify SpeedGrader text 2024-05-29 18:41:43 +00:00
lib bundle update rubocop 2024-05-30 16:20:52 +00:00
manual_seeding unify SpeedGrader text 2024-05-29 18:41:43 +00:00
messages spec: Add test for checkpoints created notification. 2024-05-01 18:14:34 +00:00
migrations squash old migrations 202308 2024-03-08 20:36:11 +00:00
models move SQL from UngradedDiscussionStudentVisibility view to rails 2024-05-30 17:36:16 +00:00
observers Push content_export_created live event from Canvas 2024-02-16 18:03:54 +00:00
openapi/lti spec: Update schema definitions for recent changes 2024-02-01 23:40:01 +00:00
presenters Remove more settings 2024-01-29 16:21:38 +00:00
requests bundle update rubocop 2023-10-27 17:05:57 +00:00
schemas/lti
…
selenium bundle update rubocop 2024-05-30 16:20:52 +00:00
serializers unify SpeedGrader text 2024-05-29 18:41:43 +00:00
services move SQL from UngradedDiscussionStudentVisibility view to rails 2024-05-30 17:36:16 +00:00
shared_examples bundle update rubocop 2024-01-24 16:17:43 +00:00
support bundle update rubocop 2024-05-30 16:20:52 +00:00
views unify SpeedGrader text 2024-05-29 18:41:43 +00:00
.eslintrc
…
.rspec_parallel
…
ams_spec_helper.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
broadcast_integration.rb
…
canvas_simplecov.rb
…
cassandra_spec_helper.rb
…
conditional_release_spec_helper.rb rubocop: FactoryBot 2024-03-01 22:27:49 +00:00
coverage_tool.rb
…
factories.rb bundle update rubocop-performance, rubocop-rails 2023-12-18 20:28:02 +00:00
factory_bot_spec_helper.rb
…
feature_flag_helper.rb
…
file_upload_helper.rb
…
force_failure_spec.rb
…
import_helper.rb remove unused Course#import_source attr_accessor 2024-02-02 18:06:19 +00:00
jspec.sh
…
lti2_course_spec_helper.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
lti2_spec_helper.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
lti_1_3_spec_helper.rb sync DeveloperKey and Lti::Registration on save 2024-05-28 22:05:02 +00:00
lti_1_3_tool_configuration_spec_helper.rb Lock down submission_type_selection placement 2024-03-07 13:58:16 +00:00
lti_spec_helper.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
outcome_alignments_spec_helper.rb Update GraphQL Alignment loader to return aligned items 2023-05-11 15:57:34 +00:00
plagiarism_platform_spec_helper.rb bump rubocop gems and apply changes 2023-08-07 20:13:35 +00:00
quiz_spec_helper.rb
…
rcov.opts
…
rspec_mock_extensions.rb Rubocop for ruby 3.1 2023-06-06 16:44:26 +00:00
sharding_spec_helper.rb
…
simple_cov_result_merger.rb
…
spec.opts
…
spec_helper.rb bundle update rubocop 2024-05-30 16:20:52 +00:00