ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
17,606 Commits 324 Branches 20,019 Tags 1.7 GiB
Ruby 51.2%
JavaScript 33.7%
TypeScript 10.3%
HTML 2.5%
SCSS 1.3%
Other 1%
Go to file
Ryan Shaw 079c9e272c don't proceed like normal if brandable_css cmd fails 
fixes: CNVS-23632

it turns out, the way I was doing this ruby would
create a sh subprocess and brandable_css would 
be it's subprocess. so $? would be the sh process
(which would always exit successfully).

test plan:
* in theme editor, try to preview a theme
* but before you do, do something to make it so
brandable_css will fail (like uninstall node or 
rm -rf node_modules or use activity monitor to view
active processes and kill brandable_css when 
it appears)
* it should say "something went wrong generating..."
  instead of continuing like everything worked

Change-Id: I3c80c18381bb52c71d4b79d5b151988d6cf5cc3b
Reviewed-on: https://gerrit.instructure.com/63948
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
 		2015-09-30 21:37:45 +00:00
Gemfile.d bump switchman 2015-09-22 00:32:13 +00:00
app Convert FlashMessageHolder to a dumb component with tests 2015-09-30 21:32:14 +00:00
bin rails 4.0.10 2014-09-16 22:07:39 +00:00
client_apps address use of ic-brand-secondary within quiz attempt audit 2015-09-30 14:30:17 +00:00
config adds UI & backend for offline content 2015-09-30 16:22:18 +00:00
db/migrate adds UI & backend for offline content 2015-09-30 16:22:18 +00:00
doc tweak docker dev docs for latest recommendations 2015-09-25 16:58:17 +00:00
docker-compose switch docker dev env to use node 0.12 2015-09-14 18:54:14 +00:00
gems improve name inference 2015-09-29 05:33:42 +00:00
guard move 'parallel' gem to the everything group 2015-07-20 22:03:21 +00:00
lib don't proceed like normal if brandable_css cmd fails 2015-09-30 21:37:45 +00:00
public publish files when publishing module 2015-09-30 00:09:42 +00:00
script fix script/canvas_update to work with brandable_css 2015-07-07 20:41:28 +00:00
spec Convert FlashMessageHolder to a dumb component with tests 2015-09-30 21:32:14 +00:00
.bowerrc introduced bower to manage js dependencies 2013-12-13 17:45:57 +00:00
.dockerignore docker-compose based dev environment 2015-03-30 20:59:48 +00:00
.fontcustom-manifest.json Make LTI configurations accept canvas icon class 2015-09-21 17:59:40 +00:00
.gitignore Prevent generated mkmf.log from accidently being put in git 2015-08-05 15:41:09 +00:00
.i18nignore bump rails 3 to github branch for ruby 2.2 compatibility 2015-02-18 22:55:20 +00:00
.jshintrc make jslint settings more sane 2012-08-17 11:04:40 -06:00
.rubocop.yml parallel assignment is ok 2015-09-03 23:29:02 +00:00
.travis.yml more travis builds 2014-02-10 16:23:19 +00:00
CONTRIBUTING.md Update Contributing.md with better information 2015-08-14 17:04:39 +00:00
COPYRIGHT Initial commit. 2011-01-31 18:57:29 -07:00
Gemfile use eval_gemfile for bundler goodness 2015-02-18 18:15:14 +00:00
Guardfile ensure node_modules are up-to-date for guard & compile_assets 2015-07-16 19:17:54 +00:00
LICENSE Initial commit. 2011-01-31 18:57:29 -07:00
README.md remove travis.ci badge until we are re-enabled 2014-07-01 23:08:00 +00:00
Rakefile remove rails 2 support 2014-08-06 18:16:19 +00:00
bower.json Move Moderated Grading to Redux 2015-09-22 21:37:08 +00:00
code_of_conduct.md contributor code of conduct 2014-12-23 18:13:59 +00:00
config.ru start adding rails 3.0 support 2013-03-22 19:08:40 +00:00
docker-compose.yml make selenium docker-compose service commented out by default 2015-09-16 21:23:03 +00:00
gulpfile.babel.js make sure plugin javascript bundles make it to CDN 2015-08-03 20:46:39 +00:00
karma.conf.js upgrade karma 2015-07-17 04:50:07 +00:00
package.json explicit jsdom and qunit dependencies for npm v3 2015-09-21 22:27:02 +00:00

README.md

Canvas LMS

Canvas is a new, open-source LMS by Instructure Inc. It is released under the AGPLv3 license for use by anyone interested in learning more about or using learning management systems.

Please see our main wiki page for more information

Installation

Detailed instructions for installation and configuration of Canvas are provided on our wiki.