Fixing this required some minor refactoring:
* A model can now define "filter_hash_for_user" to filter serialized data out
of the model based on user. In this case, we were sending the assignment to
the browser in json, and we wanted to strip out the description if the
assignment was locked for the user.
* The lock_explanation generator was not i18n'd before. That was fixed, and
similar code in javascript was also refactored so it can be called by
anybody. (In this case, by the assignments in the calendar.)
Change-Id: Ia606be2a16df9bd87222306445f548b3a7a78801
Reviewed-on: https://gerrit.instructure.com/5051
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
closes#4623
also fixes the UI for "what-if" score showing when you really can't
use them
Change-Id: I19a5f41512e0d162a78c10b0c7c23f22624b6af0
Reviewed-on: https://gerrit.instructure.com/5030
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Whitmer <brian@instructure.com>
technically, you're editing the rubric evaluation, but users don't
get that
Change-Id: I1fafa6223209fd5ecb84a277f84577193e5f1ddb
Reviewed-on: https://gerrit.instructure.com/5008
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
When including a scrape function to pageless, the data after scraping was
being dumped into the DOM incorrectly. This fixes that, and includes a test
for the announcements page.
(The bug was originally seen on the inbox, but rather than write a spec for
code that won't last much longer, I wrote the test for somewhere else.)
Change-Id: If4ca0cbed89dcf6e6e24e814f75824266422cbfa
Reviewed-on: https://gerrit.instructure.com/4992
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Tested-by: Selenium <selenium@instructure.com>
so developers can run rake i18n:generate_js without having a dirty assets.yml
Have to be magical about merging though two using erb in the real assets.yml.
Also split _core.js into _core_en.js (committed to repo) and everything else
in _core.js (not in repo), for the same reason.
Change-Id: I4749ee5818b9e7d4e1244c6e8295790bb1235e34
Reviewed-on: https://gerrit.instructure.com/4972
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
slideUp and slideDown were being used "show" and "hide", but sometimes
they would get called multiple times in a row, making file upload errors
go away obnoxiously quickly and so forth.
with this abstraction, a displayed message will always get at least 3
seconds of user visibility before being hidden
Change-Id: Id3c5749a1778bec2896fa0399df731c6967e4a2d
Reviewed-on: https://gerrit.instructure.com/4817
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
data.filename was not being populated, so the filename field
of the multipart request was empty, causing rack to just throw
it away. NOTE: rack throws away fields if you provide filename=""
with content-disposition file.
fixes#5154
Change-Id: If6f0a3a818aaa2f97ee4aded4bea80063209b12a
Reviewed-on: https://gerrit.instructure.com/4840
Tested-by: Hudson <hudson@instructure.com>
Tested-by: Selenium <selenium@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
also switched to storing profile pictures in a new folder ("profile pictures")
so that users will not see a ton of unrelated pictures.
Change-Id: Ia2fd55e1c090db886349319613a7d5ecb33805ac
Reviewed-on: https://gerrit.instructure.com/4950
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
also removed some dead code. still need to do dates and times
Change-Id: Iac2e036d839cb0a2ae7c53c95ee05ff59cb3684f
Reviewed-on: https://gerrit.instructure.com/4924
Reviewed-by: Jon Jensen <jon@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
rather than display oriented version. also let's us get more flexible
with casing ("TA" shouldn't be "ta") and sets us up for i18n.
Change-Id: I3bb68ef1ffeae7d03b38cbb41f4c45bcfeee3946
Reviewed-on: https://gerrit.instructure.com/4923
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
ordinalization doesn't localize well, and the new version ("student n of
m") will be clearer for translators as well. kill now unused and
problematic $.ordinalize
Change-Id: Ie8f4169d385ffa1e8c4ea5beac18e5f429ea2c59
Reviewed-on: https://gerrit.instructure.com/4922
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
* referenceOffset was never used, and was the only thing the quiz
utc_offset was referenced by
* assignment_due_at_span was read in js, but the js variable was never
used
* date_header partial never used
* render :collection => [] is a no-op
* assignment's date_sortable field never referenced
Change-Id: Ie6d1deff3efb8f3b6caa01905ec79ac9a4140eb3
Reviewed-on: https://gerrit.instructure.com/4921
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
changes:
* a little i18n work
* show only a certain section
* show attendance
* include ungraded assigments in score
* don't wait for first xhr to fire second
* cool drop down menu thing
Change-Id: Ie93fd06e20aec399710e32441f8d35c686fbbaf2
Reviewed-on: https://gerrit.instructure.com/4868
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Whitmer <brian@instructure.com>
- fixed the link on a teacher page in a course to show the report
for that teacher for all students in the course
- added days since submitted for each ungraded assignment
- added sorting of columns
- added link to one-click to message a specific student. This link
will only appear of the current user is a teacher in the course
Change-Id: Ic39ba72fd210411def178dc69ff35006abe96043
Reviewed-on: https://gerrit.instructure.com/4707
Reviewed-by: Brian Whitmer <brian@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
We require a term now, there is not all-terms full batch mode anymore.
Change-Id: I85edd67afcfcf86916c93904a7c1a3cfb1f66dba
Reviewed-on: https://gerrit.instructure.com/4850
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: JT Olds <jt@instructure.com>
if you minimize a column to it's smallest size
it will change it's formatting and show a tooltip
on hovering. it will also remember you hid it
(per browser/user) and not show it in future.
click a column header to sort.
drag/drop assignment column headers to reorder
(will not be remembered for now)
Change-Id: Ia9d1d8e1bb82ebde85d87fedae80c1d7feb46b6f
Reviewed-on: https://gerrit.instructure.com/4642
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
this was especially needed for the minimizing of
columns in gradebook 2
Change-Id: If6f6bfce25f0dba33c969b2365353b701e7e5429
Reviewed-on: https://gerrit.instructure.com/4639
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
we were adding files to the queue, and then calling uploadNext with
that file specifically. when uploadNext got called again it would find
the same file in the queue and try again.
now just add it to the queue and then process the queue
refs #5143
Change-Id: I53476b3170169a9dc60a9e5edf69a119e2795fbd
Reviewed-on: https://gerrit.instructure.com/4818
Tested-by: Hudson <hudson@instructure.com>
Tested-by: Selenium <selenium@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
also fixed an importer issue, and removed translated js files from
version control (we'll generate them as part of the deploy)
Change-Id: I10be3ab1f4567a1534774f514424fd9966982c62
Reviewed-on: https://gerrit.instructure.com/4686
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
* infini-scroll images tab of wiki side bar
* load file tree piecemeal in wiki_sidebar
* load folder tree only if needed
Change-Id: Ib8d5cb567df8a2ee79935ffb3f8678a7ee5427fe
Reviewed-on: https://gerrit.instructure.com/4671
Tested-by: Hudson <hudson@instructure.com>
Tested-by: Selenium <selenium@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
There's a problem where if you start to create a quiz from the
assignments list page and click "more options", you won't be able
to actually save the assignment. The problem is that the form
validation is failing, because the "Submission:" option is set to
"Online Submission" but no submission types are selected.
However, since this option is hidden on quiz type assignments,
the validation error bubble never appears and the form just
won't submit.
fixes#5023
Change-Id: Iecb843980b7e1c56fff313331bd30d2a79eee9d8
Reviewed-on: https://gerrit.instructure.com/4613
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
also enabled en fallbacks (this is only needed for things that don't
have an explicit default, like localize calls)
includes auto-generated js translation files
Change-Id: If246a6a96b1e9f6934f84ff6e65e0372a60d247a
Reviewed-on: https://gerrit.instructure.com/4597
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
This reverts commit 7eb99b681f.
Commit wasn't behaving well with 11:59pm dates. Will revisit as part of
my datetime revamp WIP.
Change-Id: I5dc6396f79201349409cc86f7398712469ec9248
Reviewed-on: https://gerrit.instructure.com/4662
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
The Kaltura widget makes javascript callbacks by calling functions on the
current window by name. The i18n scope was hiding those, so we'll put them on
window explicitly.
Change-Id: Ibe3cbac87c56eeb4f971c6e68ea0004d52a75c48
Reviewed-on: https://gerrit.instructure.com/4651
Reviewed-by: Brian Palmer <brianp@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
also adds enrollments in batches, instead of one at a time via ajax.
closes#4835
Change-Id: Ic2aac24db2c4d5fb4482901daf8627419c548e37
Reviewed-on: https://gerrit.instructure.com/4584
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Most of this code was actually getting completely
bypassed because of some bad logic. This now tries
to enforce storage quota limits with exceptions for
things like turning in homework.
Change-Id: Id025bcdcd40c560a22368dc84686a1307296e053
Reviewed-on: https://gerrit.instructure.com/4452
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: JT Olds <jt@instructure.com>
added checks to extractor for some common typos/oversights (and more line numbers)
Change-Id: I7a2b080cf2a26cb6711539220fe2486a1a4f04b5
Reviewed-on: https://gerrit.instructure.com/4581
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Zach Wily