Commit Graph

18 Commits

Author SHA1 Message Date
Cody Cutrer aa7041d2c1 update rubocop, and apply new cops
[skip-stages=Flakey]

Change-Id: I2d3ffbeb652a6668941125a8a2afe87f104c8d0a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/321953
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-07-03 22:11:42 +00:00
Jacob Burroughs 6fd442cf8b Complete ruby 3.1 support
Change-Id: I954402cb7016c1590748f149279865db967272a3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/308110
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
2023-01-04 18:02:40 +00:00
Cody Cutrer 103dce1f4a add frozen_string_literal comment to binaries
Change-Id: I4d0b95c1f22891772cfdc8a20adf0ff1e1bc8a8b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/261819
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2021-03-30 18:14:03 +00:00
Rex Fleischer 9454b7cd97 remove skipping linters if whitelisted engineer
fixes: CCI-362
flag = none

Test-Plan:
build passes

Change-Id: Ied7b5c1923bb1c5e0314b13b7cab8d9e9a93028a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/236433
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
Product-Review: Gentry Beckmann <gbeckmann@instructure.com>
QA-Review: Rex Fleischer <rfleischer@instructure.com>
2020-05-08 15:17:49 +00:00
Landon Wilkins 9f47ed9a91 copyright linter auto correct, refs SD-2295
test plan:
* create a new file "test.rb"
* add "AUTO_CORRECT_LINTERS=1" to your .env
* install the pre-commit hook:
  echo "bin/lint" >> .git/hooks/pre-commit
  chmod +x .git/hooks/pre-commit
* git add .
* git commit -m "this should fail"
* verify the commit fails
* add the auto-corrected test.rb
* try to commit again
* verify it commits successfully

Change-Id: I3d52d6b192ca3bd83266a3e58d594acc3c516782
Reviewed-on: https://gerrit.instructure.com/111088
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2017-05-11 20:06:08 +00:00
Landon Wilkins c83a8e8aa0 custom comment generation for script/tatl_tael, refs SD-2295
test plan:
* tatl_tael still works (see test commits)

Change-Id: I1854693bd665f4018d1f0475dc922ac360b8d8d8
Reviewed-on: https://gerrit.instructure.com/109783
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2017-05-04 20:13:55 +00:00
Landon Wilkins 87ba5f0e90 cleanup tatl_tael, refs SD-2295
better foundation for more complex linters

test plan:
- tatl_tael still works (see test commits)

Change-Id: Iff463b69e7acf873418842883dbcab38c83b798b
Reviewed-on: https://gerrit.instructure.com/109373
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2017-04-26 15:27:44 +00:00
Landon Wilkins e2f918a8fd update tatl_tael's user_config location
this portion of rubocop-canvas has been ported to dr_diff

Change-Id: I651b6a012dee93935f23358024dccd8e0df62694
Reviewed-on: https://gerrit.instructure.com/93001
Tested-by: Jenkins
Reviewed-by: Shawn Meredith <shawn@instructure.com>
Product-Review: Shawn Meredith <shawn@instructure.com>
QA-Review: Shawn Meredith <shawn@instructure.com>
2016-10-18 21:27:59 +00:00
Ryan Shaw 61fac3281d fix missing quotes in rubocop message
Change-Id: I8940ce1091e8498d4d3e96dc379dada6c88fa8db
Reviewed-on: https://gerrit.instructure.com/89218
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2016-09-07 15:46:49 +00:00
Ryan Shaw cd03c7f8b6 Add helpful gergich suggestion about ERB warning
Change-Id: Id158bac164b3fdb989ed27faef085f4600ccabf6
Reviewed-on: https://gerrit.instructure.com/88425
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
Tested-by: Jenkins
2016-08-22 20:47:31 +00:00
Landon Wilkins 31e90c0ce6 allow jsx tests for coffee changes, fixes SD-1261
test plan:
* test commit

Change-Id: I9e3da787a56467c886d1e70f107b3abb916c6d1e
Reviewed-on: https://gerrit.instructure.com/82842
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins
2016-06-17 17:28:43 +00:00
James Williams 0622fb51e9 enhance tatl_tael user experience
Change-Id: I793ce5d14a3da5ff153fc60ad52f2d567bdc2137
Reviewed-on: https://gerrit.instructure.com/81017
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
2016-06-01 12:52:29 +00:00
Landon Wilkins 216ab2181f improve tatl_tael for public/javascripts changes, fixes SD-1196
test plan:
* test commit

Change-Id: Iba8695913f05876dc076e2bb7b1e6d0584ad0710
Reviewed-on: https://gerrit.instructure.com/80944
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins
2016-05-27 23:36:27 +00:00
Landon Wilkins 9244598c91 make tatl_tael lint on Lint-Review, fixes SD-1176
test plan:
* test commit

Change-Id: I834581ac16c7ccaee07e1c5e02aff74da1ad30c2
Reviewed-on: https://gerrit.instructure.com/80518
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins
2016-05-24 20:11:14 +00:00
Landon Wilkins c332022162 tatl_tael suggest type of spec, fixes SD-1080
test plan
* test commit

Change-Id: I09e55588027cd609d00e5066c6de04f1c2018a25
Reviewed-on: https://gerrit.instructure.com/79692
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2016-05-23 20:38:20 +00:00
Landon Wilkins b7f3541edf tatl_tael linter ignore wips, fixes SD-1094
test plan:
* see test commit

Change-Id: I63d6df91bc4636f9cfd91fca6bcb8ec33d2776f1
Reviewed-on: https://gerrit.instructure.com/79020
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
2016-05-13 16:26:20 +00:00
Landon Wilkins 6e4838856e lint: discourage new .erb files, fixes SD-871
test plan:
* specs
* see test commit

Change-Id: Ia8084890312b674cc30a60077e9b2643d769cd4b
Reviewed-on: https://gerrit.instructure.com/78425
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2016-05-02 16:16:53 +00:00
Landon Wilkins 9dc6299c38 lint: encourage specs, fixes SD-1024
test plan:
- change a file w/ a path that matches:
/(app|lib|public)\/.*\.(coffee|js|jsx|html|erb|rb)$/
but not:
/(bower|mediaelement|shims|vendor)\//
- ./script/tatl_tael
- verify you see:
  [error] => Your commit does not include specs. Please add some to
             verify your changes.

Change-Id: I725daf72c14180bb29c440f9867244a43dc5169d
Reviewed-on: https://gerrit.instructure.com/77579
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2016-05-02 16:16:44 +00:00