only the Jenkinsfile.test-subbuild is using print-env-excluding-secrets
rather than the canvas-builds-library cleanAndSetup, change to use
canvas-builds-library and remove print-env-excluding-secrets
flag = none
Change-Id: I6109ab4d981d52286c85f1a2c887332bcb5efb17
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244822
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
fixes: CCI-389
Test-Plan:
we need to run all the builds that we can for this:
- the current build needs to pass
- main-for-plugins needs to be ran
- master-bouncer
- dive?
- translations
Change-Id: Iae7f9dad7668b90653a0b9a8edc20ec69fa109c3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/240345
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Ryan Norton <rnorton@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Product-Review: Rex Fleischer <rfleischer@instructure.com>
Closes: CCI-368
flag = none
Test Plan:
- All builds now have timestamps in the logs
Change-Id: I76f6b329c1b7f04511c6f63643964d6ccc8aa350
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/236719
Reviewed-by: James Butters <jbutters@instructure.com>
Reviewed-by: Jacob Powell <spowell@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Derek Bender <djbender@instructure.com>
Product-Review: Derek Bender <djbender@instructure.com>
Filters keys ending in _KEY or _SECRET
Closes: CCI-202
flag = none
Test Plan:
- keys like GERGICH_KEY are no longer printed in the builds
Change-Id: I3c6b7cc882ba36b291dc44ac5fe9c958aa24cd60
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/224898
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Powell <spowell@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
there is also quite a few changes to the build configurations:
- main-from-plugin changes
- add CANVAS_LMS_REFSPEC to build params and default to master
- add GERRIT_CHANGE_COMMIT_MESSAGE param so it can be passed
in for manual builds
- _all_ test-suites builds
- add a CANVAS_LMS_REFSPEC and default it to $GERRIT_REFSPEC:$GERRIT_REFSPEC
- update pipeline repo refspec to $CANVAS_LMS_REFSPEC
this will allow parent builds to override what _canvas_ refspec is used
in subbuilds. this gives us a few things:
- the plugins build can override to use master
- the plugins build can test changes via manual builds
- the main build is unchnaged
fixes: CCI-60
Test-Plan:
there was quite a bit of trial and error in this change, so looking
at thoses could help. but for direct QA, we need:
- to ensure that the main build is not changed (this commit passes normally)
- ensure this gets pulled and ran from a manual build in main-from-plugins
Change-Id: Ia292015874727bf8afabd90c9d246770d717b7fc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/219668
Reviewed-by: S. Jacob Powell <spowell@instructure.com>
Reviewed-by: Robert Lamb <rlamb@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Rex Fleischer <rfleischer@instructure.com>
Product-Review: Rex Fleischer <rfleischer@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jenkins
Andrea Cirulli