canvas-lms

Commit Graph

Author	SHA1	Message	Date
Aaron Ogata	2d080018da	fix JS job sanity around COVERAGE var refs DE-462 Change-Id: Ie5bce0bdf0e7a16eb9424813abd49000d5d819d2 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/257532 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Kyle Rosenbaum <krosenbaum@instructure.com> QA-Review: Aaron Ogata <aogata@instructure.com> Product-Review: Aaron Ogata <aogata@instructure.com>	2021-01-27 16:24:14 +00:00
Clay Diffrient	2dc1d7fa86	Add a way to generate better js coverage This should pick up coverage from both karma and jest in Canvas proper. It should also pick up coverage from anything under packages/* closes CORE-1265 Test Plan: - Run `COVERAGE=true yarn test` - Coverage reports (coverage-final.json) should generate in all packages such as (canvas-planner) as well as in coverage-karma and coverage-jest - Run `yarn run test:coverage` - coverage-js folder should be generated. Opening index.html should show the full coverage report - Remove coverage-{js, karma, jest} and packages/canvas-planner/coverage as well as .nyc_output to get back to a clean state - Run `RUN_TESTS_FIRST=true yarn run test:coverage` - All tests should run and generate the appropriate report just like the last time in coverage-js Change-Id: I50744b8977e0683e079af5bdd2865dbcd6ad9066 Reviewed-on: https://gerrit.instructure.com/146098 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>	2018-07-17 14:19:03 +00:00

Author

SHA1

Message

Date

Aaron Ogata

2d080018da

fix JS job sanity around COVERAGE var

refs DE-462

Change-Id: Ie5bce0bdf0e7a16eb9424813abd49000d5d819d2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/257532
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Kyle Rosenbaum <krosenbaum@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>

2021-01-27 16:24:14 +00:00

Clay Diffrient

2dc1d7fa86

Add a way to generate better js coverage

This should pick up coverage from both karma and jest
in Canvas proper.  It should also pick up coverage from anything under
packages/*

closes CORE-1265

Test Plan:
  - Run `COVERAGE=true yarn test`
     - Coverage reports (coverage-final.json) should generate in all
       packages such as (canvas-planner) as well as in coverage-karma
       and coverage-jest
  - Run `yarn run test:coverage`
     - coverage-js folder should be generated.  Opening index.html
       should show the full coverage report
  - Remove coverage-{js, karma, jest} and
    packages/canvas-planner/coverage as well as .nyc_output to get back
    to a clean state
  - Run `RUN_TESTS_FIRST=true yarn run test:coverage`
     - All tests should run and generate the appropriate report just
       like the last time in coverage-js

Change-Id: I50744b8977e0683e079af5bdd2865dbcd6ad9066
Reviewed-on: https://gerrit.instructure.com/146098
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>

2018-07-17 14:19:03 +00:00

2 Commits